Krzysztof kuhy Rudnicki
f58f55f68b
156 ruff findings to 0. That takes the whole archive to 0, from 9,281.
Six of those findings were SQL injection, and they were the real ones. The
connector interpolated a username and an OAuth id straight out of the URL into
f-string SQL. With psycopg2 installed, the difference is not theoretical:
username = "x'; DROP TABLE users; --"
old: select * from users where username='x'; DROP TABLE users; --';
new: select * from users where username='x''; DROP TABLE users; --';
The old form is two statements and the second one runs. The new one is a
parameter, so the whole thing stays a string literal. Every query in that file
is parameterised now.
`get_recommendations` also called
`cursor.execute("... oauth_ID='{}'", oauth_ID)`, which is wrong twice over:
psycopg2 wants %s rather than {}, and its second argument must be a sequence,
not a bare string. That route could never have worked.
Ten blind `except Exception` handlers turned every programming error into a
500 with the message hidden. They are now the exceptions each block can
actually raise -- verified against the installed libraries, where
InvalidIdTokenError and ExpiredIdTokenError really are FirebaseError
subclasses -- and the handlers log a traceback instead of printing the
exception's str().
Three services bound `host="localhost"`. Each of them runs in a container with
a published port, on a compose bridge network, so binding loopback makes them
unreachable from both the host and their siblings. All four now read
ERSMS_HOST, which docker-compose sets to 0.0.0.0, and default to loopback when
run outside Docker. Flask's debug console executes arbitrary code, so that is
opt-in via FLASK_DEBUG too.
`movie_recommender.py` fitted the model at import: reading two CSVs and
building a 4803x4803 similarity matrix as a side effect of `import`. It failed
outright here, since the datasets are not committed. It is in `main()` now, and
the module imports cleanly. `error_decorator` was dead code that swallowed its
wrapped function's return value; it is gone.
Verified: all four modules import (the backend still needs its Firebase
credential JSON, which is not committed, exactly as before), the recommender's
helpers still pick the director out of a crew list, trim cast to three, fold
"Tom Hanks" to "tomhanks" and join a soup in the same order, and every route
parameter rename was matched by the URL rule it comes from.
Three of the four services are clean under mypy --strict. The backend keeps
four errors: flask-sqlalchemy builds `db.Model` dynamically, so `--strict`
refuses to subclass it. Migrating to a typed DeclarativeBase would rewrite both
models in an app that cannot be run here, so those four are reported in
TODO-refactor-remaining.md rather than hidden.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| analytics | ||
| backend | ||
| connector | ||
| database | ||
| docs | ||
| frontend | ||
| movie_recommendations | ||
| nginx | ||
| test_scripts | ||
| .gitignore | ||
| docker-compose.yml | ||
| Dockerfile | ||
| README.md | ||
| run.sh | ||
Projekt z ERSMS
Backend
budowanie i uruchamianie obrazu z bazą danych oraz serwerem:
docker compose up
w przypadku zmian w bazie danych, usunąć kontener oraz dołączone do niego volumy
stronka administracyjna do bazy danych
Najpierw wpisujemy w przeglądarce http://localhost:8080/ Przy logowaniu wpisujemy:
- login - admin@admin.com
- hasło - admin
Po zalogowaniu się poraz pierwszy od zbudowania obrazu, widzimy stronę główną. Klikamy na niej duży przycisk "Add New Server" i pojawia się okienko z menu dodawania serwera.
W nazwie można napisać cokolwiek, jednak w zakładce "Connection" piszemy następujące rzeczy:
- host name - db
- login - root
- password - root
Reszta pozostaje jak była. Po zapisaniu ustawień, mamy już dostęp do narzędzi administratora dla naszej bazy danych.
gadanie z endpointami
GET http://localhost:8090/ - testowy domowy
GET http://localhost:8090//api/v3/get/string:username - info o userach
GET http://localhost:8090//api/v3/get_movie/int:movie_ID - info o filmie
POST http://localhost:8090/api/v3/add/string:oauth_ID/string:username - dodawanie usera
POST http://localhost:8090/api/v3/add/string:oauth_ID/string:movie_ID/int:rating - dodawanie oceny do filmu przez usera
GET http://localhost:8090/api/v3/ai/string:oauth_ID - wyciąganie rekomendacji od AI