mirror of
https://github.com/kuhyx/WUT_Computer_Science.git
synced 2026-11-11 00:27:08 +01:00
kuhy overruled the "do not fix coursework to be better than it was submitted" rule: git history is the archive, so the working tree can be clean. This lands the config and the mechanical half of the cleanup -- 9,281 ruff findings under the fleet config down to 3,686, with no per-file-ignores anywhere. What is in here: - pyproject.toml, the first one in this repo. select = ["ALL"], mypy strict, and the vendored list mirrored into ruff exclude and coverage omit. Five rules are off and each says why; CPY001 is the only judgement call, because stamping a copyright header onto 137 university assignments would assert a licence that was never claimed. No hook is wired up yet -- a gate lands only once its subject is clean. - ruff format + the safe fixes, then a second pass over the docstring rules ruff marks unsafe (they only edit docstring text). 108 files. - TRAK/sightpy is vendored, not coursework: it is rafael-fuente/Python-Raytracer (BSD 3-Clause). Verified against a fresh upstream clone with line endings normalised -- 30 of 32 files byte-identical, ray.py and scene.py carrying a 12- and 13-line local patch that counts rays for the report. 35 files that should never have been linted, now excluded and restored. - WDWR, SPD, MOM and ECRYPT are fully clean, by hand and verified by running them: WDWR's three plot scripts print the same statistics as before, MOM's PuLP model solves to the same cost. WDWR's graph.py had a 342-character CSV header embedded as a string literal, which cannot be wrapped -- the data moved to data/pareto_front.csv. Two 0-byte .py stubs are deleted; an empty file is not a deliverable and git still has it. Three harness bugs found by actually running things: - `run` now forces MPLBACKEND=Agg. TRAK finished its ray trace in 37 seconds and then sat for 45 minutes: plt.show() had opened an image viewer and was waiting for someone to close the window. - TRAK's main.py only pops that viewer with --show now, and its runner writes to a gitignored build/ via the new --entry-args. The default output path is outputs/output.png, which is TRACKED -- a plain run overwrote a submitted deliverable. - course_lib.sh was 357 lines, over this repo's own cap. Split into course_probe.sh and course_run.sh. Verified: ECOTE 26 tests pass, ECRYPT_PROJECT 99 pass, TRAK renders cornell_box in 37s and exits 0, every module compiles, and every import ruff removed was checked to be genuinely unused. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0172dj34FDpao6wsix8ZuCzE
127 lines
4.1 KiB
Bash
127 lines
4.1 KiB
Bash
# shellcheck shell=bash
|
|
# Shared behaviour for every per-course run.sh. Sourced, never executed.
|
|
#
|
|
# A course run.sh is a stub: it declares what kind of project it is, then calls
|
|
# course_main. The logic lives here once, because 44 hand-copied runners is
|
|
# precisely how gates and scripts in this fleet have drifted apart before.
|
|
#
|
|
# Contract (see ../../run.sh):
|
|
# --probe report whether this could run HERE, without running it
|
|
# exit 0 runnable | 78 blocked | 79 nothing to run
|
|
# (no args) actually run it
|
|
#
|
|
# A stub calls:
|
|
# course_main --kind <kind> [--entry <path>] [--entry-args <str>]
|
|
# [--note <text>] [--test-dir <path>] [--no-bibtex] -- "$@"
|
|
# Values are passed as arguments rather than set as globals so that a stub has
|
|
# no assignments a linter has to be told to ignore.
|
|
|
|
readonly COURSE_EXIT_BLOCKED=78
|
|
readonly COURSE_EXIT_NO_CODE=79
|
|
|
|
COURSE_ROOT="$(cd "$(dirname "$(readlink -f "${BASH_SOURCE[1]}")")" && pwd)"
|
|
readonly COURSE_ROOT
|
|
# Repo root is two levels up: every course dir is <repo>/<area>/<course>.
|
|
COURSE_GATES="$(cd "${COURSE_ROOT}/../.." && pwd)/gates"
|
|
readonly COURSE_GATES
|
|
|
|
# --- helpers -----------------------------------------------------------------
|
|
|
|
_have() { command -v "$1" > /dev/null 2>&1; }
|
|
|
|
# Report "blocked" with the reason, which is the whole point of the status
|
|
# table: "needs X" is useful, "failed" is not.
|
|
_blocked() {
|
|
printf '%s\n' "$1"
|
|
exit "$COURSE_EXIT_BLOCKED"
|
|
}
|
|
|
|
_no_code() {
|
|
printf '%s\n' "$1"
|
|
exit "$COURSE_EXIT_NO_CODE"
|
|
}
|
|
|
|
_runnable() { printf '%s\n' "$1"; exit 0; }
|
|
|
|
# First tool present wins; otherwise blocked naming all the candidates.
|
|
_require_any() {
|
|
local label="$1"; shift
|
|
local tool
|
|
for tool in "$@"; do
|
|
if _have "$tool"; then
|
|
printf '%s' "$tool"
|
|
return 0
|
|
fi
|
|
done
|
|
_blocked "needs $label (none of: $*)"
|
|
}
|
|
|
|
# Probe-side variant. _require_any prints the tool it found, so probes have to
|
|
# redirect its stdout -- which also swallowed the failure REASON and turned
|
|
# every blocked probe into "unknown". This one returns a status and prints
|
|
# only on failure.
|
|
_probe_any() {
|
|
local label="$1"; shift
|
|
local tool
|
|
for tool in "$@"; do
|
|
_have "$tool" && return 0
|
|
done
|
|
_blocked "needs $label (none of: $*)"
|
|
}
|
|
|
|
# True if the path is recorded in gates/known-incomplete.txt.
|
|
_is_known_incomplete() {
|
|
local manifest="${COURSE_GATES:-}/known-incomplete.txt"
|
|
[[ -f "$manifest" ]] || return 1
|
|
local rel="$1"
|
|
grep -vE '^\s*#|^\s*$' "$manifest" | grep -qxF "$rel"
|
|
}
|
|
|
|
_first_file() {
|
|
find "$COURSE_ROOT" -name "$1" -not -path '*/node_modules/*' -print -quit 2>/dev/null
|
|
}
|
|
|
|
|
|
# The probe and the runner are one case statement each and together are most of
|
|
# this file's length, so they live beside it rather than in it. SCRIPTDIR is
|
|
# resolved from BASH_SOURCE[0] -- BASH_SOURCE[1] is the *caller*, which is a
|
|
# per-course run.sh two directories away.
|
|
_COURSE_LIB_DIR="$(cd "$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")" && pwd)"
|
|
# shellcheck source-path=SCRIPTDIR
|
|
# shellcheck source=course_probe.sh
|
|
. "${_COURSE_LIB_DIR}/course_probe.sh"
|
|
# shellcheck source-path=SCRIPTDIR
|
|
# shellcheck source=course_run.sh
|
|
. "${_COURSE_LIB_DIR}/course_run.sh"
|
|
|
|
course_main() {
|
|
COURSE_KIND=""
|
|
COURSE_ENTRY=""
|
|
COURSE_NOTE=""
|
|
COURSE_TEST_DIR=""
|
|
COURSE_TEX_NO_BIBTEX=""
|
|
COURSE_ENTRY_ARGS=""
|
|
while [[ $# -gt 0 ]]; do
|
|
case "$1" in
|
|
--kind) COURSE_KIND="$2"; shift 2 ;;
|
|
--entry) COURSE_ENTRY="$2"; shift 2 ;;
|
|
--note) COURSE_NOTE="$2"; shift 2 ;;
|
|
--test-dir) COURSE_TEST_DIR="$2"; shift 2 ;;
|
|
--no-bibtex) COURSE_TEX_NO_BIBTEX=1; shift ;;
|
|
--entry-args) COURSE_ENTRY_ARGS="$2"; shift 2 ;;
|
|
--) shift; break ;;
|
|
*) break ;;
|
|
esac
|
|
done
|
|
|
|
case "${1:-}" in
|
|
--probe) _probe ;;
|
|
-h | --help)
|
|
printf 'usage: %s [--probe]\n' "$(basename "$0")"
|
|
printf ' --probe report runnable/blocked/no-code without running\n'
|
|
;;
|
|
"") _run ;;
|
|
*) printf 'unknown option: %s\n' "$1" >&2; return 1 ;;
|
|
esac
|
|
}
|