mirror of
https://github.com/kuhyx/WUT_Computer_Science.git
synced 2026-11-10 18:47:11 +01:00
Krzysztof kuhy Rudnicki
a8a2710ebd
kuhy chose the strict branch: no per-file-ignores at all, not even the S101 block that ruff's own docs and the rest of this fleet carry for test code. So 125 test assertions were rewritten to raise instead of assert. Rather than 125 copies of `if x != y: raise AssertionError(...)`, each course grows a small expect module -- expect_equal / expect_in / expect_true / expect_false. That is also strictly better output than a bare assert here: pytest's assertion rewriting does not reach into a helper, so the helper has to print both values, and it does. The rewrite itself went through ast, not a regex, because seven of ECOTE's asserts were wrapped over several lines. Everything else in the two courses is gone as well: - 66 argument and 37 return annotations on the translator, worked out from what each function actually returns rather than stamped on as Any -- `list[str] | str` where a function returns "Error!" or the parsed columns. - 16 prints became logger.error with %-style arguments. The messages still reach stderr with no basicConfig, via logging's last-resort handler, so the translator behaves exactly as before. - Two `open()` calls became Path.open / Path.write_text, six RET504 assign-then-return pairs collapsed, one 380-character expected-HTML literal split into implicitly concatenated pieces (it cannot be wrapped any other way, which is what ISC001 being off is for), and one block of commented-out code deleted. - ECRYPT_PROJECT/__init__.py removed. It made the COURSE directory a package, which nothing imports, and it was the sole cause of `N999 Invalid module name: 'ECRYPT_PROJECT'`; with it gone, sieve is the top-level package and its name is fine. Verified by running both, not by reading: ECOTE 26 tests pass and `python -m translator.main --filename examples/complicated/table1.tex` still writes the same HTML with the same three column-count warnings on stderr; ECRYPT_PROJECT 99 tests pass. Repo-wide: 3,686 findings -> 3,159. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0172dj34FDpao6wsix8ZuCzE
41 lines
1.4 KiB
Python
41 lines
1.4 KiB
Python
"""Assertion helpers for the ECOTE test suite.
|
|
|
|
This repo runs ruff with ``select = ["ALL"]`` and no per-file-ignores, so a
|
|
bare ``assert`` is an ``S101`` violation even inside a test. These raise
|
|
``AssertionError`` explicitly and, unlike a bare assert, always report both
|
|
values -- pytest's assertion rewriting does not apply to a helper, so the
|
|
message has to carry the detail itself.
|
|
"""
|
|
|
|
|
|
def expect_equal(actual: object, expected: object) -> None:
|
|
"""Raise unless *actual* equals *expected*."""
|
|
if actual != expected:
|
|
msg = f"expected {expected!r}, got {actual!r}"
|
|
raise AssertionError(msg)
|
|
|
|
|
|
def expect_in(member: str, container: str) -> None:
|
|
"""Raise unless *member* is contained in *container*."""
|
|
if member not in container:
|
|
msg = f"expected {member!r} to be in {container!r}"
|
|
raise AssertionError(msg)
|
|
|
|
|
|
def expect_true(actual: object) -> None:
|
|
"""Raise unless *actual* equals ``True``.
|
|
|
|
Separate from expect_equal so that a caller never has to pass a bare
|
|
boolean positionally, which is FBT003.
|
|
"""
|
|
if actual is not True:
|
|
msg = f"expected True, got {actual!r}"
|
|
raise AssertionError(msg)
|
|
|
|
|
|
def expect_false(actual: object) -> None:
|
|
"""Raise unless *actual* equals ``False``."""
|
|
if actual is not False:
|
|
msg = f"expected False, got {actual!r}"
|
|
raise AssertionError(msg)
|