mirror of
https://github.com/kuhyx/WUT_Computer_Science.git
synced 2026-11-10 19:07:11 +01:00
Krzysztof kuhy Rudnicki
a8a2710ebd
kuhy chose the strict branch: no per-file-ignores at all, not even the S101 block that ruff's own docs and the rest of this fleet carry for test code. So 125 test assertions were rewritten to raise instead of assert. Rather than 125 copies of `if x != y: raise AssertionError(...)`, each course grows a small expect module -- expect_equal / expect_in / expect_true / expect_false. That is also strictly better output than a bare assert here: pytest's assertion rewriting does not reach into a helper, so the helper has to print both values, and it does. The rewrite itself went through ast, not a regex, because seven of ECOTE's asserts were wrapped over several lines. Everything else in the two courses is gone as well: - 66 argument and 37 return annotations on the translator, worked out from what each function actually returns rather than stamped on as Any -- `list[str] | str` where a function returns "Error!" or the parsed columns. - 16 prints became logger.error with %-style arguments. The messages still reach stderr with no basicConfig, via logging's last-resort handler, so the translator behaves exactly as before. - Two `open()` calls became Path.open / Path.write_text, six RET504 assign-then-return pairs collapsed, one 380-character expected-HTML literal split into implicitly concatenated pieces (it cannot be wrapped any other way, which is what ISC001 being off is for), and one block of commented-out code deleted. - ECRYPT_PROJECT/__init__.py removed. It made the COURSE directory a package, which nothing imports, and it was the sole cause of `N999 Invalid module name: 'ECRYPT_PROJECT'`; with it gone, sieve is the top-level package and its name is fine. Verified by running both, not by reading: ECOTE 26 tests pass and `python -m translator.main --filename examples/complicated/table1.tex` still writes the same HTML with the same three column-count warnings on stderr; ECRYPT_PROJECT 99 tests pass. Repo-wide: 3,686 findings -> 3,159. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0172dj34FDpao6wsix8ZuCzE
34 lines
1.3 KiB
Python
34 lines
1.3 KiB
Python
"""Check the sieve against the reference prime and composite tables.
|
|
|
|
Both parametrised fixtures come from ``conftest.py``, which reads the CSVs in
|
|
this directory -- so "a prime" here means a number this course was given as
|
|
prime, not one this code decided was prime.
|
|
|
|
The assertions raise instead of using ``assert``: this repo runs ruff with
|
|
``select = ["ALL"]`` and no per-file-ignores, and a bare assert is ``S101``.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from .project import sieve_of_eratosthenes
|
|
|
|
|
|
def test_positives(prime: int, primes_obtained: list[int]) -> None:
|
|
"""Every number the reference table calls prime is found by the sieve."""
|
|
if prime not in primes_obtained:
|
|
msg = f"{prime} is prime but the sieve did not report it"
|
|
raise AssertionError(msg)
|
|
|
|
|
|
def test_composites(composite: int, primes_obtained: list[int]) -> None:
|
|
"""No number the reference table calls composite is reported as prime."""
|
|
if composite in primes_obtained:
|
|
msg = f"{composite} is composite but the sieve reported it as prime"
|
|
raise AssertionError(msg)
|
|
|
|
|
|
def test_negatives() -> None:
|
|
"""A non-positive bound is rejected rather than silently returning []."""
|
|
with pytest.raises(ValueError, match="should not be negative"):
|
|
sieve_of_eratosthenes(-1)
|