From 624ae47cfdf94fc47f8150ad0001a3b3a108cfab Mon Sep 17 00:00:00 2001 From: Krzysztof kuhy Rudnicki Date: Sat, 21 Nov 2026 15:01:03 +0100 Subject: [PATCH] app: fit settings_screen under the line cap Co-Authored-By: Claude Opus 5.5 --- app/lib/screens/settings_screen.dart | 15 +++++---------- app/pubspec.yaml | 2 +- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/app/lib/screens/settings_screen.dart b/app/lib/screens/settings_screen.dart index 3b84d06..8bab5ac 100644 --- a/app/lib/screens/settings_screen.dart +++ b/app/lib/screens/settings_screen.dart @@ -51,8 +51,7 @@ class SettingsScreen extends StatefulWidget { this.firebaseFactory, }); - /// Injectable HTTP client for the linked [GitHubMirrorScreen]; tests pass - /// a [MockClient]. + /// HTTP client for the linked [GitHubMirrorScreen]; tests pass [MockClient]. final http.Client? httpClient; /// Injectable battery-optimization-exemption request; tests pass a fake. @@ -72,14 +71,10 @@ class SettingsScreen extends StatefulWidget { /// Reads the stored Firebase account. Injected for the same reason as /// [googleFirebaseFactory]: the keystore is a platform channel. /// - /// Deliberately backed by [storedAccount], not [loadAccount]: the shared - /// `SyncSettingsScreen` uses this single closure both to display the - /// status and to read back the account right after a Google sign-in. - /// [loadAccount]'s desktop-wrapper fallback resolves to `file:///` on - /// Android and throws -- verified on the phone, where it turned a - /// successful sign-in into "Google sign-in failed". `storedAccount` is the - /// keystore-only read [firebase_backend.dart] documents for exactly this - /// read-back case. + /// Backed by [storedAccount], not [loadAccount]: the shared screen reads + /// the account back right after a Google sign-in, and [loadAccount]'s + /// desktop fallback throws on Android (seen on the phone as "Google sign-in + /// failed"). See the keystore-only read in [firebase_backend.dart]. final Future Function()? accountLoader; /// Persists the account. See [accountLoader]. diff --git a/app/pubspec.yaml b/app/pubspec.yaml index a1465f2..1545827 100644 --- a/app/pubspec.yaml +++ b/app/pubspec.yaml @@ -2,7 +2,7 @@ name: diet_guard_app description: "Companion phone app for diet_guard: log meals on the go." publish_to: 'none' -version: 1.0.191+1 +version: 1.0.192+1 environment: sdk: ^3.12.2