2 Commits

Author	SHA1	Message	Date
Krzysztof kuhy Rudnicki	1e201acbdc	Split _sync.py and its tests; extract the gate fixtures from conftest ... _sync.py 498 -> 165, into siblings that each own one concern: _sync_client.py picking a backend and building the remote store _sync_banks.py pull/merge/push for the food bank and the budget _sync_paths.py the kuhyx/syncs wire layout, shared by both _sync_errors.py SyncError, so _sync and _sync_client need not import each other The patch targets moved with the code they guard, which is the whole risk of this commit. unittest.mock.patch and monkeypatch.setattr both bind to a *module object*, so a patch left pointing at _sync after CONFIG_FILE and SYNC_TOKEN_FILE moved to _sync_client redirects nothing. That is not hypothetical here: the first run of the suite took 9m18s instead of 7s and raised 401s, because tests were reaching the real GitHub API with a fake token. Repointed: conftest SYNC_TOKEN_FILE, CONFIG_FILE -> _sync_client test_sync* GitHubSyncClient (30 patch sites) -> _sync_client test_backend mirror/firebase_client_for -> _sync_client The repo's own _test_guard caught the same leak independently, which is the behaviour worth keeping: two guards, both fail-closed. test_sync.py 482 -> 205, splitting the budget and pull/revision classes into siblings and the shared fakes into _sync_fakes.py. conftest.py 284 -> 155, moving the Tk/gatelock fixtures to _gate_fixtures.py. Importing them back is what registers them (pytest_plugins is an error in a non-root conftest), and they are named in __all__ because ruff's autofix otherwise deletes the "unused" import and silently disables Tk blocking -- it did exactly that once here. Verified afterwards with a canary asserting _gatelock.tk is still a MagicMock, not merely that the suite passes. Verified: 692 tests / 100% coverage unchanged; ~/.local/share/diet_guard byte-identical before and after the run; cd /tmp && python3 -m diet_guard sync -> 402 entries, exit 0. Gate 47 -> 44. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MK3HCZrM75sRHL1gL8usve	2026-08-15 18:51:18 +02:00
Krzysztof kuhy Rudnicki	458f10515b	Make the phone publish on every tick, and fail closed on Firebase errors ... Meals logged on the phone stopped reaching the PC, so the gate kept locking for slots that were already logged and the only way through was to spam "nothing". The PC's fetch was never broken: it was faithfully pulling a Firebase that did not contain the phone's meals. The phone had no working publish backstop on either transport: - `checkAndNotify` gated its sync on `due.isNotEmpty`. Logging every meal promptly means nothing is ever due, so the ~15-min periodic task never published. It was a notification job that happened to sync, not a sync timer. It now syncs on every tick it is asked to, then computes due slots from the merged result, so a meal pulled from another device suppresses a nag instead of triggering one. - `backgroundSyncPush` never called `initSyncDeviceId()`. A fresh isolate has its own static state, so `currentSyncDeviceId` fell back to the compile-time 'phone' constant and published to `devices/phone/` rather than the persisted uuid -- which then makes the next foreground push see `unchanged` and skip writing the uuid directory entirely. Separately, on the "Fetch from sync" path itself: `FirebaseSyncError` and `FirebaseAuthError` are siblings of `GitHubSyncError` under `RemoteSyncError`, not subclasses, so every per-request failure of the *primary* backend escaped `pull_shared_log`'s catch tuple and raised a traceback out of a helper documented to fail closed with a reason string. `ConfigError` needed the same treatment by a different route: it subclasses `Exception` directly, so it is outside `RemoteSyncError` too, and is now translated at `_client_for_run`. The PAT is no longer mandatory either. Firebase is primary, but `_read_token` ran before the client was ever built, so a Firebase-only machine could not sync at all -- the commits that fixed this touched only the Dart side. A stalled sync was invisible: the config gates returned silently and `openFirebase` swallowed every error. `dart:developer`'s `log()` does not reach logcat on a release build (verified on device), so logging alone would not have surfaced it. `SyncHealth` records each tick's outcome and the log screen shows a banner when publishing has actually stopped. Also make the real-Tk probes bypass the window manager. A tiling WM retiles a managed toplevel instead of honouring the requested geometry, so `winfo_height` reported 0/1px and the layout and focus-ring assertions failed on noise rather than on any regression -- 8 failures on the dev machine that only passed under Xvfb. `overrideredirect` makes the measurement deterministic with or without a WM; the probes still detect a genuine overflow at 1366x300. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RT8X32S9yDLW1Xf1PDq8z7	2026-08-10 14:35:37 +02:00