2 Commits

Author	SHA1	Message	Date
Krzysztof kuhy Rudnicki	cbbebee79b	Pin meal pills to one row; drop the "Logged" restatement ... Three independent cleanups ahead of the configurable meal schedule. Pills: the row was a `Wrap`, so pills dropped onto a second line as soon as they outgrew the width -- which they do even at four. Measured: a logged chip is ~124px at Material defaults, so four need 522px against ~330px of phone width. Now a `FittedBox(scaleDown)` over a `Row`, which scales the row down uniformly, plus compact chip density so there is less to scale away. A `Row` of `Expanded` children was the obvious alternative and is wrong: it imposes a tight width, and a Chip narrower than avatar+padding+label clips its label rather than shrinking -- measured at 10px per label, about one character, while throwing no overflow error. The new regression test therefore asserts both a shared baseline and a legible label width; it was confirmed to fail on the old `Wrap` ("chip wrapped to a second line at 320.0") rather than passing vacuously. Card: the `Logged "<meal>".` line restated the description the user had just typed. Removed, along with `TodayProgress.justLogged`, which nothing else read. The kcal position, macros and streak stay. refactor_claude_todo.md: the 250-line file-splitting refactor it tracked is done -- `scripts/check_file_length.sh --all` exits 0 and an independent sweep finds nothing over the cap. DESIGN_AUDIT_TODO.md is a separate, still-open effort and stays. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0159b4E5hh512jYUeaJVNxfM	2026-08-16 14:18:39 +02:00
Krzysztof kuhy Rudnicki	f7f06aee53	Remove unused features; fix reminder false alarms; share all state ... Four asks, plus the fixes two review passes turned up. Removals (all unused): - "Repeat last meal" button, and the reward/temptation-bundling prompt it was the sole trigger for. Replaced with a post-log progress card showing kcal against budget, macros, and the adherence streak. - The multi-item meal builder, on both the gate and the phone. The stored `components` field stays: nothing writes it now, but historical composite entries and the food bank still read it and it is part of the wire format. - Meal photos entirely: 13 files, `imagePath`, the photo filter, the wrapper's /blobs/ route, image_picker, and the CAMERA permission. Reminder false alarms had three real causes, all fixed: - Logging never reconciled notifications, so a reminder sat on screen up to 15 minutes after the meal was logged -- on the phone itself. - The background check never pulled, so a PC-logged meal nagged forever until the app was opened. Now mirrors _cli_gate._should_lock: cheap local check, network only when a slot looks due, then re-check. - Meals before 08:00 / after 22:00 were attributed to no slot at all. New slot_for_log/slotForLog clamps them to the first/last slot, byte-identical across Python and Dart. Deliberately separate from elapsed_slots, which would otherwise make every slot fall due at 23:00. Budget history, so lowering the budget stops rewriting the past: - Forward-only (effective_from, kcal) entries; each day is judged against the budget in force then. Verified live: setting 2000 left a 36-day adherence streak and the whole calendar pixel-identical. - Rides as hist:<date> fields on the existing budget record. crdt_sync merges per-field over the union of field names and both devices push the merged log, so a device that predates the feature relays them untouched -- no coordinated rollout, no second document. - The seed guard tests emptiness, not file presence: _sync can write an empty history after merging with a pre-feature peer, and a presence check would then never seed again, silently reclassifying every past day. One shared source of truth for every piece of data: - Body weight now travels as its own `weight` CRDT field. Inside `value` it was collateral damage of whole-map LWW -- any phone budget edit deleted it, and the protein target with it. - Both halves of the food bank sync. The curated half (foods added without eating them) was the last device-local state. The derived half merges with count as the clock, so LWW means max-count-wins; the log stays authoritative for membership, because a CRDT union never shrinks and a peer's stale copy would otherwise resurrect a deleted food permanently. - Bank adapters honour tombstones, and Dart parses bank records defensively: a cast failure there is an Error, not an Exception, so one malformed remote record would have broken phone sync permanently. _test_guard.py blocks any pathlib write to real user state while pytest is in the process, whatever conftest is loaded. A throwaway test run outside the package conftest destroyed a real GitHub token during this work; this makes that class of accident impossible rather than merely discouraged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-07-26 16:39:52 +02:00