diet-guard/app/test/services/indexeddb_stores_test.dart
Krzysztof kuhy Rudnicki f7f06aee53
Some checks failed
pre-commit / pre-commit (push) Has been cancelled
Tests / test (3.10) (push) Has been cancelled
Tests / test (3.11) (push) Has been cancelled
Tests / test (3.12) (push) Has been cancelled
Remove unused features; fix reminder false alarms; share all state
Four asks, plus the fixes two review passes turned up.

Removals (all unused):
- "Repeat last meal" button, and the reward/temptation-bundling prompt it
  was the sole trigger for. Replaced with a post-log progress card showing
  kcal against budget, macros, and the adherence streak.
- The multi-item meal builder, on both the gate and the phone. The stored
  `components` field stays: nothing writes it now, but historical composite
  entries and the food bank still read it and it is part of the wire format.
- Meal photos entirely: 13 files, `imagePath`, the photo filter, the
  wrapper's /blobs/ route, image_picker, and the CAMERA permission.

Reminder false alarms had three real causes, all fixed:
- Logging never reconciled notifications, so a reminder sat on screen up to
  15 minutes after the meal was logged -- on the phone itself.
- The background check never pulled, so a PC-logged meal nagged forever
  until the app was opened. Now mirrors _cli_gate._should_lock: cheap local
  check, network only when a slot looks due, then re-check.
- Meals before 08:00 / after 22:00 were attributed to no slot at all. New
  slot_for_log/slotForLog clamps them to the first/last slot, byte-identical
  across Python and Dart. Deliberately separate from elapsed_slots, which
  would otherwise make every slot fall due at 23:00.

Budget history, so lowering the budget stops rewriting the past:
- Forward-only (effective_from, kcal) entries; each day is judged against
  the budget in force then. Verified live: setting 2000 left a 36-day
  adherence streak and the whole calendar pixel-identical.
- Rides as hist:<date> fields on the existing budget record. crdt_sync
  merges per-field over the union of field names and both devices push the
  merged log, so a device that predates the feature relays them untouched --
  no coordinated rollout, no second document.
- The seed guard tests emptiness, not file presence: _sync can write an
  empty history after merging with a pre-feature peer, and a presence check
  would then never seed again, silently reclassifying every past day.

One shared source of truth for every piece of data:
- Body weight now travels as its own `weight` CRDT field. Inside `value` it
  was collateral damage of whole-map LWW -- any phone budget edit deleted it,
  and the protein target with it.
- Both halves of the food bank sync. The curated half (foods added without
  eating them) was the last device-local state. The derived half merges with
  count as the clock, so LWW means max-count-wins; the log stays
  authoritative for membership, because a CRDT union never shrinks and a
  peer's stale copy would otherwise resurrect a deleted food permanently.
- Bank adapters honour tombstones, and Dart parses bank records defensively:
  a cast failure there is an Error, not an Exception, so one malformed
  remote record would have broken phone sync permanently.

_test_guard.py blocks any pathlib write to real user state while pytest is
in the process, whatever conftest is loaded. A throwaway test run outside
the package conftest destroyed a real GitHub token during this work; this
makes that class of accident impossible rather than merely discouraged.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-26 16:39:52 +02:00

96 lines
3.2 KiB
Dart

// The IndexedDB document store is the desktop device's primary copy of the
// food log, and its wrapper-mirror fallback is the recovery path for a wiped
// Chrome profile. `idb_shim`'s in-memory backend lets all of that run on the
// plain VM, so none of it has to ship untested just because it only executes
// in a browser.
import 'dart:convert';
import 'package:diet_guard_app/services/desktop_wrapper.dart';
import 'package:diet_guard_app/services/document_store_indexeddb.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:http/http.dart' as http;
import 'package:http/testing.dart';
import 'package:idb_shim/idb_shim.dart';
/// Stands in for the desktop wrapper: records what was mirrored to it and
/// serves back whatever it has been seeded with.
class _FakeWrapper {
final Map<String, List<int>> stored = {};
var offline = false;
http.Client get client => MockClient((request) async {
if (offline) throw http.ClientException('no wrapper running');
final name = request.url.pathSegments.last;
if (request.method == 'POST') {
stored[name] = request.bodyBytes;
return http.Response('', 204);
}
final body = stored[name];
if (body == null) return http.Response('', 404);
return http.Response.bytes(body, 200);
});
}
Future<Database> _openMemoryDb(String store) => newIdbFactoryMemory().open(
'test',
version: 1,
onUpgradeNeeded: (event) => event.database.createObjectStore(store),
);
void main() {
late _FakeWrapper wrapper;
setUp(() => wrapper = _FakeWrapper());
group('IndexedDbDocumentStore', () {
late IndexedDbDocumentStore store;
setUp(() async {
store = IndexedDbDocumentStore(
await _openMemoryDb(IndexedDbDocumentStore.storeName),
httpClient: wrapper.client,
);
});
test('round-trips a document', () async {
await store.write('food_log.json', '{"2026-07-20":[]}');
expect(await store.read('food_log.json'), '{"2026-07-20":[]}');
});
test('mirrors every write to the wrapper', () async {
// The mirror is what makes a wiped Chrome profile recoverable, so a
// write that only reaches IndexedDB is a silent data-loss risk.
await store.write('food_log.json', '{"a":1}');
expect(utf8.decode(wrapper.stored['food_log.json']!), '{"a":1}');
});
test('recovers from the wrapper when IndexedDB is empty', () async {
// Exactly the cleared-profile case: nothing local, everything on disk.
wrapper.stored['food_log.json'] = utf8.encode('{"recovered":true}');
expect(await store.read('food_log.json'), '{"recovered":true}');
});
test('returns null when neither side has the document', () async {
expect(await store.read('food_bank.json'), null);
});
test('returns null when the wrapper is not running', () async {
// Opened as a plain browser tab: no wrapper, no mirror, still usable.
wrapper.offline = true;
expect(await store.read('food_log.json'), null);
});
test('a write still succeeds with no wrapper running', () async {
wrapper.offline = true;
await store.write('food_log.json', '{"a":1}');
expect(await store.read('food_log.json'), '{"a":1}');
});
});
}