mirror of
https://github.com/kuhyx/diet-guard.git
synced 2026-11-11 13:07:40 +01:00
Krzysztof kuhy Rudnicki
6258b35f88
Some checks are pending
file-length / file length <= 250 lines (push) Waiting to run
pre-commit / pre-commit (push) Waiting to run
Tests / test (3.10) (push) Waiting to run
Tests / test (3.11) (push) Waiting to run
Tests / test (3.12) (push) Waiting to run
release-apk / release (APK) (push) Waiting to run
Two independent costs in the background tick, both pure waste.
`list_directory` was called four times per tick -- once by the log pull and
once by each of the three bank syncs. It is the single most expensive call
in a tick at ~445ms mirrored (the GitHub half alone is ~360ms), so that was
~1.3s spent asking the same question four times. It is now listed once in
`run_sync` and passed down.
The curated-bank loop was worse: 17s and 62 requests to fetch *zero* useful
bytes. Firebase returns None for every peer's `food_bank_manual.json`, so
`MirrorSyncClient.get_file_text` treated each miss as "this device has not
migrated yet" and fell through to GitHub, which answers `{}` after ~320ms.
`_primary_only_text` skips that per-peer fallthrough for this one artifact.
Checked before narrowing rather than assumed, because CLAUDE.md requires
both halves of the food bank to sync: reading every peer's curated bank
straight off the mirror found 23 absent, 2 empty, and zero non-empty. No
curated food exists on the mirror alone. The probe is written into the
docstring so it can be re-run before anyone widens this again.
Measured end to end: manual-bank loop 17.0s -> 3.4s, full tick ~27s -> 15.2s,
log/bank/peer state unchanged (441 entries, 117 foods, 22 peers).
`_pull_remote_logs` now returns the revisions it saw instead of mutating a
caller-supplied dict, which keeps it under the argument limit and makes the
data flow visible at the call site.
Deliberately NOT done: revision-skipping the derived food bank. `run_sync`
rebuilds that bank from the merged log immediately before syncing it, so
unlike the log the peer records are not durably held locally -- skipping a
peer would drop its counts from the pushed bank and oscillate under
max-count-wins. Verified empirically: the on-disk bank and a pure log-derived
rebuild are identical (117 foods, 0 differing counts), and the 2 foods peers
know that the local bank lacks are discarded by the existing `if name in
local` filter anyway. The loop is off every interactive path now, so the
remaining cost is background-only.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LJ5YnA3CERitQ57HjMu2Qz
|
||
|---|---|---|
| .. | ||
| sync_merge | ||
| tests | ||
| __init__.py | ||
| __main__.py | ||
| _averages_periods.py | ||
| _averages_report.py | ||
| _averages.py | ||
| _budget_biometrics.py | ||
| _budget_derived.py | ||
| _budget_history.py | ||
| _budget.py | ||
| _calendar_view.py | ||
| _cli_args.py | ||
| _cli_averages.py | ||
| _cli_gate.py | ||
| _cli_init.py | ||
| _cli_log.py | ||
| _cli_sync.py | ||
| _cli.py | ||
| _coerce.py | ||
| _constants.py | ||
| _daystatus.py | ||
| _device.py | ||
| _estimator_off.py | ||
| _estimator.py | ||
| _foodbank_manual.py | ||
| _foodbank_rebuild.py | ||
| _foodbank_search.py | ||
| _foodbank.py | ||
| _fuzzy.py | ||
| _gate.py | ||
| _gatelock_budgetedit.py | ||
| _gatelock_calendar_schedule.py | ||
| _gatelock_calendar_types.py | ||
| _gatelock_calendar_ui.py | ||
| _gatelock_calendar_widgets.py | ||
| _gatelock_calendar.py | ||
| _gatelock_core.py | ||
| _gatelock_dashboard.py | ||
| _gatelock_fetch.py | ||
| _gatelock_fields.py | ||
| _gatelock_groups.py | ||
| _gatelock_layout.py | ||
| _gatelock_lockfile.py | ||
| _gatelock_mealflow.py | ||
| _gatelock_nutrition.py | ||
| _gatelock_scheduleedit.py | ||
| _gatelock_spacing.py | ||
| _gatelock_support.py | ||
| _gatelock_typography.py | ||
| _gatelock_ui_types.py | ||
| _gatelock_ui.py | ||
| _gatelock_widgetgroups.py | ||
| _gatelock.py | ||
| _mcp_read.py | ||
| _mcp_server.py | ||
| _mcp.py | ||
| _meal_schedule_store.py | ||
| _meal_schedule.py | ||
| _portions.py | ||
| _resolve.py | ||
| _slots.py | ||
| _state_sync.py | ||
| _state_today.py | ||
| _state.py | ||
| _sync_banks.py | ||
| _sync_client.py | ||
| _sync_errors.py | ||
| _sync_events.py | ||
| _sync_paths.py | ||
| _sync_refresh.py | ||
| _sync.py | ||
| _test_guard.py | ||