diet-guard/app/lib/services/sync_merge.dart
Krzysztof kuhy Rudnicki fef140d970 Split wrapper_server and sync_merge into siblings
Two Dart files whose contents were already cleanly separable.

wrapper_server.dart (254 -> 228): contentTypeFor is a pure function of the
path with no server state, so it moves to content_types.dart as a plain
library. WrapperServer.contentTypeFor stays as a static forwarder because the
test reaches for it by that name.

sync_merge.dart (475 -> 190): three near-independent blocks -- daylog, banks,
budget -- split along the seams the tests already use. The banks and budget
adapters move to siblings and are re-exported, so sync_service.dart and both
test files import exactly what they did before and needed no edits.

Flutter 555 tests unchanged; analyze clean; gate 52 -> 49.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MK3HCZrM75sRHL1gL8usve
2026-08-15 16:42:27 +02:00

191 lines
7.2 KiB
Dart

/// Entry <-> crdt_sync.Record adapters for diet_guard_app's cross-device
/// sync.
///
/// This app's own local storage format is unchanged -- only the
/// GitHub-synced wire format and the cross-device merge algorithm now go
/// through `crdt_sync`'s `Record`/`Log`/`Hlc` primitives, the same ones the
/// PC (`diet_guard/_sync_merge.py`) and every other kuhy app that syncs
/// this way uses.
///
/// Each [FoodEntry] maps to one [Record] with a single opaque `body` field
/// holding [FoodEntry.toSyncJson] (which excludes `hmac`: it is never
/// computed here, since the phone never holds the shared key, and the PC
/// re-signs every entry on merge regardless of origin).
/// Entries are immutable after creation (only `deleted` ever changes
/// post-write), so there is no benefit to crdt_sync's per-field LWW
/// granularity here -- the whole body shares one derived [Hlc].
///
/// Backward compatible with devices not yet migrated: [parseRemoteLog]
/// tries the new Record-based wire format first and falls back to the old
/// plain-DayLog format, converting old-format entries through the same
/// adapter used for the local log.
///
/// The budget adapters at the bottom of this file ([budgetToLog] etc.)
/// follow the same Record/Log shape, but a budget record is edited
/// repeatedly (not immutable-after-creation like a food-log entry), so its
/// [Hlc] is derived from a `t` edit timestamp
/// (`AppSettingsService.dailyKcalGoalUpdatedAt`) rather than a birth time
/// that never changes -- mirrors `diet_guard/_sync_merge.py`'s budget
/// adapters field-for-field.
library;
import 'dart:convert';
import 'package:crdt_sync/crdt_sync.dart';
import 'package:crypto/crypto.dart';
import 'package:diet_guard_app/models/food_entry.dart';
import 'package:diet_guard_app/services/log_storage_service.dart';
import 'package:diet_guard_app/services/sync_device_id.dart';
// The bank and budget adapters moved out for file size. Re-exported here so
// `import 'services/sync_merge.dart'` still reaches every adapter, which is
// what sync_service.dart and both test files expect.
export 'package:diet_guard_app/services/sync_merge_banks.dart';
export 'package:diet_guard_app/services/sync_merge_budget.dart';
/// Derives a deterministic [Hlc] for [entry] from its own `time` field.
///
/// The same entry always yields the same Hlc regardless of when this runs
/// -- entries are immutable after creation, so there's no real "now" to
/// stamp, just the birth-time already recorded on the entry itself.
/// Malformed/missing `time` still yields a valid (if early-sorting) Hlc
/// rather than throwing -- this only affects tie-breaking between
/// otherwise-identical copies of the same id, never whether the entry
/// survives a merge.
Hlc entryHlc(FoodEntry entry) {
final wallTimeMs = DateTime.tryParse(entry.time)?.millisecondsSinceEpoch ?? 0;
return Hlc.newTick(currentSyncDeviceId, wallTimeMsOverride: wallTimeMs);
}
/// Deterministic id for a pre-`id` legacy entry, from `(time, desc)`.
///
/// Two devices holding the same legacy entry independently derive the same
/// id without communicating, so they merge as one record instead of two --
/// the same guarantee the old `(time, desc)` dedup key gave, just expressed
/// as a real id going forward.
String legacyEntryId(FoodEntry entry) {
final key = '${entry.time}|${entry.desc}';
final digest = sha256.convert(utf8.encode(key)).toString().substring(0, 32);
return 'legacy-$digest';
}
/// Converts one [FoodEntry] to a crdt_sync [Record].
Record entryToRecord(FoodEntry entry) {
final id = (entry.id != null && entry.id!.isNotEmpty)
? entry.id!
: legacyEntryId(entry);
final hlc = entryHlc(entry);
final body = entry.toSyncJson()
..remove('id')
..remove('deleted');
return Record(
id: id,
fields: {'body': (body, hlc)},
deleted: entry.deleted,
deletedHlc: entry.deleted ? hlc : null,
);
}
/// Converts one crdt_sync [Record] back to a [FoodEntry].
FoodEntry recordToEntry(Record record) {
final bodyValue = record.fields['body']?.$1;
final body = bodyValue is Map
? bodyValue.cast<String, dynamic>()
: <String, dynamic>{};
return FoodEntry.fromJson({
...body,
'id': record.id,
'deleted': record.deleted,
});
}
/// Converts a full local/remote [DayLog] into a crdt_sync [Log].
Log dayLogToLog(DayLog daylog) {
final log = <String, Record>{};
for (final entries in daylog.values) {
for (final entry in entries) {
final record = entryToRecord(entry);
log[record.id] = record;
}
}
return log;
}
/// Converts a merged crdt_sync [Log] back into [DayLog] shape.
///
/// Each entry is re-bucketed under its own `time`'s date rather than
/// whatever date key it might have arrived under, and each day's entries
/// are sorted oldest-first -- matching the existing on-disk convention.
DayLog logToDayLog(Log log) {
final daylog = <String, List<FoodEntry>>{};
for (final record in log.values) {
final entry = recordToEntry(record);
final dateKey = entry.time.length >= 10
? entry.time.substring(0, 10)
: entry.time;
daylog.putIfAbsent(dateKey, () => []).add(entry);
}
for (final entries in daylog.values) {
entries.sort((a, b) => a.time.compareTo(b.time));
}
return daylog;
}
/// Returns true if [raw] is shaped like a crdt_sync Record-keyed Log.
///
/// An empty object is ambiguous but harmless either way (no entries to
/// convert), so it's treated as new format to skip the old-format
/// conversion pass for nothing.
bool _looksLikeNewFormat(Map<String, dynamic> raw) => raw.values.every(
(value) =>
value is Map<String, dynamic> &&
value.containsKey('fields') &&
value.containsKey('id'),
);
/// Parses one device's pushed log text into a crdt_sync [Log].
///
/// Tries the new Record-based wire format first; falls back to the old
/// plain-DayLog format (today's on-the-wire shape) for devices not yet
/// migrated onto crdt_sync, converting their entries through the same
/// adapter the local log uses. Throwing [FormatException] or [TypeError] is
/// treated as unparsable by the caller (`sync_service.dart`'s `syncLog`
/// `decode` callback), mirroring `_sync._pull_remote_logs`'s tolerance for a
/// corrupt/truncated push.
Log parseRemoteLog(String text) {
final raw = jsonDecode(text);
if (raw is! Map) {
throw const FormatException(
'top-level sync payload is not a JSON object',
);
}
final rawMap = raw.cast<String, dynamic>();
if (_looksLikeNewFormat(rawMap)) {
return rawMap.map(
(id, data) => MapEntry(id, Record.fromJson(data as Map<String, dynamic>)),
);
}
final daylog = <String, List<FoodEntry>>{};
for (final mapEntry in rawMap.entries) {
final entries = mapEntry.value;
if (entries is! List) {
throw FormatException(
'day ${mapEntry.key} is not a JSON array',
);
}
daylog[mapEntry.key] = entries
.whereType<Map<String, dynamic>>()
.map((m) => FoodEntry.fromJson(m.cast<String, dynamic>()))
.toList();
}
return dayLogToLog(daylog);
}
/// Serializes a merged [Log] for push, in the new Record-based wire format.
String encodeLogForPush(Log log) {
final encoded = <String, dynamic>{
for (final entry in log.entries) entry.key: entry.value.toJson(),
};
return jsonEncode(encoded);
}