diet-guard/app/test/services/background_sync_service_test.dart
Krzysztof kuhy Rudnicki 8905d072d0 feat: carry the catering credential to the phone
The Dart half of the credential sync: a `KuchniaCredentialService` that owns
the value locally, a `sync_merge_kuchnia.dart` adapter mirroring the Python
one, and a `_syncKuchniaCredential` tick alongside the banks and budget. The
phone can now receive the panel password, which is the prerequisite for it
fetching anything itself.

One source of truth, per the answered question: the value lives in the synced
document store and nowhere else. Deliberately *not* mirrored into
`flutter_secure_storage` -- two homes for one value is how a stale password
survives a change made on the other device, and the credential has to be
readable synchronously at merge time anyway.

Gated by a second shared fixture, `tests/fixtures/kuchnia_credential.json`,
asserted by both suites. Two cases carry the weight:

- an **unparsable** edit time must fall back to the same clock on both sides
  (Python catches `ValueError` from `fromisoformat`, Dart's `tryParse` returns
  null). Verified they agree on `wall_time_ms == 0`; mutating that expectation
  fails both suites.
- a **blank half** contributes nothing, so a half-filled settings form cannot
  push an empty-string password that wins LWW against a real one.

`KuchniaCredentialService.init()` is called in the WorkManager isolate as well
as `main()`. A fresh isolate has its own static state and `_syncKuchniaCredential`
no-ops when the singleton is missing, so without it a background tick would
neither publish this device's credential nor receive a peer's -- and on the
phone the background tick is most of the syncing there is. Same class of trap
as the `initSyncDeviceId()` one already documented there.

`.toDouble()` came off the bank record: the fields are already `double`, so it
was a no-op the analyzer flags. The field *types* are what keep the encoding
byte-identical to Python's, and `kuchnia_parity_test.dart` asserts that.

654 Dart tests, 1040 Python tests, 100% Python branch coverage.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QQpCiPaSbyRpwsLkH3dgsX
2026-08-23 08:25:27 +02:00

150 lines
5.6 KiB
Dart

// `backgroundSyncPush` is the unit-testable half of the connectivity-gated
// WorkManager backstop; the dispatcher branch and the one-off registration
// itself are integration-only (real WorkManager isolate, on-device smoke
// test) and excluded from coverage, exactly like the periodic check.
import 'dart:io';
import 'package:diet_guard_app/services/document_store_io.dart';
import 'package:diet_guard_app/services/app_settings_service.dart';
import 'package:diet_guard_app/services/budget_history_service.dart';
import 'package:diet_guard_app/services/background_sync_service.dart';
import 'package:diet_guard_app/services/foodbank_service.dart';
import 'package:diet_guard_app/services/kuchnia_credential_service.dart';
import 'package:diet_guard_app/services/log_storage_service.dart';
import 'package:diet_guard_app/services/meal_schedule_service.dart';
import 'package:diet_guard_app/services/sync_device_id.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:http/http.dart' as http;
import 'package:http/testing.dart';
import 'package:shared_preferences/shared_preferences.dart';
import '../fake_secure_storage.dart';
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
late Directory tempDir;
setUp(() async {
tempDir = await Directory.systemTemp.createTemp('diet_guard_bg_sync_');
LogStorageService.resetForTesting(store: FileDocumentStore(tempDir));
FoodBankService.resetForTesting(store: FileDocumentStore(tempDir));
// Pre-seeds the singleton so backgroundSyncPush's own AppSettingsService
// .init() call short-circuits instead of hitting the real (unmocked in
// this test) path_provider channel.
AppSettingsService.resetForTesting(store: FileDocumentStore(tempDir));
BudgetHistoryService.resetForTesting(
store: FileDocumentStore(tempDir),
);
MealScheduleService.resetForTesting(store: FileDocumentStore(tempDir));
KuchniaCredentialService.resetForTesting(
store: FileDocumentStore(tempDir),
);
});
tearDown(() async {
LogStorageService.resetForTesting();
FoodBankService.resetForTesting();
AppSettingsService.resetForTesting();
BudgetHistoryService.resetForTesting();
MealScheduleService.resetForTesting();
KuchniaCredentialService.resetForTesting();
await tempDir.delete(recursive: true);
});
test('does nothing and does not retry when sync is unconfigured', () async {
SharedPreferences.setMockInitialValues({});
installFakeSecureStorage();
var puts = 0;
final mock = MockClient((req) async {
if (req.method == 'PUT') puts++;
return http.Response('', 404);
});
final ok = await backgroundSyncPush(httpClient: mock);
expect(ok, isTrue); // nothing to do -> success, no retry
expect(puts, 0);
});
test('pushes and reports success when configured', () async {
SharedPreferences.setMockInitialValues({
'sync.owner': 'o',
'sync.repo': 'r',
});
installFakeSecureStorage(initial: {'sync.token': 't'});
var puts = 0;
final mock = MockClient((req) async {
if (req.method == 'PUT') {
puts++;
return http.Response('{}', 200); // Contents-API PUT succeeded
}
// Bare `/repos/<owner>/<repo>` GET is the repo-exists probe.
if (req.method == 'GET' && req.url.pathSegments.length == 3) {
return http.Response('{}', 200);
}
return http.Response('', 404);
});
final ok = await backgroundSyncPush(httpClient: mock);
expect(ok, isTrue);
// syncLog always pushes, even an empty merged result: food_log.json,
// budget.json, food_bank.json, food_bank_manual.json, kuchnia.json.
// Five data files plus this device's revision, which is what lets a
// later tick skip an unchanged peer.
expect(puts, 6);
});
test('pushes under the persisted uuid, not the legacy role id', () async {
// Regression guard. A WorkManager background isolate has its own static state,
// so without initSyncDeviceId() here `currentSyncDeviceId` falls back to
// the compile-time 'phone' constant and this tick writes to
// `devices/phone/`. That splits the device across two directories, and
// since sync_state holds a single `pushedRev` with no notion of which
// identity wrote it, the next *foreground* push then sees `unchanged`
// and skips writing the uuid directory at all.
const uuid = '77e39198-ff83-479b-a905-b0cd68b66094';
SharedPreferences.setMockInitialValues({
'sync.owner': 'o',
'sync.repo': 'r',
'crdt.nodeId': uuid,
});
resetSyncDeviceIdForTest();
installFakeSecureStorage(initial: {'sync.token': 't'});
final pushedPaths = <String>[];
final mock = MockClient((req) async {
if (req.method == 'PUT') {
pushedPaths.add(req.url.path);
return http.Response('{}', 200);
}
if (req.method == 'GET' && req.url.pathSegments.length == 3) {
return http.Response('{}', 200);
}
return http.Response('', 404);
});
await backgroundSyncPush(httpClient: mock);
expect(pushedPaths, isNotEmpty);
expect(pushedPaths.every((path) => path.contains(uuid)), isTrue);
expect(
pushedPaths.any((path) => path.contains('/devices/phone/')),
isFalse,
);
});
test('reports failure (retry) when the push errors', () async {
SharedPreferences.setMockInitialValues({
'sync.owner': 'o',
'sync.repo': 'r',
});
installFakeSecureStorage(initial: {'sync.token': 't'});
final mock = MockClient((_) async => http.Response('boom', 500));
final ok = await backgroundSyncPush(httpClient: mock);
expect(ok, isFalse); // transient -> WorkManager should retry
});
}