mirror of
https://github.com/kuhyx/diet-guard.git
synced 2026-11-11 13:47:38 +01:00
Krzysztof kuhy Rudnicki
e8f0ecaae1
Sixth batch of the 250-line sweep. All six gate sources named for this batch are now under cap, plus _gate_layout_probe.py, which this batch's import rewiring pulled into the changeset (over-cap count 38 -> 31). _gatelock_ui.py 477 -> 174 (palette/leaf-helper hub) _gate_layout_probe.py 346 -> 196 _gatelock_groups.py 308 -> 137 _gatelock_calendar_ui 295 -> 77 _gatelock_calendar.py 286 -> 210 _gatelock.py 263 -> 238 _gatelock_mealflow.py 259 -> 207 New siblings: _gatelock_fields (input widgets), _gatelock_layout (assembly), _gatelock_widgetgroups (per-widget mirroring), _gatelock_calendar_types (bundles/palette), _gatelock_calendar_widgets (History builders), _gatelock_dashboard and _gatelock_budgetedit (mixins), _gatelock_lockfile (the stdlib-only flock), _gate_focus_probe and _gate_measurement. The load-bearing part is the test seam, not the line counts. `_gate_fixtures._GATE_TK_MODULES` patches `tk` on a hand-listed tuple, and that list fails OPEN: a widget builder split into a new sibling that nobody adds to it builds *real* Tk widgets against fake parents. Neither existing detector sees that -- check_patch_targets.py only validates paths that still resolve, and the ~8s runtime only catches network calls. It bit twice during this split (real StringVars from make_calendar_vars returned MagicMocks instead of the asserted text), so test_gate_tk_modules.py now asserts the invariant directly: every module binding `tk` is in the patch set or named in _NO_WIDGETS with a reason. It caught a pre-existing gap too -- _gatelock_support was never in the set. Same fail-open shape drove two other choices: `escape_tab_trap` is a call-time indirection so the keyboard test's patch of `_escape_text_tab_trap` still bites, and the flock pair moved with its conftest patch target updated in the same edit (that one fails closed). build_layout is imported from _gatelock_layout directly rather than re-exported lazily, which avoids both a cycle and an import-outside-toplevel suppression. Verified: 703 Python tests / 100% branch coverage, the 5 layout-fits tests under xvfb, 555 Flutter tests (unchanged), flutter analyze clean, check_patch_targets 0, `sync` 0 (403 entries), pre-commit clean, and `gate --demo` renders both tabs with live dashboard data. ~/.local/share/diet_guard byte-identical across the batch (gate timer paused, restored after). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RA9ynjqXPnexRQnR5oAuCC
71 lines
2.4 KiB
Python
71 lines
2.4 KiB
Python
"""The result type shared by the gate's layout and focus probes.
|
|
|
|
Split out of :mod:`._gate_layout_probe` so that module and
|
|
:mod:`._gate_focus_probe` can both import it without a cycle, and so each
|
|
file stays under the repo's 250-line limit.
|
|
|
|
Test support, not a test: it lives under ``tests/`` rather than in the
|
|
package, so its diagnostic-only branches are not held to the package's
|
|
100%-coverage bar.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from dataclasses import dataclass
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class Measurement:
|
|
"""One layout measurement against one screen size."""
|
|
|
|
screen_w: int
|
|
screen_h: int
|
|
content_span: int
|
|
viewport_h: int
|
|
scrolls_by_keyboard: bool
|
|
last_widget_visible_after_focus: bool
|
|
has_scroll_viewport: bool = True
|
|
|
|
@property
|
|
def needs_scroll(self) -> bool:
|
|
"""Whether the content is taller than the viewport."""
|
|
return self.content_span > self.viewport_h
|
|
|
|
@property
|
|
def reachable(self) -> bool:
|
|
"""Whether every part of the content can be reached by keyboard.
|
|
|
|
Content that fits is trivially reachable. Content that overflows must
|
|
scroll by keyboard *and* bring a focused below-the-fold widget into
|
|
view.
|
|
|
|
Deliberately not asserted: that focusing always *moves* the view. When
|
|
the overflow is small the deepest widget is already visible, and then
|
|
holding still is the correct behaviour -- the invariant is "the focused
|
|
widget is visible", not "the viewport scrolled".
|
|
"""
|
|
if not self.needs_scroll:
|
|
return True
|
|
return self.scrolls_by_keyboard and self.last_widget_visible_after_focus
|
|
|
|
def describe(self) -> str:
|
|
"""Return a one-line human-readable summary."""
|
|
fit = (
|
|
f"needs scroll (+{self.content_span - self.viewport_h}px)"
|
|
if self.needs_scroll
|
|
else "fits"
|
|
)
|
|
verdict = "REACHABLE" if self.reachable else "UNREACHABLE CONTENT"
|
|
viewport = (
|
|
"scroll viewport present"
|
|
if self.has_scroll_viewport
|
|
else "NO SCROLL VIEWPORT -- overflow is clipped, not scrolled"
|
|
)
|
|
return (
|
|
f"{self.screen_w}x{self.screen_h}: "
|
|
f"content {self.content_span} in viewport {self.viewport_h} "
|
|
f"-> {fit}; {viewport}; keys={self.scrolls_by_keyboard} "
|
|
f"last_visible={self.last_widget_visible_after_focus} "
|
|
f"-> {verdict}"
|
|
)
|