diet-guard/app/test/models/slot_test.dart
Krzysztof kuhy Rudnicki f7f06aee53
Some checks failed
pre-commit / pre-commit (push) Has been cancelled
Tests / test (3.10) (push) Has been cancelled
Tests / test (3.11) (push) Has been cancelled
Tests / test (3.12) (push) Has been cancelled
Remove unused features; fix reminder false alarms; share all state
Four asks, plus the fixes two review passes turned up.

Removals (all unused):
- "Repeat last meal" button, and the reward/temptation-bundling prompt it
  was the sole trigger for. Replaced with a post-log progress card showing
  kcal against budget, macros, and the adherence streak.
- The multi-item meal builder, on both the gate and the phone. The stored
  `components` field stays: nothing writes it now, but historical composite
  entries and the food bank still read it and it is part of the wire format.
- Meal photos entirely: 13 files, `imagePath`, the photo filter, the
  wrapper's /blobs/ route, image_picker, and the CAMERA permission.

Reminder false alarms had three real causes, all fixed:
- Logging never reconciled notifications, so a reminder sat on screen up to
  15 minutes after the meal was logged -- on the phone itself.
- The background check never pulled, so a PC-logged meal nagged forever
  until the app was opened. Now mirrors _cli_gate._should_lock: cheap local
  check, network only when a slot looks due, then re-check.
- Meals before 08:00 / after 22:00 were attributed to no slot at all. New
  slot_for_log/slotForLog clamps them to the first/last slot, byte-identical
  across Python and Dart. Deliberately separate from elapsed_slots, which
  would otherwise make every slot fall due at 23:00.

Budget history, so lowering the budget stops rewriting the past:
- Forward-only (effective_from, kcal) entries; each day is judged against
  the budget in force then. Verified live: setting 2000 left a 36-day
  adherence streak and the whole calendar pixel-identical.
- Rides as hist:<date> fields on the existing budget record. crdt_sync
  merges per-field over the union of field names and both devices push the
  merged log, so a device that predates the feature relays them untouched --
  no coordinated rollout, no second document.
- The seed guard tests emptiness, not file presence: _sync can write an
  empty history after merging with a pre-feature peer, and a presence check
  would then never seed again, silently reclassifying every past day.

One shared source of truth for every piece of data:
- Body weight now travels as its own `weight` CRDT field. Inside `value` it
  was collateral damage of whole-map LWW -- any phone budget edit deleted it,
  and the protein target with it.
- Both halves of the food bank sync. The curated half (foods added without
  eating them) was the last device-local state. The derived half merges with
  count as the clock, so LWW means max-count-wins; the log stays
  authoritative for membership, because a CRDT union never shrinks and a
  peer's stale copy would otherwise resurrect a deleted food permanently.
- Bank adapters honour tombstones, and Dart parses bank records defensively:
  a cast failure there is an Error, not an Exception, so one malformed
  remote record would have broken phone sync permanently.

_test_guard.py blocks any pathlib write to real user state while pytest is
in the process, whatever conftest is loaded. A throwaway test run outside
the package conftest destroyed a real GitHub token during this work; this
makes that class of accident impossible rather than merely discouraged.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-26 16:39:52 +02:00

129 lines
3.6 KiB
Dart

import 'package:diet_guard_app/models/slot.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
group('daySlots', () {
test('returns the four fixed hourly slots', () {
expect(daySlots(), [8, 12, 16, 20]);
});
});
group('withinEnforcementWindow', () {
test('false before the day start hour', () {
expect(withinEnforcementWindow(DateTime(2026, 6, 22, 7, 59)), isFalse);
});
test('true at the day start hour', () {
expect(withinEnforcementWindow(DateTime(2026, 6, 22, 8, 0)), isTrue);
});
test('true just before the eating end hour', () {
expect(withinEnforcementWindow(DateTime(2026, 6, 22, 21, 59)), isTrue);
});
test('false at the eating end hour (exclusive)', () {
expect(withinEnforcementWindow(DateTime(2026, 6, 22, 22, 0)), isFalse);
});
});
group('elapsedSlots', () {
test('empty outside the enforcement window', () {
expect(elapsedSlots(DateTime(2026, 6, 22, 23, 0)), isEmpty);
});
test('only the 8 slot right at day start', () {
expect(elapsedSlots(DateTime(2026, 6, 22, 8, 0)), [8]);
});
test('8 and 12 mid-afternoon before 16', () {
expect(elapsedSlots(DateTime(2026, 6, 22, 15, 59)), [8, 12]);
});
test('all four slots once 20:00 has passed', () {
expect(elapsedSlots(DateTime(2026, 6, 22, 21, 0)), [8, 12, 16, 20]);
});
});
group('missingSlots', () {
test('excludes already-logged elapsed slots', () {
expect(
missingSlots(DateTime(2026, 6, 22, 17, 0), {8}),
[12, 16],
);
});
test('empty once every elapsed slot is logged', () {
expect(
missingSlots(DateTime(2026, 6, 22, 17, 0), {8, 12, 16}),
isEmpty,
);
});
});
group('currentSlot', () {
test('null outside the enforcement window', () {
expect(currentSlot(DateTime(2026, 6, 22, 6, 0)), isNull);
});
test('returns the most recently elapsed slot', () {
expect(currentSlot(DateTime(2026, 6, 22, 17, 41)), 16);
});
test('returns 8 right at day start', () {
expect(currentSlot(DateTime(2026, 6, 22, 8, 0)), 8);
});
});
group('slotForLog', () {
// Keep in lockstep with `diet_guard/tests/test_slots.py`'s
// TestSlotForLog: a divergence means the PC and the phone disagree about
// which checkpoint a meal satisfied.
DateTime at(int hour) => DateTime(2026, 6, 22, hour, 0);
test('clamps to the first slot before the window opens', () {
expect(slotForLog(at(7)), 8);
});
test('clamps to the first slot in the small hours', () {
expect(slotForLog(at(0)), 8);
});
test('is unchanged exactly at the first slot', () {
expect(slotForLog(at(8)), 8);
});
test('matches currentSlot inside the window', () {
expect(slotForLog(at(13)), currentSlot(at(13)));
expect(slotForLog(at(13)), 12);
});
test('is unchanged at the last in-window hour', () {
expect(slotForLog(at(21)), 20);
});
test('clamps to the last slot once the window closes', () {
expect(slotForLog(at(22)), 20);
});
test('clamps to the last slot late in the evening', () {
expect(slotForLog(at(23)), 20);
});
test('never returns a slot outside the schedule', () {
for (var hour = 0; hour < 24; hour++) {
expect(daySlots(), contains(slotForLog(at(hour))));
}
});
});
group('slotLabel', () {
test('pads single-digit hours', () {
expect(slotLabel(8), '08:00');
});
test('formats double-digit hours', () {
expect(slotLabel(20), '20:00');
});
});
}