mirror of
https://github.com/kuhyx/diet-guard.git
synced 2026-11-20 10:12:28 +01:00
The chip was the only control that logged a meal against no slot at all (`slot: null`). Removing it leaves the row with just the four hour chips, so every logged meal now satisfies a real slot. Storage keeps its null-slot support on purpose. Entries already on disk and arriving over sync carry no `slot` key, and the `slot != null` filters in log_storage_service.loggedSlotsToday / _state.logged_slots_today are what stop them from retroactively satisfying meal slots -- so both are documented as load-bearing rather than deleted as dead code. Also corrects the MCP tool's docstring, which claimed its slot argument "may be None early in the day"; it falls back to slot_for_log, which clamps to a real hour and never returns None. Adds the widget test the chip row never had -- being untested is why the chip read as unused. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MPheLM86xUN9TGf34Ygtfz
91 lines
3.4 KiB
Dart
91 lines
3.4 KiB
Dart
/// A single row that both shows today's slot status (logged/due/upcoming)
|
|
/// and lets the user pick which slot they're logging for, replacing what
|
|
/// used to be three separate stacked elements.
|
|
library;
|
|
|
|
import 'package:diet_guard_app/models/slot.dart';
|
|
import 'package:diet_guard_app/ui/theme.dart';
|
|
import 'package:flutter/material.dart';
|
|
|
|
/// One row of [ChoiceChip]s, one per today's slot hour. Each chip is
|
|
/// simultaneously selectable (tap to log for that slot) and status-colored
|
|
/// (green+check = logged, red = due, grey = upcoming), so no separate status
|
|
/// bar or caption text is needed.
|
|
///
|
|
/// There used to be a fifth "Snack" chip that selected no slot at all,
|
|
/// removed 2026-08-14. Entries with a null slot still exist in storage and
|
|
/// still arrive over sync, so the nullable types below are deliberate -- but
|
|
/// this widget no longer produces one.
|
|
class SlotSelectorRow extends StatelessWidget {
|
|
/// Creates a [SlotSelectorRow].
|
|
const SlotSelectorRow({
|
|
required this.now,
|
|
required this.loggedSlots,
|
|
required this.selectedSlot,
|
|
required this.onSlotSelected,
|
|
super.key,
|
|
});
|
|
|
|
/// Reference time used to decide which slots are due.
|
|
final DateTime now;
|
|
|
|
/// Slot hours already satisfied by today's log.
|
|
final Set<int> loggedSlots;
|
|
|
|
/// The slot currently chosen to log for. Nullable for historical reasons
|
|
/// (see the class doc); no chip in this row selects null any more.
|
|
final int? selectedSlot;
|
|
|
|
/// Called with the tapped slot's hour. Never called with null.
|
|
final ValueChanged<int?> onSlotSelected;
|
|
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
final scheme = Theme.of(context).colorScheme;
|
|
// A `!` here would crash in any context that doesn't build its theme
|
|
// from buildAppTheme() -- most widget tests just wrap in a bare
|
|
// MaterialApp(home: ...). Falling back to the app's own dark instance
|
|
// matches production exactly when the extension is genuinely absent.
|
|
final statusColors =
|
|
Theme.of(context).extension<AppStatusColors>() ?? AppStatusColors.dark;
|
|
final elapsed = elapsedSlots(now).toSet();
|
|
return Wrap(
|
|
spacing: AppSpacing.xs + 2,
|
|
runSpacing: AppSpacing.xs,
|
|
children: [
|
|
...daySlots().map((slot) {
|
|
final isLogged = loggedSlots.contains(slot);
|
|
final isDue = !isLogged && elapsed.contains(slot);
|
|
final color = isLogged
|
|
? statusColors.success
|
|
: isDue
|
|
? scheme.error
|
|
: scheme.onSurfaceVariant;
|
|
final isSelected = selectedSlot == slot;
|
|
return ChoiceChip(
|
|
label: Text(slotLabel(slot)),
|
|
selected: isSelected,
|
|
// Icon reads lighter than the label text (rule 28): reduced
|
|
// opacity instead of the label's full-strength color.
|
|
avatar: isLogged
|
|
? Icon(
|
|
Icons.check,
|
|
size: 14,
|
|
color: color.withValues(alpha: 0.72),
|
|
)
|
|
: null,
|
|
backgroundColor: color.withValues(alpha: 0.15),
|
|
selectedColor: color.withValues(alpha: 0.35),
|
|
labelStyle: TextStyle(color: color),
|
|
side: BorderSide(
|
|
width: isSelected ? 2 : 1,
|
|
color: isSelected ? color : color.withValues(alpha: 0.4),
|
|
),
|
|
onSelected: (_) => onSlotSelected(slot),
|
|
);
|
|
}),
|
|
],
|
|
);
|
|
}
|
|
}
|