mirror of
https://github.com/kuhyx/diet-guard.git
synced 2026-11-11 20:53:53 +01:00
_sync.py 498 -> 165, into siblings that each own one concern:
_sync_client.py picking a backend and building the remote store
_sync_banks.py pull/merge/push for the food bank and the budget
_sync_paths.py the kuhyx/syncs wire layout, shared by both
_sync_errors.py SyncError, so _sync and _sync_client need not import
each other
The patch targets moved with the code they guard, which is the whole risk of
this commit. unittest.mock.patch and monkeypatch.setattr both bind to a
*module object*, so a patch left pointing at _sync after CONFIG_FILE and
SYNC_TOKEN_FILE moved to _sync_client redirects nothing. That is not
hypothetical here: the first run of the suite took 9m18s instead of 7s and
raised 401s, because tests were reaching the real GitHub API with a fake
token. Repointed:
conftest SYNC_TOKEN_FILE, CONFIG_FILE -> _sync_client
test_sync* GitHubSyncClient (30 patch sites) -> _sync_client
test_backend mirror/firebase_client_for -> _sync_client
The repo's own _test_guard caught the same leak independently, which is the
behaviour worth keeping: two guards, both fail-closed.
test_sync.py 482 -> 205, splitting the budget and pull/revision classes into
siblings and the shared fakes into _sync_fakes.py.
conftest.py 284 -> 155, moving the Tk/gatelock fixtures to _gate_fixtures.py.
Importing them back is what registers them (pytest_plugins is an error in a
non-root conftest), and they are named in __all__ because ruff's autofix
otherwise deletes the "unused" import and silently disables Tk blocking --
it did exactly that once here. Verified afterwards with a canary asserting
_gatelock.tk is still a MagicMock, not merely that the suite passes.
Verified: 692 tests / 100% coverage unchanged; ~/.local/share/diet_guard
byte-identical before and after the run; cd /tmp && python3 -m diet_guard sync
-> 402 entries, exit 0. Gate 47 -> 44.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MK3HCZrM75sRHL1gL8usve
128 lines
4.8 KiB
Python
128 lines
4.8 KiB
Python
"""Tests for which backend a sync tick runs against.
|
|
|
|
Split out of ``test_sync.py`` to keep both files under the repo's 500-line
|
|
cap. Covers the Firebase/GitHub cutover seam (``_remote_client``) and which
|
|
credentials a run actually requires (``_client_for_run``).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
from crdt_sync import ConfigError
|
|
import pytest
|
|
|
|
from diet_guard import _sync, _sync_client
|
|
|
|
|
|
class TestRemoteClient:
|
|
"""Which backend a sync tick runs against during the cutover."""
|
|
|
|
def test_stays_on_github_without_firebase_config(
|
|
self, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""An unconfigured machine must not reach the network at all."""
|
|
monkeypatch.setattr(
|
|
_sync_client, "CONFIG_FILE", Path("/nonexistent/firebase.json")
|
|
)
|
|
github = object()
|
|
|
|
assert _sync_client._remote_client(github) is github
|
|
|
|
def test_mirrors_to_github_when_configured(
|
|
self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""Configured: Firebase is primary, GitHub keeps receiving writes."""
|
|
config = tmp_path / "firebase.json"
|
|
config.write_text("{}", encoding="utf-8")
|
|
monkeypatch.setattr(_sync_client, "CONFIG_FILE", config)
|
|
monkeypatch.setattr(
|
|
_sync_client, "mirror_client_for", lambda _app, client: ("mirror", client)
|
|
)
|
|
github = object()
|
|
|
|
assert _sync_client._remote_client(github) == ("mirror", github)
|
|
|
|
def test_falls_back_when_firebase_is_unusable(
|
|
self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""A broken Firebase must degrade to GitHub, never fail the tick."""
|
|
config = tmp_path / "firebase.json"
|
|
config.write_text("{}", encoding="utf-8")
|
|
monkeypatch.setattr(_sync_client, "CONFIG_FILE", config)
|
|
|
|
def _boom(*_args: object, **_kwargs: object) -> None:
|
|
message = "no password"
|
|
raise ConfigError(message)
|
|
|
|
monkeypatch.setattr(_sync_client, "mirror_client_for", _boom)
|
|
github = object()
|
|
|
|
assert _sync_client._remote_client(github) is github
|
|
|
|
|
|
class TestClientForRun:
|
|
"""Which credentials a run actually requires."""
|
|
|
|
def test_syncs_without_a_pat_when_firebase_is_configured(
|
|
self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""A Firebase-only machine must sync, not fail for a missing PAT.
|
|
|
|
Requiring the token before ever constructing Firebase left the Python
|
|
half unable to sync at all on a device that had moved to Firebase --
|
|
the "Firebase-only device" fix had only ever touched the Dart side.
|
|
"""
|
|
config = tmp_path / "firebase.json"
|
|
config.write_text("{}", encoding="utf-8")
|
|
monkeypatch.setattr(_sync_client, "CONFIG_FILE", config)
|
|
monkeypatch.setattr(
|
|
_sync_client, "SYNC_TOKEN_FILE", tmp_path / "absent_sync_token"
|
|
)
|
|
monkeypatch.setattr(
|
|
_sync_client, "firebase_client_for", lambda app: ("firebase", app)
|
|
)
|
|
|
|
assert _sync_client._client_for_run() == ("firebase", "diet_guard")
|
|
|
|
def test_unusable_firebase_config_becomes_a_sync_error(
|
|
self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""An unusable Firebase config must fail *closed*, not raise.
|
|
|
|
``ConfigError`` subclasses ``Exception`` directly, not
|
|
``RemoteSyncError``, so letting it out of here escapes every caller's
|
|
catch tuple and raises a traceback out of the gate's fail-closed
|
|
"Fetch from sync" button -- reintroducing, by a different exception,
|
|
exactly the failure the ``RemoteSyncError`` swap was made to stop.
|
|
This branch is reached precisely when the config file exists but is
|
|
unusable and no PAT is present.
|
|
"""
|
|
config = tmp_path / "firebase.json"
|
|
config.write_text("{}", encoding="utf-8")
|
|
monkeypatch.setattr(_sync_client, "CONFIG_FILE", config)
|
|
monkeypatch.setattr(_sync_client, "SYNC_TOKEN_FILE", tmp_path / "absent_token")
|
|
|
|
def _boom(*_args: object, **_kwargs: object) -> None:
|
|
message = "no password"
|
|
raise ConfigError(message)
|
|
|
|
monkeypatch.setattr(_sync_client, "firebase_client_for", _boom)
|
|
|
|
with pytest.raises(_sync.SyncError):
|
|
_sync_client._client_for_run()
|
|
|
|
def test_still_fails_when_neither_backend_is_configured(
|
|
self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""No PAT *and* no Firebase is the genuine "nothing is set up" case."""
|
|
monkeypatch.setattr(
|
|
_sync_client, "CONFIG_FILE", tmp_path / "absent_firebase.json"
|
|
)
|
|
monkeypatch.setattr(
|
|
_sync_client, "SYNC_TOKEN_FILE", tmp_path / "absent_sync_token"
|
|
)
|
|
|
|
with pytest.raises(_sync.SyncError):
|
|
_sync_client._client_for_run()
|