mirror of
https://github.com/kuhyx/diet-guard.git
synced 2026-11-20 17:32:25 +01:00
Some checks failed
Meals logged on the phone stopped reaching the PC, so the gate kept locking for slots that were already logged and the only way through was to spam "nothing". The PC's fetch was never broken: it was faithfully pulling a Firebase that did not contain the phone's meals. The phone had no working publish backstop on either transport: - `checkAndNotify` gated its sync on `due.isNotEmpty`. Logging every meal promptly means nothing is ever due, so the ~15-min periodic task never published. It was a notification job that happened to sync, not a sync timer. It now syncs on every tick it is asked to, then computes due slots from the merged result, so a meal pulled from another device suppresses a nag instead of triggering one. - `backgroundSyncPush` never called `initSyncDeviceId()`. A fresh isolate has its own static state, so `currentSyncDeviceId` fell back to the compile-time 'phone' constant and published to `devices/phone/` rather than the persisted uuid -- which then makes the next foreground push see `unchanged` and skip writing the uuid directory entirely. Separately, on the "Fetch from sync" path itself: `FirebaseSyncError` and `FirebaseAuthError` are siblings of `GitHubSyncError` under `RemoteSyncError`, not subclasses, so every per-request failure of the *primary* backend escaped `pull_shared_log`'s catch tuple and raised a traceback out of a helper documented to fail closed with a reason string. `ConfigError` needed the same treatment by a different route: it subclasses `Exception` directly, so it is outside `RemoteSyncError` too, and is now translated at `_client_for_run`. The PAT is no longer mandatory either. Firebase is primary, but `_read_token` ran before the client was ever built, so a Firebase-only machine could not sync at all -- the commits that fixed this touched only the Dart side. A stalled sync was invisible: the config gates returned silently and `openFirebase` swallowed every error. `dart:developer`'s `log()` does not reach logcat on a release build (verified on device), so logging alone would not have surfaced it. `SyncHealth` records each tick's outcome and the log screen shows a banner when publishing has actually stopped. Also make the real-Tk probes bypass the window manager. A tiling WM retiles a managed toplevel instead of honouring the requested geometry, so `winfo_height` reported 0/1px and the layout and focus-ring assertions failed on noise rather than on any regression -- 8 failures on the dev machine that only passed under Xvfb. `overrideredirect` makes the measurement deterministic with or without a WM; the probes still detect a genuine overflow at 1366x300. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RT8X32S9yDLW1Xf1PDq8z7
58 lines
2.2 KiB
Dart
58 lines
2.2 KiB
Dart
/// The "not syncing" banner for the log screen.
|
|
library;
|
|
|
|
import 'package:diet_guard_app/services/sync_health.dart';
|
|
import 'package:diet_guard_app/ui/theme.dart';
|
|
import 'package:flutter/material.dart';
|
|
|
|
/// Warns, in place, that meals logged here are not reaching other devices.
|
|
///
|
|
/// Renders nothing at all unless [SyncHealthStatus.isStalled], so a healthy
|
|
/// device never pays for it. This is deliberately on the log screen rather
|
|
/// than buried in Settings: the whole failure mode being guarded against is
|
|
/// one that stayed invisible while the user kept logging meals that went
|
|
/// nowhere.
|
|
class SyncHealthBanner extends StatelessWidget {
|
|
/// Creates a [SyncHealthBanner] for [status].
|
|
const SyncHealthBanner({required this.status, super.key});
|
|
|
|
/// The health to render, or null before the first read.
|
|
final SyncHealthStatus? status;
|
|
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
final message = status?.message;
|
|
if (message == null) return const SizedBox.shrink();
|
|
final theme = Theme.of(context);
|
|
// Null-safe lookup, matching slot_selector_row/day_status_calendar: a
|
|
// widget test that pumps a bare MaterialApp has no theme extension, and
|
|
// `!` there is a crash rather than a missing colour.
|
|
final warning =
|
|
(theme.extension<AppStatusColors>() ?? AppStatusColors.dark).warning;
|
|
return Container(
|
|
margin: const EdgeInsets.only(bottom: 12),
|
|
padding: const EdgeInsets.symmetric(horizontal: 12, vertical: 8),
|
|
decoration: BoxDecoration(
|
|
// A tinted fill plus a border, no shadow: the unified design system
|
|
// allows only one depth technique per surface, and shadows are out
|
|
// entirely in dark UI.
|
|
color: warning.withValues(alpha: 0.12),
|
|
border: Border.all(color: warning.withValues(alpha: 0.5)),
|
|
borderRadius: BorderRadius.circular(8),
|
|
),
|
|
child: Row(
|
|
children: [
|
|
Icon(Icons.cloud_off, size: 18, color: warning),
|
|
const SizedBox(width: 8),
|
|
Expanded(
|
|
child: Text(
|
|
message,
|
|
style: theme.textTheme.bodySmall?.copyWith(color: warning),
|
|
),
|
|
),
|
|
],
|
|
),
|
|
);
|
|
}
|
|
}
|