diet-guard/app/test/services/kuchnia_orders_test.dart
Krzysztof kuhy Rudnicki 3d82ddefd4 feat: let the phone fetch and bank the catering delivery itself
The phone now walks the panel on its own -- login, active order, delivery,
menu -- parses the dishes and banks them, so the feature works with the PC
switched off. Read-only: nothing here logs a meal.

`package:http` has no cookie jar, so the `SESSION` cookie is read off the login
response and replayed by hand. `Response.headers` folds duplicate `set-cookie`
values into one comma-joined string, so the parser splits on both `,` and `;`
and looks for the named cookie rather than assuming the header holds only it --
tested against both orderings and against a panel that sets no session cookie
at all.

Android-only, as decided: the panel sends no CORS headers, so a browser cannot
call it. `refreshDelivery` checks `kIsWeb` first and returns the unsupported
reason without touching the network. No `dart:io` anywhere -- `package:http`
compiles for web, it is the panel that refuses, not the toolchain, so this
needs no `_io`/`_web` seam.

The idempotency guard is ported with its teeth: `addManualEntry` restamps
`editedAt` unconditionally, so re-banking an unchanged dish republishes the
whole curated bank to every peer. `bankDishes` compares the nutritional fields
first and returns a write *count*, which is what the tests assert on -- "the
entry exists" passes while this misbehaves. The comparison is numeric, not
string, so `270 == 270.0` is a match exactly as in Python's `_matches`.

Every failure becomes a reason string, never a throw, so a catering outage
cannot break the caller: a rejected login, a delivery whose dishes all fail
the unit check, and missing credentials each have a test.

One test bug worth noting: the assertion that nothing is logged was missing an
`await` and so was comparing a Future against `isEmpty` -- the single most
important guarantee in this file was passing vacuously until the split forced
it to run.

Test files split three ways for the 250-line cap; block counts checked against
the pre-split file (16 either side), not just a green suite.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QQpCiPaSbyRpwsLkH3dgsX
2026-08-23 08:30:21 +02:00

65 lines
2.3 KiB
Dart

/// The catering walk's pure helpers: order/delivery selection and the cookie.
///
/// Split out of `kuchnia_import_test.dart` for the repo's 250-line cap. These
/// need no store, no credentials and no HTTP plumbing -- they are the parts of
/// the walk that are just parsing, and each one encodes a trap recovered from
/// the live panel rather than guessed from its JavaScript.
library;
import 'package:diet_guard_app/services/kuchnia_client.dart';
import 'package:diet_guard_app/services/kuchnia_orders.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
group('the order walk', () {
test('skips a cancelled delivery', () {
// A `deleted` delivery still appears in the list.
final order = {
'deliveries': [
{'date': '2026-08-23', 'deliveryId': 'GONE', 'deleted': true},
{'date': '2026-08-23', 'deliveryId': 'REAL'},
],
};
expect(deliveryIdFor(order, '2026-08-23'), 'REAL');
});
test('a malformed order yields no delivery', () {
expect(deliveryIdFor('nope', '2026-08-23'), isNull);
expect(deliveryIdFor({'deliveries': 'nope'}, '2026-08-23'), isNull);
expect(deliveryIdFor({}, '2026-08-23'), isNull);
});
test('a malformed active-ids payload yields no order', () {
expect(activeOrderId('nope'), isNull);
expect(activeOrderId(<Object>[]), isNull);
expect(activeOrderId(['ORD1']), 'ORD1');
});
test('formats the day the way the panel keys deliveries', () {
expect(isoDay(DateTime(2026, 8, 3)), '2026-08-03');
expect(isoDay(DateTime(2026, 12, 31)), '2026-12-31');
});
});
group('the session cookie', () {
test('is read out of a comma-joined set-cookie header', () {
// `Response.headers` folds duplicate set-cookie values into one string.
expect(
sessionCookieFrom('SESSION=abc123; Path=/, OTHER=def; Path=/'),
'abc123',
);
expect(
sessionCookieFrom('OTHER=def; Path=/, SESSION=abc123; HttpOnly'),
'abc123',
);
});
test('is null when the panel sets no session cookie', () {
expect(sessionCookieFrom(null), isNull);
expect(sessionCookieFrom(''), isNull);
expect(sessionCookieFrom('OTHER=def; Path=/'), isNull);
expect(sessionCookieFrom('SESSION=; Path=/'), isNull);
});
});
}