From d35097f4616552e1efa637e101df97d7910a7066 Mon Sep 17 00:00:00 2001 From: Krzysztof kuhy Rudnicki Date: Sun, 30 Aug 2026 15:32:51 +0200 Subject: [PATCH] Give CI the node packages its web hooks have always needed The pre-commit workflow has been red since 8f91158 added the status UI: it installs Python and Flutter deps but never node ones, so `tsc --build` could not find the 'vite/client' and 'node' type libraries and failed TS2688 on every run. Nothing was wrong with the code; the job simply could not build it. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01BJUtseRczWVBJW8LvL1aQH --- .github/workflows/pre-commit.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index b781544..97ca813 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -34,6 +34,19 @@ jobs: flutter-version: 3.47.2 channel: stable cache: true + # The web-lint / web-typecheck / web-coverage hooks run npm inside web/. + # Without its installed packages `tsc --build` cannot find the + # 'vite/client' and 'node' type libraries and fails with TS2688 -- which + # is what this workflow had been doing on every run since the status UI + # landed in 8f91158. + - uses: actions/setup-node@v4 + with: + node-version: "24.20.0" + cache: npm + cache-dependency-path: web/package-lock.json + - name: Install status-UI packages + run: npm ci + working-directory: web - name: Install dependencies run: pip install -r requirements.txt # analyze needs resolved packages (.dart_tool); the hook runs analyze