3 Commits

Author	SHA1	Message	Date
Krzysztof kuhy Rudnicki	76a4c6a0a7	Finish the Python side: scripts, conftest, and the last test modules ... verify_lock_popup_safety.py (318) -> _xvfb_reexec.py shared re-exec _popup_form_check.py HostileLock, ticks, the real-form check verify_screen_fits.py (266) -> uses _xvfb_reexec too conftest.py (329) -> _tk_mocks.py the tk mock + the module patch list _opt_in_fixtures.py requestable fixtures three test modules -> _part4/_part5/_part15 siblings conftest keeps every autouse fixture. pytest applies autouse fixtures from conftest only, so one moved to a sibling would silently stop running and take its safety guard with it -- verified by asserting the fixtures are still listed, not just that the suite is green. The five near-identical _isolate_* fixtures collapse into one table-driven _isolate_state_files, which also picks up the _shutdown_sick_state binding an earlier split created. scripts/ becomes a real package so the shared helpers are importable. Both gates now run as `python3 -m scripts.<name>`, including CI -- the path form put scripts/ on sys.path instead of the repo root, and the alternative was a try/except ImportError that this repo's no-silent-failures hook rightly rejects. Each gate was run in its exact invocation form. Note: verify_lock_popup_safety still fails on `RecoveryLoop.__init__() takes 3 positional arguments but 6 were given`. That is pre-existing -- confirmed by running it at HEAD in a clean worktree before touching it -- a gatelock API drift, not this refactor. Left as found. 978 tests at 100% branch coverage. Gate: 41 -> 22 files, all remaining ones Dart plus DESIGN_AUDIT_TODO.md. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EveB813BQ8abAP68VSqZ5Y	2026-08-15 20:57:29 +02:00
Krzysztof kuhy Rudnicki	c11e27f123	Pin gatelock 0.2.1, and stop the popup check passing when it cannot run ... The lock-popup-safety job failed on its first CI run for two reasons, and only one of them was the obvious one. The obvious one: the script imports screen_locker directly rather than through pytest, which would have put the rootdir on sys.path for it. CI now installs the package. The one worth having found: CI installs gatelock from the pinned tag, which predated `holds_grab`, so every hostile tick died on an AttributeError -- inside a Tk `after` callback, where exceptions are swallowed and logged rather than raised. The harness sailed past, printed OK and exited 0 while doing no grab re-assertion whatsoever. A verification script that passes when it is broken is worse than not having it. So it now fails closed twice over: an explicit check that the installed gatelock has the predicate at all, with a message naming the fix, and a count of ticks that actually completed -- incremented after the work, so a raising tick does not count. Fewer completed ticks than asked for is reported as "the harness itself is broken, so this result proves nothing", not as a pass. The pin moves to gatelock-v0.2.1, which carries both of yesterday's fixes: the grab predicate that no longer steals the grab off our own posted menus, and the recovery loop that no longer stops forever when a tick raises. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-07-26 15:18:04 +02:00
Krzysztof kuhy Rudnicki	c0aae7d05b	Make the lock overlay's sport selector usable, and focus its form fields ... The manual-workout sport selector was a `tk.OptionMenu`, and while the screen was locked it could not be changed. A posted Tk menu is a separate override-redirect toplevel that takes the Tk grab for itself, and gatelock's 1s recovery tick attacks it from both sides: `_surfaces.enforce()` lifts the lock surface over the menu, and `_reassert_grab()` read the grab sitting on the menu as "the grab was lost" and yanked it back. The menu opened on click and died within a second. On 2026-07-26 that forced an hour-long walk to be logged through the table-tennis form, with the reason typed into `racket`. Radio buttons instead. They are ordinary children of the surface, so they lift with it and live inside the root's grab tree -- neither mechanism can reach them. That is a structural guarantee, not a tuned workaround; the alternative, teaching gatelock to skip its lift while a popup is posted, would open a window where something could cover the lock. They are also the first version of this control styled from the shared palette, where the OptionMenu was default grey on the dark overlay. Nothing on a lock surface may open a popup, so two halves enforce it. The static half walks each module's AST for popup-creating names -- AST rather than a source regex because the modules explain this bug in prose that names the very widgets being banned. Its module list is derived ("imports tkinter", minus a short reasoned exemption list) rather than hardcoded, so a new lock screen is in scope the day it is written; a hardcoded list drafted today would already have missed `_sick_dialog`. The behavioural half is `scripts/verify_lock_popup_safety.py`: it builds the real form with real Tk, replays both hostile behaviours for five ticks, and re-runs the original failure so the mechanism stays demonstrated rather than described. It re-execs itself under Xvfb -- a global grab on the developer's own session would freeze it -- and a CI job runs it, because the pytest suite replaces the whole `tk` module and so cannot host it. Separately, no field ever took keyboard focus. Under a global grab that means typing goes nowhere with no other window on screen to reveal why. The manual-workout and sick-justification forms now each name their own first field via a `focus=` flag; `on_focus_ready` genuinely has nothing to focus (it fires before those screens exist) and its docstring now says that instead of claiming the lock window has no typed input at all. `scripts/fix_2026_07_26_sport.py` re-files that walk as sport "other", rebuilt through the form's own draft/validate/build path so it carries exactly the writer's key set, and re-signed. `start_time` and the date are untouched so `workout_id` stays stable and the phone converges instead of gaining a duplicate. Kept as the audit trail for the edit; the walk's details come from the entry and `--details`, so nothing personal lands in a tracked file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-07-26 15:08:08 +02:00