6 Commits

Author	SHA1	Message	Date
Krzysztof kuhy Rudnicki	f5c6c2fb9d	Split _manual_workout_dialog.py and _manual_workout.py ... _manual_workout_dialog.py (357) -> _manual_workout_sport_fields.py ManualWorkoutSportFieldsMixin (+ _mw_scrollable_form moved into the existing widgets mixin, where the generic scaffold belongs) _manual_workout.py (355) -> _manual_workout_types.py: the sport constants, ManualWorkoutDraft, and the rolling budget accounting A painting mixin cannot simply move: conftest's mock_tk fixture patches `tk` per-module through the _TK_MODULES list, so the new module had to be registered there or its tkinter calls reach a real display. That is what the two dialog tests caught. Test count 976 -> 977: _manual_workout_sport_fields is a new lock-surface module, so test_no_popup_widgets now safety-checks it too. Coverage stays 100%, pylint holds at 8.70/10, `screen_lock --status` unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EveB813BQ8abAP68VSqZ5Y	2026-08-15 20:16:33 +02:00
Krzysztof Rudnicki	a79c4fdd05	Stop the lock screen scrolling itself, and make every screen fit 768px ... This morning the lock screen scrolled to the bottom and back with nobody touching the keyboard, on the 1366x768 panel. Reproduced under Xvfb with the real app: one programmatic focus_set() produced three scrolls, frac 0.000 -> 0.436 -> 0.145. The cause is in gatelock (fixed in v0.4.0, pinned here): the viewport followed every <FocusIn>, and this app focuses a widget on every repaint. It now follows only focus the *user* moved, and a screen that fits cannot scroll at all. The other half is this app's own layout, because scrolling was covering for screens that did not fit. The manual-workout form needed 1643px of a 768px screen -- SUBMIT and BACK were simply off the bottom: * Every font size and pad now goes through the design-system tokens rather than a literal. A positive size means *points* to Tk, so "36" rendered ~37% larger than the 36px intended; that alone was most of the overflow, on all 88 call sites. * The form's cells put their label beside the field instead of above it, and the three reflection boxes share rows instead of taking one each. Result, measured by the new scripts/verify_screen_fits.py (a pre-commit hook now, so this cannot come back quietly): the form is 752px of 768px, and every other screen -- including heat-skip, which had no viewport at all -- fits with room to spare. Also fixed, all found by measuring rather than by reading: content that fits is centred again (the reset-to-top was cancelling it on every repaint), the scrollbar only appears when there is something to scroll, and unlock_screen moved to _unlock_view so screen_lock.py stays under the 400-line cap. Tests: 896 pass. The focus/scroll helpers shipped in 3e77f4e had no coverage at all; test_focus_and_scroll.py covers them now. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BsXnTHyuuCUZsqetTaajcF	2026-08-03 15:57:48 +02:00
Krzysztof Rudnicki	3e77f4e232	Make every lock screen keyboard-operable, and add the missing installer ... The locker was not running at all. workout-locker.service crash-looped ~1977 times in a single boot with ModuleNotFoundError while remaining `enabled`, and has no successful start in the retained journal. A locker that cannot start is a locker that does not lock. Root cause: commit 9b420a9 removed the unit's WorkingDirectory and PYTHONPATH=/opt/screen-locker on the (correct in principle) grounds that "screen_locker is now pip-installed" -- but nothing guaranteed that install. There was no installer, /opt/screen-locker no longer exists, and the package was absent from every Python version's user site-packages. The unit lost its fallback and gained a hard dependency on a manual step nobody re-ran. install.sh fixes that as a script rather than a reminder, and *gates*: it fails if the production interpreter cannot import screen_locker, because an installer that reports success while the service still cannot start is precisely the failure above. It also re-asserts an editable gatelock from ~/utils AFTER the package install and verifies it resolves there -- pyproject pins gatelock to a git tag, so a plain install silently replaces a local editable gatelock with a frozen wheel, which was observed removing ScrollableSurface and taking diet_guard down with it. The keyboard work, all of it Tk defaults rather than local mistakes: - Focus was invisible. Tk ships highlightcolor="#000000" -- a black ring on #211D1B -- and relief="flat" removes the depth cue too, so a keyboard user had no indication of where they were. Now set in the _ui_widgets factory, so a new call site cannot omit it. - Enter did nothing. X11 Tk binds <space> on Button and never <Return>. - tk.Text trapped Tab (inserts a literal tab, refocuses itself) and no-opped Shift-Tab; the only exits are the undocumented Ctrl+Tab / Ctrl+Shift+Tab. - The lock and retry screens started with NOTHING focused. on_focus_ready was a documented no-op arguing "buttons only, nothing to focus" -- exactly backwards: buttons are what needs focusing when there is no other window on screen and a global grab is held. - The heat-skip modal grabbed input fullscreen with no focus, no ring, no Return and no Escape. It now focuses the *declining* option, so a blind Return keeps the workout rather than silently skipping it. The manual-workout form's scroll viewport was pointer-only in three ways at once: tk.Canvas has no class key bindings, so ::tk::FocusOK rejected it as a focus stop; nothing bound wheel, PageUp/PageDown or arrows, leaving only a draggable thumb; and canvas clipping does not unmap children, so below-the-fold fields stayed in the tab ring while Tk never scrolled to follow focus -- Tab led to fields the user could neither see nor reveal. Its height was also a magic 0.7*toplevel above ~230-290px of fixed chrome, i.e. satisfied at 1080p and violated at 768p, where SUBMIT/BACK were pushed off the bottom. All of that is gone by deletion: the surface container is now a gatelock.ScrollableSurface, so the inner viewport is redundant. build_surface and _ensure_container both use it, which fixes the same symmetric-clipping problem for EVERY screen rather than one at a time; center_when_fits keeps short screens looking exactly as they did. Re-arming after a repaint hooks into clear_container(), which all ~19 repaint sites already call. "Remember to call settle after painting" is a rule that would eventually be missed, and on a lock a missed re-arm means unreachable content. The aux windows hardcoded geometry("600x400") and ("700x450") while displaying more than that -- the relaxed-day prompt's own button row requests 862px inside a 700px window, sheared at both edges. That pre-dates this work by a wide margin (Tk's default focus ring accounts for 4px of the 162px overflow). They now size to content, floored at the old values and clamped to the display. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-07-30 16:25:45 +02:00
Krzysztof kuhy Rudnicki	c0aae7d05b	Make the lock overlay's sport selector usable, and focus its form fields ... The manual-workout sport selector was a `tk.OptionMenu`, and while the screen was locked it could not be changed. A posted Tk menu is a separate override-redirect toplevel that takes the Tk grab for itself, and gatelock's 1s recovery tick attacks it from both sides: `_surfaces.enforce()` lifts the lock surface over the menu, and `_reassert_grab()` read the grab sitting on the menu as "the grab was lost" and yanked it back. The menu opened on click and died within a second. On 2026-07-26 that forced an hour-long walk to be logged through the table-tennis form, with the reason typed into `racket`. Radio buttons instead. They are ordinary children of the surface, so they lift with it and live inside the root's grab tree -- neither mechanism can reach them. That is a structural guarantee, not a tuned workaround; the alternative, teaching gatelock to skip its lift while a popup is posted, would open a window where something could cover the lock. They are also the first version of this control styled from the shared palette, where the OptionMenu was default grey on the dark overlay. Nothing on a lock surface may open a popup, so two halves enforce it. The static half walks each module's AST for popup-creating names -- AST rather than a source regex because the modules explain this bug in prose that names the very widgets being banned. Its module list is derived ("imports tkinter", minus a short reasoned exemption list) rather than hardcoded, so a new lock screen is in scope the day it is written; a hardcoded list drafted today would already have missed `_sick_dialog`. The behavioural half is `scripts/verify_lock_popup_safety.py`: it builds the real form with real Tk, replays both hostile behaviours for five ticks, and re-runs the original failure so the mechanism stays demonstrated rather than described. It re-execs itself under Xvfb -- a global grab on the developer's own session would freeze it -- and a CI job runs it, because the pytest suite replaces the whole `tk` module and so cannot host it. Separately, no field ever took keyboard focus. Under a global grab that means typing goes nowhere with no other window on screen to reveal why. The manual-workout and sick-justification forms now each name their own first field via a `focus=` flag; `on_focus_ready` genuinely has nothing to focus (it fires before those screens exist) and its docstring now says that instead of claiming the lock window has no typed input at all. `scripts/fix_2026_07_26_sport.py` re-files that walk as sport "other", rebuilt through the form's own draft/validate/build path so it carries exactly the writer's key set, and re-signed. `start_time` and the date are untouched so `workout_id` stays stable and the phone converges instead of gaining a duplicate. Kept as the audit trail for the edit; the walk's details come from the entry and `--details`, so nothing personal lands in a tracked file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-07-26 15:08:08 +02:00
Krzysztof kuhy Rudnicki	0c6f6957a8	Wire gatelock.LockConfig into every window, not just the lock overlay ... self._colors = LockConfig(...) is now built unconditionally in ScreenLocker.__init__ (previously only the fullscreen lock path built a local `config`), and every raw hex literal across status_view.py, _ui_flows.py, _ui_flows_relaxed.py, _sick_dialog.py, _manual_workout_dialog.py, _manual_workout_widgets.py, and _temperature_status_mixin.py now reads from it instead -- replacing ad hoc greens/oranges/reds (#00ff00, #0066cc, #ff4444, ...) with the shared success/accent/danger/warning/muted tokens. Also fixes the verify-window and status-window paths that still hardcoded #1a1a1a for the background. This was the prerequisite the on-fill fix (previous commit) actually needed: _window_setup.py/_ui_widgets.py/_heat_skip.py reference self._colors, which nothing in the codebase constructed outside the fullscreen lock path until this commit. Verified: 859/859 tests, 100% coverage.	2026-07-21 21:45:59 +02:00
Krzysztof kuhy Rudnicki	60d8c3361b	Redesign manual-workout form: two-column grid, drop phone-only fields ... The manual-workout evidence form (shown on the lock screen and the status window via the shared ManualWorkoutDialogMixin) was a cramped, narrow centered column of tiny inputs with large empty margins, and included two fields that make no sense to fill from a locked PC. - Remove the vestigial "Google Maps link" (location_maps_link) and "Screenshot path" (proof_screenshot_path) fields from the form, the ManualWorkoutDraft dataclass, and build_entry(). Both were written to workout_log.json but never read by any code. The now-empty "Evidence" section is gone too. reservation_phone is kept. - Lay the form out as a two-column grid that fills ~90% of the screen (the fullscreen container was shrink-wrapping to its widest child) with larger labels/inputs; reflection boxes span full width. Activity-specific fields now sit directly under their section header. - Extract the low-level field/grid builders into a new ManualWorkoutFormWidgetsMixin (_manual_workout_widgets.py) so the dialog module stays under the 400-line cap; the dialog mixin inherits it, so the host classes need no change. Tests updated for the removed fields and the pack->grid sport swap; added a unit test for the grid cursor's odd-row bump. Full suite green at 100%. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PM3auNTifaVgcXWDizZrjH	2026-07-13 10:09:18 +02:00