5 Commits

Author	SHA1	Message	Date
Krzysztof kuhy Rudnicki	7851d592fd	shutdown bonus: apply the moment a gate writes its ledger (earner-bonus.path) ... Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-10-06 20:42:13 +02:00
Krzysztof kuhy Rudnicki	9131c8086e	Log manual workouts headlessly, with the form's rules intact ... The phone form was the only way to log a manual workout, so logging one depended on the phone's foreground. Another app taking focus mid-entry could interleave a field (seen: "Played 6 games 1 did nPlayed 6 games...") or drop one, which is a bad property for a record that spends budget. `--log-manual-workout` takes every field as a flag and needs no UI, no phone and no app. It is emphatically NOT a way to log a workout without evidence: the draft goes through the same `validate_manual_workout`, so a missing or too-short field refuses the whole run, writes nothing and exits non-zero with the concrete reason. Sport-specific rules survive too -- table tennis still demands its match counts, racket and balls. Routed through `ingest_manual_records` rather than writing `log.json` directly, so validation, the rolling 2/week budget, HMAC signing and workout_id dedup are the shared implementation with the sync path instead of a second copy that can drift. That is the difference from the deleted `log_manual_workout.py`, which bypassed the checks: here the budget refuses a third entry in a week exactly as the phone does, and re-running an identical command is a no-op rather than a duplicate. "Today" is UTC, matching how the budget windows compute it -- a local date near midnight would file a workout in a different window than it is counted in. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWq9MRemX9ZWvNmnhNWUP2	2026-08-27 20:50:52 +02:00
Krzysztof kuhy Rudnicki	c1c73d43ba	Stop the relaxed-day popup from re-firing every 30 minutes after Skip ... workout-locker.timer (added in e5db254) re-runs the full lock-decision chain every 30 minutes, but is_relaxed_day() is a pure date check with no memory of an earlier same-day dismissal. Clicking "Skip — No Penalty" only closed the window without persisting anything, so the next tick re-derived reason=relaxed_day and rebuilt the same popup. Now the skip button writes a relaxed_day_skip marker to the log (excluded from weekly counting and sync, same treatment as heat_skip), and the startup chain checks for it before re-entering the relaxed-day branch. Also renames workout_log.json to log.json throughout the repo, tests, docs, and Dart comments, since the fix touches that file anyway. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qH2hJ6mvCJd3ZXpAJSaF7	2026-08-18 21:55:59 +02:00
Krzysztof kuhy Rudnicki	e5db25468d	Re-arm the locker, and make a disarmed enforcer impossible to miss ... The screen locker stopped locking on 2026-08-04 and nobody could tell. Not a logic bug: every predicate worked the whole time. systemd logged timers.target: Found ordering cycle: early-bird-workout-check.timer/start after graphical-session.target/start after basic.target/start after timers.target/start - after early-bird-workout-check.timer timers.target: Job early-bird-workout-check.timer/start deleted to break ordering cycle starting with timers.target/start and left the timer disabled. A timer that is WantedBy=timers.target must not be ordered After= a target that itself comes after timers.target; systemd resolves that loop by deleting the job, which is an absence, and absences page nobody. That timer is the ONLY thing that closes the early-bird window. Each morning a run inside the window banked early_bird_pending.json, logged "will re-check at 08:30", and exited 0. The re-check never came, so the marker stood all day, every day, for thirteen days. It stayed invisible because logging.basicConfig was called only in the --sync-only branch, never for --production -- the mode systemd actually runs. Journal proof: zero INFO lines from workout-locker.service since June. Every early exit logged at INFO into a logger with no handler. Meanwhile the healthy 15-minute sync kept the system looking alive. The 2026-08-15 Python split is NOT implicated: it was pure code motion, and basicConfig already sat in that branch before it. Fixes: * Drop the After= that closes the cycle; Persistent=true so a machine asleep at 08:30 still re-checks after resume. * Add workout-locker.timer (*:00,30). The service is WantedBy= graphical-session.target, i.e. one decision per login, so the 08-16 -> 08-17 day and ISO-week rollover inside one long session was never re-evaluated. * arm.sh: install units, enable timers, verify -- one command, because re-arming was a four-command sequence that was easy to half-do, and `systemctl enable` returns 0 while systemd deletes the timer job. * check_enforcement_armed.py asks systemd what it actually scheduled (enabled AND has a next trigger) and fails loudly otherwise. Wired as ExecStartPost on workout-sync.service, so a disarmed locker marks that unit failed every 15 minutes instead of scrolling past. install_systemd.sh now fails on it too. Logging (the reason this went unnoticed, so treated as a defect in its own right): * basicConfig for every mode, never one branch. * Every enforcement-abandoning exit records a decision instead of an invisible INFO: one greppable line -- DECISION lock=no reason=early_bird_window_active weekly=0/5 -- at WARNING, since per CLAUDE.md an INFO explanation of a non-action is a silent failure with extra steps. The enforced case is logged too: "no line at all" was the outage's whole signature. * A durable JSONL trail outside the repo (~/.local/share/screen_locker/), so "when did this last actually enforce?" survives journal rotation. --status and --sync-only record lock=n/a; "did not decide" must never look like "decided not to lock". * check_silent_failures.py now also catches sys.exit(0) that explains nothing. Verified both directions: it flags 3/3 exits in the pre-fix _auto_upgrade.py and passes the repo clean. Sync noise: four records replayed as WARNINGs every cycle (~384/day), which is how the actionable lines got tuned out. manual_workout:2026-08-15 is an empty stub ({date, kind, type}) -- no workout to recover, and that day's credit was already counted under a different sync_record_id, so no credit was ever lost. The three "collided" records are dedup working. Both now report at info; a WARNING from this logger again means something real. 4 -> 0 per cycle. Verified on the live system: the periodic timer fired at 16:45 and the journal shows `DECISION lock=no reason=scheduled_skip_day weekly=0/5` -- the line that did not exist for thirteen days. Both timers report enabled and scheduled, and no ordering cycle recurs. Today is a scheduled skip so the machine was not locked mid-session; enforcement resumes tomorrow 08:30. 1007 tests, 100% coverage, all hooks green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2b6ZjBcdrkSYnMujx4mWd	2026-08-17 16:47:25 +02:00
Krzysztof kuhy Rudnicki	4b4695e23a	Split screen_lock.py under the 250-line cap ... Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-15 19:01:18 +02:00