12 Commits

Author	SHA1	Message	Date
Krzysztof kuhy Rudnicki	7d8daca111	sick days: one shared sickdays pool, 20:00 shutdown floor, one-tap lock button ... A sick day is now a date in the shared sickdays pool (utils sickdays 0.1.0) and nothing else. Removed: the 7/30/90-day budget, the escalating lockout countdown, the justification form, the commitment prompt and its double debt, the workout-debt counter, the -60 min shutdown cut and its sick_day_state.json, the post-sick-day --verify-workout mode, the sick auto-upgrade, scripts/revoke_sick_day.py and their tests. - Lock screen: "I'm sick" on the retry, no-phone and both Tue-Thu screens; one tap -> sickdays.add_sick_day(today) -> sick floor -> best-effort background sickdays.sync_quietly -> unlock. Refusals (free day, unreadable pool) are shown and the lock stays. - Shutdown: the reset resolves with earned_time.resolve(..., sick=True) (max(20:00, ladder), capped 23:00) and saves the sick lift with the grace lift, so later credits absorb it instead of stacking on 20:00. A day marked after the reset is lifted by the new _sick_floor live pass (every 5-min tick, --sync-only, --apply-bonuses, and the tap itself). - Workout lock and grace floor stand down on a sick day; workouts that day credit normally through the sync paths. - wake-alarm workday_penalty.json is void when its issued_date or penalty_date is a sick day. - Status window, i3 line, CLI --status, MCP flags and web reasons read sickdays. - scripts/migrate_sick_history.py imports sick_history.json's dates via sickdays.import_legacy, verifies and removes the file; idempotent, run by install.sh. - Pins: earned-time 0.11.0, freedays 0.4.0, sickdays 0.1.0 (tags pending); pre-commit 4.7.0, ruff 0.17.1 (freshness gate). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xfj1sxKH9VBPqpcAni8Jry	2026-10-16 13:30:39 +02:00
Krzysztof kuhy Rudnicki	fc5453495c	drop the weekly shutdown bonus entirely; every bonus stops at the shutdown ceiling ... Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>	2026-10-10 08:59:50 +02:00
Krzysztof kuhy Rudnicki	275a0862fc	shutdown: minutes end to end (*_MINUTES schedule keys, HH:MM helper args, to_hours removed) ... Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-10-04 19:48:24 +02:00
Krzysztof kuhy Rudnicki	a22ec380ca	Credit RunnerUp runs by the day rule, from the WebDAV drop dir, and never twice ... Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-09-16 21:14:17 +02:00
Krzysztof kuhy Rudnicki	ec0946f64e	Grade against 3.14 too, not just run on it ... `requires-python` and the CI pin already said 3.14, but ruff, mypy and pylint were still grading against 3.10 -- three tools judging an interpreter nothing runs any more, and ruff withholding the pyupgrade fixes that only become safe at the newer target. `pin_ci_python.py` rewrites exactly these three knobs. What the stale target was hiding: 118 sites on `datetime.timezone.utc` instead of `datetime.UTC` (UP017), two classes still written with `Generic[...]` rather than PEP 695 syntax, and ruff's stable formatter applying PEP 758 -- `except (A, B):` becomes `except A, B:`. That last one makes the source 3.14-only at the syntax level, which is what `requires-python = ">=3.14"` already promised; kuhy chose it deliberately over holding ruff a release back (2026-08-29). The PEP 695 fix needed a hand: ruff rewrote `class WidgetGroup(Generic[_W])` to `class WidgetGroup[W: tk.Misc]` but left the body annotated with the module-level `_W`, a *different* type variable -- mypy caught it as "a function returning TypeVar should receive at least one argument containing the same TypeVar". Renamed the body to the new parameter, gave `FrameGroup.__init__` the concrete `list[tk.Frame]` it always wrapped, and deleted the two now-dead module-level TypeVars. ruff, ruff-format, mypy --strict and both pylint passes clean at the new target. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SfnJmxxsZ534AKk16rC2Gr	2026-08-29 11:42:47 +02:00
Krzysztof kuhy Rudnicki	e5db25468d	Re-arm the locker, and make a disarmed enforcer impossible to miss ... The screen locker stopped locking on 2026-08-04 and nobody could tell. Not a logic bug: every predicate worked the whole time. systemd logged timers.target: Found ordering cycle: early-bird-workout-check.timer/start after graphical-session.target/start after basic.target/start after timers.target/start - after early-bird-workout-check.timer timers.target: Job early-bird-workout-check.timer/start deleted to break ordering cycle starting with timers.target/start and left the timer disabled. A timer that is WantedBy=timers.target must not be ordered After= a target that itself comes after timers.target; systemd resolves that loop by deleting the job, which is an absence, and absences page nobody. That timer is the ONLY thing that closes the early-bird window. Each morning a run inside the window banked early_bird_pending.json, logged "will re-check at 08:30", and exited 0. The re-check never came, so the marker stood all day, every day, for thirteen days. It stayed invisible because logging.basicConfig was called only in the --sync-only branch, never for --production -- the mode systemd actually runs. Journal proof: zero INFO lines from workout-locker.service since June. Every early exit logged at INFO into a logger with no handler. Meanwhile the healthy 15-minute sync kept the system looking alive. The 2026-08-15 Python split is NOT implicated: it was pure code motion, and basicConfig already sat in that branch before it. Fixes: * Drop the After= that closes the cycle; Persistent=true so a machine asleep at 08:30 still re-checks after resume. * Add workout-locker.timer (*:00,30). The service is WantedBy= graphical-session.target, i.e. one decision per login, so the 08-16 -> 08-17 day and ISO-week rollover inside one long session was never re-evaluated. * arm.sh: install units, enable timers, verify -- one command, because re-arming was a four-command sequence that was easy to half-do, and `systemctl enable` returns 0 while systemd deletes the timer job. * check_enforcement_armed.py asks systemd what it actually scheduled (enabled AND has a next trigger) and fails loudly otherwise. Wired as ExecStartPost on workout-sync.service, so a disarmed locker marks that unit failed every 15 minutes instead of scrolling past. install_systemd.sh now fails on it too. Logging (the reason this went unnoticed, so treated as a defect in its own right): * basicConfig for every mode, never one branch. * Every enforcement-abandoning exit records a decision instead of an invisible INFO: one greppable line -- DECISION lock=no reason=early_bird_window_active weekly=0/5 -- at WARNING, since per CLAUDE.md an INFO explanation of a non-action is a silent failure with extra steps. The enforced case is logged too: "no line at all" was the outage's whole signature. * A durable JSONL trail outside the repo (~/.local/share/screen_locker/), so "when did this last actually enforce?" survives journal rotation. --status and --sync-only record lock=n/a; "did not decide" must never look like "decided not to lock". * check_silent_failures.py now also catches sys.exit(0) that explains nothing. Verified both directions: it flags 3/3 exits in the pre-fix _auto_upgrade.py and passes the repo clean. Sync noise: four records replayed as WARNINGs every cycle (~384/day), which is how the actionable lines got tuned out. manual_workout:2026-08-15 is an empty stub ({date, kind, type}) -- no workout to recover, and that day's credit was already counted under a different sync_record_id, so no credit was ever lost. The three "collided" records are dedup working. Both now report at info; a WARNING from this logger again means something real. 4 -> 0 per cycle. Verified on the live system: the periodic timer fired at 16:45 and the journal shows `DECISION lock=no reason=scheduled_skip_day weekly=0/5` -- the line that did not exist for thirteen days. Both timers report enabled and scheduled, and no ordering cycle recurs. Today is a scheduled skip so the machine was not locked mid-session; enforcement resumes tomorrow 08:30. 1007 tests, 100% coverage, all hooks green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2b6ZjBcdrkSYnMujx4mWd	2026-08-17 16:47:25 +02:00
Krzysztof kuhy Rudnicki	c277325a3e	Make Check Phone week-aware; add RunnerUp GPS tolerance; fix CLI weekly count ... Check Phone only ever checked today's date, so a verified workout from earlier in the week (e.g. yesterday's run, found once the phone connects later) was never backfilled unless you ran the --status CLI. It now falls back to the existing RunnerUp week-scanner plus a new StrongLifts equivalent, still pulling and validating the real file via ADB before crediting anything. GPS distance tracking undershoots on tight turns/tree cover, so a run within 5% of the 5.0 km minimum (e.g. 4.9 km) is now accepted instead of silently rejected — duration is clock-based and gets no such leeway. Also fixes a pre-existing bug in the --status CLI surfaced by this change: its weekly-total summary derived counts from a per-day checkmark (max 1 per day) instead of screen_locker._weekly_check.count_weekly_workouts, undercounting any day with more than one verified workout. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ERWuV1nExiMfiNb9Gb7AQt	2026-07-18 06:55:55 +02:00
Krzysztof kuhy Rudnicki	79879263ba	Support multiple workouts per day; fix the dead sync; ban silent failures ... The workout log stored ONE workout per calendar day, so a second same-day workout was silently dropped and could never earn credit. Multiple workouts per day: - workout_log.json: {date: entry} -> {date: [entry, ...]}. Legacy entries are wrapped on read (_log_io.load_workout_log) so their HMACs stay valid — no re-signing; every write normalizes the file, migrating it progressively. - New write chokepoint (_log_mixin.write_signed_entry) APPENDS and dedups by a stable workout_id, returning RecordResult so callers can tell a new workout from a duplicate. Re-verifying the same workout is a no-op. - count_weekly_workouts is anti-gaming: each VERIFIED workout counts individually; self-reported manual entries count at most once per day. Four real workouts in one day satisfy the week; four manual entries count as one. - Reward: the day's first counted workout gets the base +2h; an additional same-day VERIFIED workout gets +1h; an additional manual gets nothing. The old "+1h when weekly_count > 4" gate is replaced — weekly volume is the banked bonus's job and shouldn't be paid twice. - Fixed: the unlock screen labelled the +1h "#{weekly_count - 4}", which can render negative under the new rule. Removed the dead runnerup_manual type. - Flutter: the manual budget counts distinct DAYS, matching the PC. PC->phone sync (it had never worked once): - push_pc_manuals pushed from a side-store written at log-time, so anything logged before that feature existed could never publish. _manual_push now derives the crdt log directly from workout_log.json — the single source of truth — covering manual AND verified runs. The record id is the workout's own workout_id (derived for legacy entries to match the phone's format) and the HLC comes from the entry's own timestamp, so a re-push is byte-identical and the repo never churns. - The phone reads every kind (readMergedWorkoutPayloads) and lists the PC's workouts under "SYNCED FROM PC". The manual budget still sees manual-only, so a verified run can't consume a self-report slot. - Settings claimed "Connected." whenever a token STRING existed. It now verifies against the API on open, so a revoked token reports 401 instead of showing a green lie. Never fail silently: - 30 swallowed exceptions across 19 files now log WARNING with the concrete cause AND consequence — plus the token guards in _workout_sync that returned [] in total silence, the exact bug that hid the dead sync for weeks. - New pre-commit hook (scripts/check_silent_failures.py) fails any except that neither re-raises nor logs loudly. ruff's S110 only catches `except: pass`; the real pattern here was `except: log.info(); return []`. Documented in CLAUDE.md. Verified on real data: the Jul 13 run (pulled from its actual TCX over ADB) now counts alongside that day's manual squash, and all three workouts are published to kuhyx/syncs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fv8ULVt3Q67GwCFbM7doHB	2026-07-17 09:22:31 +02:00
Krzysztof kuhy Rudnicki	53140a96e2	Fix pre-existing CI failures (crdt_sync dep, dead type:ignore, ruff) ... CI ran on 399f981 before these fixes landed; both workflows were red: - Tests: ModuleNotFoundError: No module named 'crdt_sync'. CI installs requirements.txt (not pyproject deps), which lacked the crdt-sync git dependency the Workstream-C sync introduced. Add crdt-sync + mcp>=1.9 to requirements.txt (mirrors diet-guard's fix). - pre-commit no-noqa: ~45 `# type: ignore[attr-defined]` comments across _auto_upgrade/_runnerup_db/_status/_heat_skip flagged repo-wide by the no-noqa hook. The mypy hook already runs with --disable-error-code=attr-defined, so every one of these ignores was suppressing an already-disabled check — dead weight. Removed them; mypy and pytest (747 passed, 100% cov) both stay green. Same for the test's redundant `# type: ignore[override]` (override never fired). - pre-commit ruff: FBT003 in _heat_skip.py (tk positional bools, its API) and C901/PLR0912 in _status.py run_status (branchy weekly pipeline by design) — added per-file-ignores with rationale, matching the existing ignores for the sibling validation-chain modules. - Added crdt-sync/mcp/pydantic to the pylint hook's additional_dependencies so pylint can resolve the new imports. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PMRRVVkeRyrSaaqueMZKG	2026-07-11 17:05:03 +02:00
Krzysztof kuhy Rudnicki	7bb43422f2	Fix silent skip-credit bypass; replace with weekly shutdown-time bonus ... The screen locker skipped enforcement on 2026-07-03 without ever showing a lock: a banked skip credit (earned from a prior 5+/week streak) was consumed automatically with no confirmation and no visible log. Reworked the whole reward mechanic instead of just gating it, since banking a "skip a future workout" credit works against maximizing weekly workouts: - Removed skip credits entirely (has_skip_credit/consume_skip_credit and the confirmation dialog built to gate them). The only same-day skip paths left are heat_skip and sick_day, both requiring a genuine reason. - Extra workouts (5+/week) now bank shutdown-time-later hours for the following week instead — comfort, not reduced enforcement. Reuses the existing _adjust_shutdown_time_by and reset_to_base_if_new_day's previously-discarded return value as the once-per-day gate. - early_bird and sick_day no longer pollute workout_log.json. early_bird is a same-day pending marker now stored in its own self-expiring, HMAC-signed file; sick_day is sourced entirely from sick_history.json (already the real source of truth). Fixes an accidental-safety gap where "already took a sick day today" only halted startup by luck. - Cleaned up 3 stale non-workout entries already in workout_log.json. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdTccgbK7624kfoaV6CtXS	2026-07-03 15:27:08 +02:00
Krzysztof kuhy Rudnicki	2729c2a880	Add heat-skip feature and fix early-bird 9:00 re-check gap ... Heat skip: if Warsaw temperature >= 32°C at locker startup, a fullscreen dark-themed dialog asks the user to confirm skipping. Temperature is always fetched from wttr.in automatically (user cannot self-report). Fail-closed: API unavailable → no dialog, normal lock. Placed before skip-credit consumption so credits are preserved when heat skip is used instead. Logs a heat_skip entry (with temperature) to workout_log.json; does not count toward weekly minimum. Visible in --status as "Heat skips (month)". Early-bird gap fix: the re-check timer now fires at both 08:30 (normal 5:00–8:30 window) and 09:05 (extended 5:00–9:00 window earned by 5+ workout weeks). Previously the 08:30 run would see the window still active on extended weeks and never re-check after 9:00. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QCx1roriuXzFgrzFXtugb	2026-06-29 11:23:19 +02:00
Krzysztof kuhy Rudnicki	eec0662ef9	Add auto-fill RunnerUp scan, carrot bonuses, and --status interface ... - Refactor RunnerUp verification: extract RunnerUpDbMixin (_runnerup_db.py), split _scan_and_fill_week_runnerup into a helper _try_fill_runnerup_for_date to keep cyclomatic complexity ≤10 - Generalise TCX lookup to any date in the ISO week (was today-only); all gap days Mon→today auto-filled on every startup and 08:30 timer firing - Add _adjust_shutdown_time_by(): +1h per extra workout beyond the 4-workout minimum, capped at midnight (hour=24) - Add _shutdown_base.py: daily reset of shutdown config to a stored base so the bonus doesn't silently accumulate across days - Add _extra_benefits.py: streak tracking, skip credits (earn (n-4) credits for 5+ workout weeks), early-bird extension to 09:00 for eligible weeks - Add --status mode (_status.py): non-locking CLI view showing per-day breakdown (✓/✗), RunnerUp auto-scan, bonus status, shutdown time, streak, skip credits, and early-bird status - Hook carrot into _check_non_verify_exits: bonus applied whenever auto-fill pushes weekly count above the minimum - Pass all pre-commit hooks (ruff, mypy, pylint, bandit, shellcheck, codespell, max-file-length); 508 tests at 100% branch coverage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017auyHmf2ZwQcDAwXaSo7KX	2026-06-28 08:08:35 +02:00