12 Commits

Author	SHA1	Message	Date
Krzysztof kuhy Rudnicki	2d728fb791	workout_app: same 30/25 duration bar as the locker ... Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>	2026-11-01 17:34:14 +01:00
Krzysztof kuhy Rudnicki	8ba9ee93fa	workout_app: log manual workouts for future dates, planned list + delete ... The manual form takes a workout date from today to today+7 (never past). The budget is read as of that date: the fullest 7-/30-day window containing it, past and planned entries alike. History lists future manual entries under PLANNED (off the calendar) and deletes them until their day via a crdt-sync tombstone. Re-logging onto a tombstoned id is refused; a failed push keeps the form open with the reason. Shared fixture manual_budget_merge.json gains a 'planned' scenario (top-level expectations unchanged). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015mmTBiMpvyfLuEAXc6nDYT	2026-10-16 15:36:27 +02:00
Krzysztof kuhy Rudnicki	d35edfc10c	workout_app: warmup ×6, per-exercise rests, exercise sheet in Settings ... - Warmup is always 6 reps (kWarmupReps): even, one constant. - Per exercise: rest after success / fail / warmup (0:30-10:00, 15 s steps; defaults 3:00/5:00/3:00). Schema v6 NOT NULL DEFAULT columns, synced in the Firebase progression record (lenient for older records). The notification carries the fail rest so -1 rep re-cuts to it. - Settings: PER EXERCISE list replaces PROGRESSION THRESHOLDS; each row opens the workout tile's sheet and pushes progression when it closes. Claude-Session: https://claude.ai/code/session_01KeVXsWTuwjmZK5uvbw6vqF Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-09-27 18:55:56 +02:00
Krzysztof kuhy Rudnicki	38b56e1e2b	workout_app: progression modes, inline warmup, injury pause, no app bar ... - Per exercise: weight / reps / double progression (n=12, m=6), one pure rule shared by Finish and every preview; streaks and next step shown on the tile. Warmup is the first circle of the set row and can be turned off. - Pause an exercise for n days (default 14): shown as paused, recorded as FAILED every workout so it steps down; skipped by the notification. - App bar removed: Reset/Finish live in the rest strip, no rest labels. - Schema v5 (progression_mode, reps_high, reps_low, has_warmup, paused_until), synced through the Firebase progression record; NULL warmup = plan default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeVXsWTuwjmZK5uvbw6vqF	2026-09-27 17:36:17 +02:00
Krzysztof kuhy Rudnicki	b6e89b93dc	workout_app: run the break countdown in a foreground service with notifications ... The between-set break never finished once the phone's screen was off. Three independent causes (worked through on-device on 2026-09-12; left uncommitted awaiting the go-ahead, committed here as-is plus one pin bump): 1. The countdown was not wall-clock: `_breakRemaining--` on a Timer.periodic, which Android throttles and Doze suspends in a backgrounded isolate, so the counter stalled and _onBreakFinished() never fired. Now a BreakClock deadline on the wall clock. 2. An expired break was silently dropped on restore (`if (remaining > 0)` only) — now cued and logged. 3. No notification infrastructure at all: no package, no POST_NOTIFICATIONS / FOREGROUND_SERVICE / WAKE_LOCK. Now: flutter_foreground_task runs the countdown in a service isolate that survives BACK and the screen lock; flutter_local_notifications shows an ongoing "Workout A · break m:ss / Next: …" notification with −1 rep / Done actions and a "Break over" alert on its own channel (raw break_end sound, vibration). Button presses go through a persisted BreakIntent queue the screen drains on resume, so a press with the app killed is not lost. Finish and Reset stop the service; a startup reaper handles the crash case. Verified on the phone with the screen off and locked: service alive and ticking while Dozing, both notifications on the lock screen, channel importance 5 with the break_end sound. Not verifiable from adb (receiver is RECEIVER_NOT_EXPORTED): an actual action-button tap, and a true recents swipe — see stronglift_replacement/TODO-workout-app-v2.md. Also fixed en route: the break-end sound had never played in any widget test (AssetSource needs path_provider, which nothing faked, and the failure was swallowed by catchError); the queue's prune wrote back a stale list. This commit additionally: - takes the freshness gate's bump flutter_local_notifications 22.3.1; - restores web/package.json to HEAD (the tree held a stale pre-bump copy); - gives scripts/check_flutter_coverage.sh a FLUTTER_TEST_CONCURRENCY knob: the default one-isolate-per-core run peaks over 4 GiB and is OOM-killed under the resource cap. Default behaviour unchanged. Gate: flutter analyze clean, 511 tests, 3187/3187 lines (100%), pre-commit green. Not re-installed on the phone for the 22.3.1 pin: no device attached at commit time. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C7vgacLhb4WJjxuVj2QLEP	2026-09-13 20:28:36 +02:00
Krzysztof kuhy Rudnicki	81ebccb51a	Stop the phone counting deleted and empty manual workouts ... The app said "manual budget exhausted for this window" (2/2w, 4/10m) while the PC read 1/2w, 2/10m for the same records. The PC was right; two independent Dart defects each inflated a window by one. `_readMergedPayloads` never looked at `Record.deleted`, so the tombstoned duplicate `manual:2026-08-21T21:00` -- the second of two logged on 08-21, already deleted -- kept consuming a weekly slot. Suppression is collected across the whole device union and applied after the merge, not per file: one device tombstoning a record while another still holds it live must delete it, and a per-file skip would just let the live copy win. This mirrors the PC's `_tombstoned_ids`. `countManualBudget` also counted `manual_workout:2026-08-15`, a bare `{type, kind, date}` stub with no evidence fields. The PC refuses to ingest those ("no workout data to ingest; skipping permanently"), so the phone was charging budget for a workout neither device ever accepted. The filter lives in the counter rather than the shared reader because `runnerup_verified` and `pc_workout_verified` payloads legitimately carry no `start_time`, and the history view must keep showing them. Covered by a shared literal fixture both languages read, rather than two independent round-trips: each side's own tests passed while the pair disagreed, which is exactly how this shipped. Verified by reverting each guard in turn and watching the twin fail. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWq9MRemX9ZWvNmnhNWUP2	2026-08-27 20:13:12 +02:00
Krzysztof kuhy Rudnicki	3d992ef71b	Split manual_workout_test.dart (350) into three by group ... 402 Dart tests before and after. The cross-language wire-format group moves with its siblings and still pins the same literal keys the Python side emits. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EveB813BQ8abAP68VSqZ5Y	2026-08-15 21:32:58 +02:00
Krzysztof kuhy Rudnicki	c63a02f9eb	Add sync-status card and duration-threshold fixture ... Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-15 18:41:31 +02:00
Krzysztof kuhy Rudnicki	87e625cc5f	Make the phone's manual-workout budget agree with the PC, twice over ... The phone and PC each compute a nominally SHARED manual-workout budget over the same merged records, and disagreed on both halves of it. The cap: _constants.py has said 10 per 30 days since 298daf0; the Dart mirror was still 5, so between 5 and 9 the phone hard-blocked the form for a workout the PC would have accepted and credited. The stricter side wins, so this cost logged workouts rather than granting extra ones. The counting rule: count_in_window counts ENTRIES ("each logged manual workout consumes its own budget slot"), while countManualBudget built a Set of date strings and counted DAYS -- despite a docstring claiming it mirrored the PC. Three workouts on one day read 3/2 on the PC, over its 7-day cap, but 1/2 on the phone, which kept accepting. Both now report 3 for that input. Per-entry is the correct semantic because each entry separately earns weekly-count and shutdown credit, so each must separately cost budget. The wire fixture could never have caught either: the caps and the counting rule never travel on the wire. The comment claiming it was "the tripwire that catches drift" was wrong and is corrected. The real guard, TestCrossLanguageBudgetConstants, parses manual_workout.dart and compares it to the imported Python constants -- one test that fails on EITHER side's drift. Asserting a Python constant against a Python literal would have stayed green through 298daf0, which is the drift that actually happened. Also: the history volume chart summed targetWeight x targetSets x targetReps, so a session where every set failed plotted identically to one completed in full -- the line only moved when progression changed the target. It now sums weight x doneReps over the logged sets. On today's real session that is 2790 -> 1440 kg, because 5 sets of bench press were logged at 0 reps and were being counted at full credit. No targetWeight fallback per set: weight is non-nullable and always serialized, and substituting the target would overstate a set the user never did. design.md/dfesign_v2.md: record that the Crucial (progress lost on exit) and High (sound + vibration) items are done, that breaks are still per-set, and that the warmup fraction shipped as 4/5 -- neither the 2/3 nor the 3/4 the specs asked for, and 4/5 is what is wanted. Verified on the phone (release build, signed with the shared key, installed with adb install -r so the workout history survived); 907 Python and 313 Dart tests pass with the coverage bar green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A4y93ZSnk2w5LH3B12LHNc	2026-08-09 17:34:46 +02:00
Krzysztof kuhy Rudnicki	79879263ba	Support multiple workouts per day; fix the dead sync; ban silent failures ... The workout log stored ONE workout per calendar day, so a second same-day workout was silently dropped and could never earn credit. Multiple workouts per day: - workout_log.json: {date: entry} -> {date: [entry, ...]}. Legacy entries are wrapped on read (_log_io.load_workout_log) so their HMACs stay valid — no re-signing; every write normalizes the file, migrating it progressively. - New write chokepoint (_log_mixin.write_signed_entry) APPENDS and dedups by a stable workout_id, returning RecordResult so callers can tell a new workout from a duplicate. Re-verifying the same workout is a no-op. - count_weekly_workouts is anti-gaming: each VERIFIED workout counts individually; self-reported manual entries count at most once per day. Four real workouts in one day satisfy the week; four manual entries count as one. - Reward: the day's first counted workout gets the base +2h; an additional same-day VERIFIED workout gets +1h; an additional manual gets nothing. The old "+1h when weekly_count > 4" gate is replaced — weekly volume is the banked bonus's job and shouldn't be paid twice. - Fixed: the unlock screen labelled the +1h "#{weekly_count - 4}", which can render negative under the new rule. Removed the dead runnerup_manual type. - Flutter: the manual budget counts distinct DAYS, matching the PC. PC->phone sync (it had never worked once): - push_pc_manuals pushed from a side-store written at log-time, so anything logged before that feature existed could never publish. _manual_push now derives the crdt log directly from workout_log.json — the single source of truth — covering manual AND verified runs. The record id is the workout's own workout_id (derived for legacy entries to match the phone's format) and the HLC comes from the entry's own timestamp, so a re-push is byte-identical and the repo never churns. - The phone reads every kind (readMergedWorkoutPayloads) and lists the PC's workouts under "SYNCED FROM PC". The manual budget still sees manual-only, so a verified run can't consume a self-report slot. - Settings claimed "Connected." whenever a token STRING existed. It now verifies against the API on open, so a revoked token reports 401 instead of showing a green lie. Never fail silently: - 30 swallowed exceptions across 19 files now log WARNING with the concrete cause AND consequence — plus the token guards in _workout_sync that returned [] in total silence, the exact bug that hid the dead sync for weeks. - New pre-commit hook (scripts/check_silent_failures.py) fails any except that neither re-raises nor logs loudly. ruff's S110 only catches `except: pass`; the real pattern here was `except: log.info(); return []`. Documented in CLAUDE.md. Verified on real data: the Jul 13 run (pulled from its actual TCX over ADB) now counts alongside that day's manual squash, and all three workouts are published to kuhyx/syncs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fv8ULVt3Q67GwCFbM7doHB	2026-07-17 09:22:31 +02:00
Krzysztof kuhy Rudnicki	6f2ec1fa86	Manual-workout phone sync P4: Dart model + validation ... Dart port of the Python manual-workout model so the phone can build the same signed-on-ingest sync payload the PC form produces. - lib/models/manual_workout.dart: ManualWorkoutDraft (mirrors the Python dataclass), validateManualWorkout (ports validate_manual_workout: required fields, HH:MM end-after-start, min duration, RPE range, per-sport rules, reflection length), buildEntry/buildSyncPayload (byte-for-byte equivalent of the Python build_entry + kind/date), manualSyncRecordId, buildManualRecord. The MANUAL_WORKOUT_* constants are inlined here (a const-only file has no coverable lines and trips the 100%-coverage file-presence guard), replacing models/manual_workout_constants.dart. - test/models/manual_workout_test.dart: the cross-language wire fixture (an identical literal to test_manual_workout.py::TestSyncWireFormat — this catches key-name/format drift between the two serializers) plus full validation coverage. 29 tests; manual_workout.dart is 100% covered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PM3auNTifaVgcXWDizZrjH	2026-07-13 12:55:05 +02:00
Krzysztof kuhy Rudnicki	63489b07b2	Add comprehensive test suite, backup service, and linting to workout app ... - Add sqflite_common_ffi + very_good_analysis; tighten analysis_options - Add BackupService for JSON export/import of exercise state - Add full test coverage: models, screens, services, widgets - Add scripts/check_flutter_coverage.sh to enforce 100% line coverage - Add docstrings to ExerciseState fields and storage service - Minor fixes across screens, widgets, and sync/HTTP services Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VuiPt6GPWkxpLbJFrnfy8U	2026-06-28 08:11:43 +02:00