screen-locker/screen_locker/tests/test_runnerup_verification_part11.py
Krzysztof kuhy Rudnicki 390e916922
Some checks are pending
pre-commit / pre-commit (push) Waiting to run
Tests / test (3.10) (push) Waiting to run
Tests / test (3.11) (push) Waiting to run
Tests / test (3.12) (push) Waiting to run
Tests / lock-popup-safety (push) Waiting to run
release-apk / release (APK) (push) Waiting to run
Finish the RunnerUp sport-allowlist removal; isolate the instance lock in tests
A prior commit (6a7a7d8) accidentally captured only the _constants.py
half of an already-in-progress, uncommitted change removing
RUNNERUP_ACCEPTED_SPORTS -- leaving main broken (import error) since
_runnerup_verification.py and its 15 test files still referenced the
now-undefined constant. Committing the matching half: RunnerUp
entries are now judged purely by distance/duration, any sport
qualifies, matching how every other workout type is already treated.

Also: the new single-instance lock was not test-isolated, so every
ScreenLocker built across the suite contended for the same real
$XDG_RUNTIME_DIR/gatelock file -- only the first test won it, the
rest silently exited. Added to conftest.py's isolated-state table
(split into tests/_isolated_state.py to stay under the 250-line cap)
and added dedicated coverage for screen_locker/_instance.py.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018M5gKyYzxWG6QkCaj1wWfk
2026-08-21 13:17:26 +02:00

155 lines
4.8 KiB
Python

"""Tests for RunnerUpVerificationMixin in _runnerup_verification.py."""
from __future__ import annotations
from typing import TYPE_CHECKING
from unittest.mock import MagicMock, patch
from screen_locker.tests.conftest import create_locker
if TYPE_CHECKING:
from pathlib import Path
# Minimal valid TCX XML for a 40-minute, 6-km run.
_TCX_RUNNING = """\
<?xml version="1.0" encoding="UTF-8"?>
<TrainingCenterDatabase
xmlns="http://www.garmin.com/xmlschemas/TrainingCenterDatabase/v2">
<Activities>
<Activity Sport="Running">
<Lap>
<TotalTimeSeconds>2400.0</TotalTimeSeconds>
<DistanceMeters>6000.0</DistanceMeters>
</Lap>
</Activity>
</Activities>
</TrainingCenterDatabase>
"""
# TCX with a non-running sport tag (Gym).
_TCX_GYM = """\
<?xml version="1.0" encoding="UTF-8"?>
<TrainingCenterDatabase
xmlns="http://www.garmin.com/xmlschemas/TrainingCenterDatabase/v2">
<Activities>
<Activity Sport="Gym">
<Lap>
<TotalTimeSeconds>3600.0</TotalTimeSeconds>
<DistanceMeters>0.0</DistanceMeters>
</Lap>
</Activity>
</Activities>
</TrainingCenterDatabase>
"""
# Two laps that together make a valid run.
_TCX_MULTI_LAP = """\
<?xml version="1.0" encoding="UTF-8"?>
<TrainingCenterDatabase
xmlns="http://www.garmin.com/xmlschemas/TrainingCenterDatabase/v2">
<Activities>
<Activity Sport="Running">
<Lap>
<TotalTimeSeconds>1200.0</TotalTimeSeconds>
<DistanceMeters>3000.0</DistanceMeters>
</Lap>
<Lap>
<TotalTimeSeconds>1200.0</TotalTimeSeconds>
<DistanceMeters>3000.0</DistanceMeters>
</Lap>
</Activity>
</Activities>
</TrainingCenterDatabase>
"""
class TestVerifyRunnerupWorkout:
"""Tests for _verify_runnerup_workout (lines 440-447 and 431)."""
def test_returns_clock_tampered_on_skew(
self,
mock_tk: MagicMock,
mock_sys_exit: MagicMock,
tmp_path: Path,
) -> None:
"""Clock skew detected → clock_tampered without further checks."""
locker = create_locker(mock_tk, tmp_path)
with patch(
"screen_locker._runnerup_verification.check_clock_skew",
return_value=(False, "Clock is off"),
):
status, msg = locker._verify_runnerup_workout()
assert status == "clock_tampered"
assert "Clock" in msg
def test_returns_no_phone_when_device_absent(
self,
mock_tk: MagicMock,
mock_sys_exit: MagicMock,
tmp_path: Path,
) -> None:
"""No ADB device → no_phone."""
locker = create_locker(mock_tk, tmp_path)
with (
patch(
"screen_locker._runnerup_verification.check_clock_skew",
return_value=(True, "ok"),
),
patch.object(locker, "_has_adb_device", return_value=False),
):
status, _ = locker._verify_runnerup_workout()
assert status == "no_phone"
def test_returns_file_result_when_exports_exist(
self,
mock_tk: MagicMock,
mock_sys_exit: MagicMock,
tmp_path: Path,
) -> None:
"""File-based verification succeeds → result returned (line 431 logged)."""
locker = create_locker(mock_tk, tmp_path)
with (
patch(
"screen_locker._runnerup_verification.check_clock_skew",
return_value=(True, "ok"),
),
patch.object(locker, "_has_adb_device", return_value=True),
patch.object(
locker,
"_verify_runnerup_via_files",
return_value=("verified", "Running: 6 km in 40 min"),
),
):
status, _msg = locker._verify_runnerup_workout()
assert status == "verified"
def test_falls_back_to_db_when_no_files(
self,
mock_tk: MagicMock,
mock_sys_exit: MagicMock,
tmp_path: Path,
) -> None:
"""No file exports → DB path tried."""
locker = create_locker(mock_tk, tmp_path)
with (
patch(
"screen_locker._runnerup_verification.check_clock_skew",
return_value=(True, "ok"),
),
patch.object(locker, "_has_adb_device", return_value=True),
patch.object(locker, "_verify_runnerup_via_files", return_value=None),
patch.object(
locker,
"_verify_runnerup_via_db",
return_value=("not_verified", "no run today"),
) as mock_db,
):
status, _ = locker._verify_runnerup_workout()
assert status == "not_verified"
mock_db.assert_called_once()
# ---------------------------------------------------------------------------
# Branch-coverage gap fixes
# ---------------------------------------------------------------------------