screen-locker/screen_locker/tests/test_status_view_part2.py
Krzysztof kuhy Rudnicki 399f9815c4
Some checks are pending
pre-commit / pre-commit (push) Waiting to run
Tests / test (3.10) (push) Waiting to run
Tests / test (3.11) (push) Waiting to run
Tests / test (3.12) (push) Waiting to run
Add phone-workout GitHub sync via shared crdt_sync (Workstream C)
Sync the workout log across devices using the shared crdt-sync /
crdt_sync_dart CRDT transport (same scheme as diet_guard).

- Python: new _workout_sync.py + _temperature_status_mixin.py; wire sync
  into screen_lock.py / status_view.py; add the crdt-sync git dependency
  and test_sync_fixtures / test_workout_sync suites.
- Dart (workout_app): new workout_sync_service.dart, github_device_auth.dart,
  sync_settings.dart with tests + fakes; settings/workout screens updated.
- docs: workstream-d-shared-crdt-transport.md.

Verification: pytest 747 passed at 100% coverage; flutter analyze clean;
flutter test passed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RRCdR4D8SaVrN2xraMQxM
2026-07-11 00:06:59 +02:00

317 lines
13 KiB
Python

"""Tests for status_view.py: phone-check flow, buttons, main() CLI entry point."""
from __future__ import annotations
from typing import TYPE_CHECKING
from unittest.mock import MagicMock, patch
from screen_locker.status_view import (
StatusWindow,
_compliance_state_word,
_make_bare_verifier,
main,
)
from screen_locker.tests._status_view_helpers import (
_button_texts,
_lock_explanation,
_make_window,
_snapshot,
_temp_check,
_texts,
_week,
)
if TYPE_CHECKING:
from collections.abc import Callable
from pathlib import Path
import pytest
class TestPhoneCheckResultRendering:
def test_no_result_shows_nothing(self, mock_tk: MagicMock) -> None:
snap = _snapshot()
_make_window(mock_tk, snap)
assert not any("Phone check" in t for t in _texts(mock_tk))
def test_verified_result_shown_in_green(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
window._phone_check_result = ("verified", "Workout verified!")
window.render(_snapshot())
calls = [
c
for c in mock_tk.Label.call_args_list
if "Phone check" in c.kwargs.get("text", "")
]
assert calls
assert calls[-1].kwargs.get("fg") == "#00cc44"
def test_non_verified_result_shown_in_orange(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
window._phone_check_result = ("no_phone", "Phone not connected")
window.render(_snapshot())
calls = [
c
for c in mock_tk.Label.call_args_list
if "Phone check" in c.kwargs.get("text", "")
]
assert calls
assert calls[-1].kwargs.get("fg") == "#ff8844"
class TestButtons:
def test_renders_check_phone_refresh_close(
self, mock_tk: MagicMock, temp_log_file: Path
) -> None:
_make_window(mock_tk, _snapshot(), log_file=temp_log_file)
assert _button_texts(mock_tk) == {
"Check Phone",
"Log Manual Workout",
"Refresh",
"Close",
}
class TestRefreshAndCheckPhoneFlow:
def test_refresh_clears_phone_result_and_calls_on_refresh(
self, mock_tk: MagicMock
) -> None:
on_refresh = MagicMock()
window = _make_window(mock_tk, _snapshot(), on_refresh=on_refresh)
window._phone_check_result = ("verified", "x")
window._on_refresh_clicked()
assert window._phone_check_result is None
on_refresh.assert_called_once()
def test_check_phone_submits_future(self, mock_tk: MagicMock) -> None:
"""submit() always returns a Future synchronously.
Whether the trivial mock call resolves before or after the immediate
follow-up poll check is a genuine race (background thread vs. this
thread) — not something to assert either way. The poll-routing logic
itself is tested deterministically below with hand-built futures.
"""
fake_verifier = MagicMock()
fake_verifier._verify_phone_workout = MagicMock(return_value=("verified", "ok"))
window = _make_window(
mock_tk, _snapshot(), verifier_factory=lambda _log_file: fake_verifier
)
with patch("screen_locker.status_view.gather_status", return_value=_snapshot()):
window._on_check_phone_clicked()
assert window._phone_future is not None
def test_poll_routes_to_result_when_future_done(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
mock_future = MagicMock()
mock_future.done.return_value = True
mock_future.result.return_value = ("verified", "ok")
window._phone_future = mock_future
with patch.object(window, "_on_phone_check_result") as mock_handle:
window._poll_phone_check()
mock_handle.assert_called_once_with("verified", "ok")
def test_poll_waits_when_future_not_done(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
mock_future = MagicMock()
mock_future.done.return_value = False
window._phone_future = mock_future
with patch.object(window, "_on_phone_check_result") as mock_handle:
window._poll_phone_check()
mock_handle.assert_not_called()
window.root.after.assert_called_with(500, window._poll_phone_check)
def test_poll_waits_when_future_is_none(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
window._phone_future = None
with patch.object(window, "_on_phone_check_result") as mock_handle:
window._poll_phone_check()
mock_handle.assert_not_called()
def test_result_never_calls_save_workout_log(self, mock_tk: MagicMock) -> None:
"""A manual peek must never silently log a workout (see module docstring)."""
window = _make_window(mock_tk, _snapshot())
with patch(
"screen_locker.status_view.gather_status", return_value=_snapshot()
) as mock_gather:
window._on_phone_check_result("verified", "Workout verified!")
assert window._phone_check_result == ("verified", "Workout verified!")
mock_gather.assert_called_once()
class TestMakeBareVerifier:
def test_builds_locker_without_running_init(self, tmp_path: Path) -> None:
log_file = tmp_path / "workout_log.json"
verifier = _make_bare_verifier(log_file)
assert verifier.log_file == log_file
assert verifier.workout_data == {}
class TestComplianceStateWord:
def test_lock_when_fired(self) -> None:
snap = _snapshot(lock_explanation=_lock_explanation(fired=True))
assert _compliance_state_word(snap) == "lock"
def test_warn_when_not_fired_but_remaining(self) -> None:
snap = _snapshot(
lock_explanation=_lock_explanation(fired=False),
week=_week(remaining=2),
)
assert _compliance_state_word(snap) == "warn"
def test_ok_when_not_fired_and_minimum_met(self) -> None:
snap = _snapshot(
lock_explanation=_lock_explanation(fired=False),
week=_week(remaining=0),
)
assert _compliance_state_word(snap) == "ok"
class TestMain:
def test_summary_flag_prints_and_returns(
self, capsys: pytest.CaptureFixture[str]
) -> None:
with patch("screen_locker.status_view.gather_status", return_value=_snapshot()):
main(["--summary"])
out = capsys.readouterr().out
assert "workouts" in out
def test_state_flag_prints_and_returns(
self, capsys: pytest.CaptureFixture[str]
) -> None:
with patch(
"screen_locker.status_view.gather_status",
return_value=_snapshot(lock_explanation=_lock_explanation(fired=True)),
):
main(["--state"])
out = capsys.readouterr().out
assert out.strip() == "lock"
def test_no_flags_opens_window(self, mock_tk: MagicMock) -> None:
with patch("screen_locker.status_view.gather_status", return_value=_snapshot()):
main([])
mock_tk.Tk.assert_called_once()
mock_tk.Tk.return_value.mainloop.assert_called_once()
def test_no_flags_refresh_closure_regathers_and_rerenders(
self, mock_tk: MagicMock
) -> None:
"""Exercises main()'s inner refresh() closure passed as on_refresh."""
captured: dict[str, Callable[[], None]] = {}
class _CapturingWindow(StatusWindow):
def __init__(
self,
root: object,
snapshot: object,
*,
on_refresh: Callable[[], None],
**kwargs: object,
) -> None:
captured["on_refresh"] = on_refresh
super().__init__(root, snapshot, on_refresh=on_refresh, **kwargs)
with (
patch(
"screen_locker.status_view.gather_status", return_value=_snapshot()
) as mock_gather,
patch("screen_locker.status_view.StatusWindow", _CapturingWindow),
):
main([])
calls_before = mock_gather.call_count
captured["on_refresh"]()
assert mock_gather.call_count == calls_before + 1
class TestTemperatureSectionRendering:
def test_shows_checking_message_before_result(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
window._temp_result = None
window.render(_snapshot())
assert any("Checking Warsaw temperature" in t for t in _texts(mock_tk))
def test_shows_resolved_temperature(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
window._temp_result = _temp_check(temp_celsius=22.0)
window.render(_snapshot())
assert any("Warsaw: 22" in t for t in _texts(mock_tk))
def test_flags_would_trigger_heat_skip_when_hot(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
window._temp_result = _temp_check(temp_celsius=35.0)
window.render(_snapshot())
assert any("Would trigger heat-skip today." in t for t in _texts(mock_tk))
def test_does_not_flag_heat_skip_when_below_threshold(
self, mock_tk: MagicMock
) -> None:
window = _make_window(mock_tk, _snapshot())
window._temp_result = _temp_check(temp_celsius=22.0)
window.render(_snapshot())
assert not any("Would trigger heat-skip today." in t for t in _texts(mock_tk))
def test_shows_timeout_message(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
window._temp_result = _temp_check(temp_celsius=None, timed_out=True)
window.render(_snapshot())
assert any("timed out" in t for t in _texts(mock_tk))
def test_shows_failure_message_when_not_timed_out(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
window._temp_result = _temp_check(temp_celsius=None, timed_out=False)
window.render(_snapshot())
assert any("failed (network/API error)" in t for t in _texts(mock_tk))
class TestTemperatureCheckFlow:
def test_init_starts_temperature_future(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
assert window._temp_future is not None
def test_poll_routes_to_result_when_future_done(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
mock_future = MagicMock()
mock_future.done.return_value = True
mock_future.result.return_value = _temp_check(temp_celsius=25.0)
window._temp_future = mock_future
with patch.object(window, "_on_temperature_check_result") as mock_handle:
window._poll_temperature_check()
mock_handle.assert_called_once_with(mock_future.result.return_value)
def test_poll_waits_when_future_not_done(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
mock_future = MagicMock()
mock_future.done.return_value = False
window._temp_future = mock_future
with patch.object(window, "_on_temperature_check_result") as mock_handle:
window._poll_temperature_check()
mock_handle.assert_not_called()
window.root.after.assert_called_with(500, window._poll_temperature_check)
def test_poll_waits_when_future_is_none(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot())
window._temp_future = None
with patch.object(window, "_on_temperature_check_result") as mock_handle:
window._poll_temperature_check()
mock_handle.assert_not_called()
def test_result_rerenders_last_snapshot_without_gathering_from_disk(
self, mock_tk: MagicMock
) -> None:
"""The temperature reading is independent of on-disk workout state —
must not trigger a real ``gather_status()`` disk read."""
window = _make_window(mock_tk, _snapshot())
result = _temp_check(temp_celsius=19.0)
with patch("screen_locker.status_view.gather_status") as mock_gather:
window._on_temperature_check_result(result)
assert window._temp_result == result
mock_gather.assert_not_called()
def test_refresh_clears_result_and_restarts_check(self, mock_tk: MagicMock) -> None:
window = _make_window(mock_tk, _snapshot(), on_refresh=MagicMock())
window._temp_result = _temp_check(temp_celsius=30.0)
with patch.object(window, "_start_temperature_check") as mock_start:
window._on_refresh_clicked()
assert window._temp_result is None
mock_start.assert_called_once()