mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-11 20:53:55 +01:00
Krzysztof kuhy Rudnicki
e5bfdd9a9a
Every locker screen, the status window and the credit toast now show glyphs (screen_locker/_glyphs.py) and numbers, coloured by state. Sentences that carried a reason (verifier message, sync diagnosis, sick refusal, form rejection) go to the log at warning instead. New pre-commit hook text-free runs scripts/verify_text_free.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
223 lines
8.5 KiB
Python
223 lines
8.5 KiB
Python
"""Tests for status_view.py: phone-check flow, buttons, main() CLI entry point."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from screen_locker import _glyphs as g
|
|
from screen_locker._status_view_verify import PhoneCheckOutcome
|
|
from screen_locker._workout_credit import WorkoutCreditResult
|
|
from screen_locker.status_view import (
|
|
_make_bare_verifier,
|
|
)
|
|
from screen_locker.tests._status_view_helpers import (
|
|
_button_texts,
|
|
_make_window,
|
|
_snapshot,
|
|
_texts,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
|
|
class TestPhoneCheckResultRendering:
|
|
"""PhoneCheckResultRendering."""
|
|
|
|
def test_no_result_shows_nothing(self, mock_tk: MagicMock) -> None:
|
|
"""No result shows nothing."""
|
|
snap = _snapshot()
|
|
_make_window(mock_tk, snap)
|
|
assert not any(f"{g.RUN}{g.FAIL}" in t for t in _texts(mock_tk))
|
|
|
|
def test_verified_result_shown_in_green(self, mock_tk: MagicMock) -> None:
|
|
"""Verified result shown in green."""
|
|
window = _make_window(mock_tk, _snapshot())
|
|
window._phone_check_result = ("verified", "verified glyphs")
|
|
window.render(_snapshot())
|
|
calls = [
|
|
c
|
|
for c in mock_tk.Label.call_args_list
|
|
if c.kwargs.get("text") == "verified glyphs"
|
|
]
|
|
assert calls
|
|
assert calls[-1].kwargs.get("fg") == window._colors.palette.success
|
|
|
|
def test_non_verified_result_shown_in_orange(self, mock_tk: MagicMock) -> None:
|
|
"""Non verified result shown in orange."""
|
|
window = _make_window(mock_tk, _snapshot())
|
|
failed = f"{g.LIFT}{g.FAIL} {g.RUN}{g.FAIL}"
|
|
window._phone_check_result = ("no_phone", failed)
|
|
window.render(_snapshot())
|
|
calls = [
|
|
c for c in mock_tk.Label.call_args_list if c.kwargs.get("text") == failed
|
|
]
|
|
assert calls
|
|
assert calls[-1].kwargs.get("fg") == window._colors.palette.warning
|
|
|
|
|
|
class TestButtons:
|
|
"""Buttons."""
|
|
|
|
def test_renders_check_phone_refresh_close(
|
|
self, mock_tk: MagicMock, temp_log_file: Path
|
|
) -> None:
|
|
"""Renders check phone refresh close."""
|
|
_make_window(mock_tk, _snapshot(), log_file=temp_log_file)
|
|
assert _button_texts(mock_tk) == {g.PHONE, g.FORM, g.RETRY, g.CLOSE}
|
|
|
|
|
|
class TestRefreshAndCheckPhoneFlow:
|
|
"""RefreshAndCheckPhoneFlow."""
|
|
|
|
def test_refresh_clears_phone_result_and_calls_on_refresh(
|
|
self, mock_tk: MagicMock
|
|
) -> None:
|
|
"""Refresh clears phone result and calls on refresh."""
|
|
on_refresh = MagicMock()
|
|
window = _make_window(mock_tk, _snapshot(), on_refresh=on_refresh)
|
|
window._phone_check_result = ("verified", "x")
|
|
window._on_refresh_clicked()
|
|
assert window._phone_check_result is None
|
|
on_refresh.assert_called_once()
|
|
|
|
def test_check_phone_submits_future(self, mock_tk: MagicMock) -> None:
|
|
"""submit() always returns a Future synchronously.
|
|
|
|
Whether the trivial mock call resolves before or after the immediate
|
|
follow-up poll check is a genuine race (background thread vs. this
|
|
thread) — not something to assert either way. The poll-routing logic
|
|
itself is tested deterministically below with hand-built futures.
|
|
"""
|
|
fake_verifier = MagicMock()
|
|
fake_verifier._verify_phone_workout = MagicMock(return_value=("verified", "ok"))
|
|
window = _make_window(
|
|
mock_tk, _snapshot(), verifier_factory=lambda _log_file: fake_verifier
|
|
)
|
|
with patch("screen_locker.status_view.gather_status", return_value=_snapshot()):
|
|
window._on_check_phone_clicked()
|
|
assert window._phone_future is not None
|
|
|
|
def test_poll_waits_when_future_not_done(self, mock_tk: MagicMock) -> None:
|
|
"""Poll waits when future not done."""
|
|
window = _make_window(mock_tk, _snapshot())
|
|
mock_future = MagicMock()
|
|
mock_future.done.return_value = False
|
|
window._phone_future = mock_future
|
|
with patch.object(window, "_on_phone_check_result") as mock_handle:
|
|
window._poll_phone_check()
|
|
mock_handle.assert_not_called()
|
|
window.root.after.assert_called_with(500, window._poll_phone_check)
|
|
|
|
def test_poll_waits_when_future_is_none(self, mock_tk: MagicMock) -> None:
|
|
"""Poll waits when future is none."""
|
|
window = _make_window(mock_tk, _snapshot())
|
|
window._phone_future = None
|
|
with patch.object(window, "_on_phone_check_result") as mock_handle:
|
|
window._poll_phone_check()
|
|
mock_handle.assert_not_called()
|
|
|
|
def test_failed_check_shows_combined_message_and_rerenders(
|
|
self, mock_tk: MagicMock, caplog: pytest.LogCaptureFixture
|
|
) -> None:
|
|
"""Neither source verified → both fail glyphs, both reasons logged."""
|
|
window = _make_window(mock_tk, _snapshot())
|
|
with patch(
|
|
"screen_locker._status_view_verify.gather_status", return_value=_snapshot()
|
|
) as mock_gather:
|
|
window._on_phone_check_result(
|
|
PhoneCheckOutcome(None, "no_phone", "no lifts", "no run")
|
|
)
|
|
assert window._phone_check_result == (
|
|
"no_phone",
|
|
f"{g.LIFT}{g.FAIL} {g.RUN}{g.FAIL}",
|
|
)
|
|
warned = [r.getMessage() for r in caplog.records if r.levelname == "WARNING"]
|
|
assert any("no lifts" in m and "no run" in m for m in warned)
|
|
assert window._credit_message is None
|
|
mock_gather.assert_called_once()
|
|
|
|
def test_phone_verified_applies_credit_with_phone_message(
|
|
self, mock_tk: MagicMock, temp_log_file: Path
|
|
) -> None:
|
|
"""A verified StrongLifts result writes and credits using the phone message."""
|
|
fake_verifier = MagicMock()
|
|
fake_verifier._apply_workout_credit = MagicMock(
|
|
return_value=WorkoutCreditResult(
|
|
shutdown_adjusted=True,
|
|
extra_bonus_delta=0,
|
|
weekly_count=1,
|
|
already_counted_today=False,
|
|
)
|
|
)
|
|
window = _make_window(
|
|
mock_tk,
|
|
_snapshot(),
|
|
log_file=temp_log_file,
|
|
verifier_factory=lambda _log_file: fake_verifier,
|
|
)
|
|
with patch(
|
|
"screen_locker._status_view_verify.gather_status", return_value=_snapshot()
|
|
):
|
|
window._on_phone_check_result(
|
|
PhoneCheckOutcome("phone_verified", "verified", "StrongLifts ok", None)
|
|
)
|
|
assert fake_verifier.workout_data == {
|
|
"type": "phone_verified",
|
|
"source": "StrongLifts ok",
|
|
}
|
|
fake_verifier._apply_workout_credit.assert_called_once()
|
|
assert window._phone_check_result is None
|
|
message = window._credit_message
|
|
assert message is not None
|
|
assert message.splitlines() == [f"{g.LIFT} {g.OK}", f"{g.SHUTDOWN} +2h"]
|
|
|
|
def test_runnerup_verified_credits_using_runnerup_message(
|
|
self, mock_tk: MagicMock, temp_log_file: Path
|
|
) -> None:
|
|
"""A verified RunnerUp fallback credits using the RunnerUp message."""
|
|
fake_verifier = MagicMock()
|
|
fake_verifier._apply_workout_credit = MagicMock(
|
|
return_value=WorkoutCreditResult(
|
|
shutdown_adjusted=False,
|
|
extra_bonus_delta=0,
|
|
weekly_count=1,
|
|
already_counted_today=False,
|
|
)
|
|
)
|
|
window = _make_window(
|
|
mock_tk,
|
|
_snapshot(),
|
|
log_file=temp_log_file,
|
|
verifier_factory=lambda _log_file: fake_verifier,
|
|
)
|
|
with patch(
|
|
"screen_locker._status_view_verify.gather_status", return_value=_snapshot()
|
|
):
|
|
window._on_phone_check_result(
|
|
PhoneCheckOutcome(
|
|
"runnerup_verified", "verified", "no lifts", "RunnerUp 5.0 km"
|
|
)
|
|
)
|
|
assert fake_verifier.workout_data == {
|
|
"type": "runnerup_verified",
|
|
"source": "RunnerUp 5.0 km",
|
|
}
|
|
message = window._credit_message
|
|
assert message is not None
|
|
assert message == f"{g.RUN} {g.OK}"
|
|
|
|
|
|
class TestMakeBareVerifier:
|
|
"""MakeBareVerifier."""
|
|
|
|
def test_builds_locker_without_running_init(self, tmp_path: Path) -> None:
|
|
"""Builds locker without running init."""
|
|
log_file = tmp_path / "log.json"
|
|
verifier = _make_bare_verifier(log_file)
|
|
assert verifier.log_file == log_file
|
|
assert verifier.workout_data == {}
|