Krzysztof kuhy Rudnicki 87e625cc5f Make the phone's manual-workout budget agree with the PC, twice over ... The phone and PC each compute a nominally SHARED manual-workout budget over the same merged records, and disagreed on both halves of it. The cap: _constants.py has said 10 per 30 days since 298daf0; the Dart mirror was still 5, so between 5 and 9 the phone hard-blocked the form for a workout the PC would have accepted and credited. The stricter side wins, so this cost logged workouts rather than granting extra ones. The counting rule: count_in_window counts ENTRIES ("each logged manual workout consumes its own budget slot"), while countManualBudget built a Set of date strings and counted DAYS -- despite a docstring claiming it mirrored the PC. Three workouts on one day read 3/2 on the PC, over its 7-day cap, but 1/2 on the phone, which kept accepting. Both now report 3 for that input. Per-entry is the correct semantic because each entry separately earns weekly-count and shutdown credit, so each must separately cost budget. The wire fixture could never have caught either: the caps and the counting rule never travel on the wire. The comment claiming it was "the tripwire that catches drift" was wrong and is corrected. The real guard, TestCrossLanguageBudgetConstants, parses manual_workout.dart and compares it to the imported Python constants -- one test that fails on EITHER side's drift. Asserting a Python constant against a Python literal would have stayed green through 298daf0, which is the drift that actually happened. Also: the history volume chart summed targetWeight x targetSets x targetReps, so a session where every set failed plotted identically to one completed in full -- the line only moved when progression changed the target. It now sums weight x doneReps over the logged sets. On today's real session that is 2790 -> 1440 kg, because 5 sets of bench press were logged at 0 reps and were being counted at full credit. No targetWeight fallback per set: weight is non-nullable and always serialized, and substituting the target would overstate a set the user never did. design.md/dfesign_v2.md: record that the Crucial (progress lost on exit) and High (sound + vibration) items are done, that breaks are still per-set, and that the warmup fraction shipped as 4/5 -- neither the 2/3 nor the 3/4 the specs asked for, and 4/5 is what is wanted. Verified on the phone (release build, signed with the shared key, installed with adb install -r so the workout history survived); 907 Python and 313 Dart tests pass with the coverage bar green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A4y93ZSnk2w5LH3B12LHNc		2026-08-09 17:34:46 +02:00
..
exercise_result_test.dart	Add comprehensive test suite, backup service, and linting to workout app	2026-06-28 08:11:43 +02:00
exercise_test.dart	Add comprehensive test suite, backup service, and linting to workout app	2026-06-28 08:11:43 +02:00
manual_workout_test.dart	Make the phone's manual-workout budget agree with the PC, twice over	2026-08-09 17:34:46 +02:00
set_result_test.dart	Add comprehensive test suite, backup service, and linting to workout app	2026-06-28 08:11:43 +02:00
workout_plan_test.dart	Add comprehensive test suite, backup service, and linting to workout app	2026-06-28 08:11:43 +02:00
workout_session_test.dart	Add comprehensive test suite, backup service, and linting to workout app	2026-06-28 08:11:43 +02:00