mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-11 21:33:58 +01:00
Krzysztof kuhy Rudnicki
bdc405c8c9
Six new modules, all composed or re-exported so no caller changes:
_shutdown.py (384) -> _shutdown_sick_state.py SickDayStateMixin
_wake_alarm.py WakeAlarmMixin
_phone_verification.py (380)-> _adb_transport.py AdbTransportMixin
_http_workout_fetch.py HttpWorkoutFetchMixin
_status_data.py (370) -> _status_types.py the 7 dataclasses
_status_projection.py shutdown projection
+ format_summary_line
Moving a name means moving where it is *read*, so 30-odd mock patch targets
move with it. Most importantly conftest.py's autouse _block_real_network
fixture: ruff correctly dropped the now-unused `socket` import from
_phone_verification, which silently removed the guard's target and would have
let subnet probes reach the real network. It now blocks socket in both modules
that actually own the probes, and both targets are asserted to exist.
976 tests pass at 100% branch coverage; pylint 8.70 -> 8.71; `screen_lock
--status` renders the real week unchanged. File-length gate: 41 -> 35.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EveB813BQ8abAP68VSqZ5Y
229 lines
7.5 KiB
Python
229 lines
7.5 KiB
Python
"""Tests for sick-day state save/load and config restoration."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from screen_locker.tests.conftest import create_locker
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
class TestSaveSickDayState:
|
|
"""Tests for _save_sick_day_state method."""
|
|
|
|
def test_saves_state_successfully(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test saves state file with correct content."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
state_file = tmp_path / "state.json"
|
|
with patch(
|
|
"screen_locker._shutdown_sick_state.SICK_DAY_STATE_FILE",
|
|
state_file,
|
|
):
|
|
result = locker._save_sick_day_state("2026-03-21", 21, 20)
|
|
assert result is True
|
|
data = json.loads(state_file.read_text())
|
|
assert data["date"] == "2026-03-21"
|
|
assert data["original_mon_wed_hour"] == 21
|
|
assert data["original_thu_sun_hour"] == 20
|
|
|
|
def test_returns_false_on_oserror(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns False when write fails."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_path = MagicMock()
|
|
mock_path.open.side_effect = OSError("permission denied")
|
|
with patch(
|
|
"screen_locker._shutdown_sick_state.SICK_DAY_STATE_FILE",
|
|
mock_path,
|
|
):
|
|
result = locker._save_sick_day_state("2026-03-21", 21, 20)
|
|
assert result is False
|
|
|
|
|
|
class TestLoadSickDayState:
|
|
"""Tests for _load_sick_day_state method."""
|
|
|
|
def test_loads_valid_state(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test loads state with all fields present."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
state_file = tmp_path / "state.json"
|
|
state_file.write_text(
|
|
json.dumps(
|
|
{
|
|
"date": "2026-03-20",
|
|
"original_mon_wed_hour": 21,
|
|
"original_thu_sun_hour": 20,
|
|
}
|
|
)
|
|
)
|
|
with patch(
|
|
"screen_locker._shutdown_sick_state.SICK_DAY_STATE_FILE",
|
|
state_file,
|
|
):
|
|
result = locker._load_sick_day_state()
|
|
assert result == ("2026-03-20", 21, 20)
|
|
|
|
def test_returns_none_when_fields_missing(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns None when required fields are missing."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
state_file = tmp_path / "state.json"
|
|
state_file.write_text(json.dumps({"date": "2026-03-20"}))
|
|
with patch(
|
|
"screen_locker._shutdown_sick_state.SICK_DAY_STATE_FILE",
|
|
state_file,
|
|
):
|
|
result = locker._load_sick_day_state()
|
|
assert result is None
|
|
|
|
|
|
class TestWriteRestoredConfig:
|
|
"""Tests for _write_restored_config method."""
|
|
|
|
def test_restores_config_and_removes_state(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test restores config values and deletes state file."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
state_file = tmp_path / "state.json"
|
|
state_file.write_text("{}")
|
|
with (
|
|
patch.object(locker, "_read_shutdown_config", return_value=(20, 19, 8)),
|
|
patch.object(
|
|
locker, "_write_shutdown_config", return_value=True
|
|
) as mock_write,
|
|
patch(
|
|
"screen_locker._shutdown_sick_state.SICK_DAY_STATE_FILE",
|
|
state_file,
|
|
),
|
|
):
|
|
locker._write_restored_config(21, 20, "2026-03-20")
|
|
mock_write.assert_called_once_with(21, 20, 8, restore=True)
|
|
assert not state_file.exists()
|
|
|
|
def test_still_removes_state_when_config_read_fails(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test removes state file even when config read returns None."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
state_file = tmp_path / "state.json"
|
|
state_file.write_text("{}")
|
|
with (
|
|
patch.object(locker, "_read_shutdown_config", return_value=None),
|
|
patch(
|
|
"screen_locker._shutdown_sick_state.SICK_DAY_STATE_FILE",
|
|
state_file,
|
|
),
|
|
):
|
|
locker._write_restored_config(21, 20, "2026-03-20")
|
|
assert not state_file.exists()
|
|
|
|
|
|
class TestAdjustShutdownTimeBy:
|
|
"""Tests for _adjust_shutdown_time_by method (extra-workout bonus)."""
|
|
|
|
def test_adjusts_time_successfully(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Normal path: reads config, increments both hours, writes back."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
object.__setattr__(
|
|
locker, "_read_shutdown_config", MagicMock(return_value=(21, 21, 5))
|
|
)
|
|
object.__setattr__(
|
|
locker, "_write_shutdown_config", MagicMock(return_value=True)
|
|
)
|
|
assert locker._adjust_shutdown_time_by(1) is True
|
|
locker._write_shutdown_config.assert_called_once_with(22, 22, 5, restore=True)
|
|
|
|
def test_caps_hours_at_24(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Hours are capped at 24 (midnight-safe shutdown)."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
object.__setattr__(
|
|
locker, "_read_shutdown_config", MagicMock(return_value=(23, 23, 5))
|
|
)
|
|
object.__setattr__(
|
|
locker, "_write_shutdown_config", MagicMock(return_value=True)
|
|
)
|
|
locker._adjust_shutdown_time_by(2)
|
|
locker._write_shutdown_config.assert_called_once_with(24, 24, 5, restore=True)
|
|
|
|
def test_returns_false_when_config_is_none(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""_read_shutdown_config returns None → return False immediately."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
object.__setattr__(
|
|
locker, "_read_shutdown_config", MagicMock(return_value=None)
|
|
)
|
|
assert locker._adjust_shutdown_time_by(1) is False
|
|
|
|
def test_returns_false_on_oserror(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""OSError during read is caught; returns False."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
object.__setattr__(
|
|
locker,
|
|
"_read_shutdown_config",
|
|
MagicMock(side_effect=OSError("permission denied")),
|
|
)
|
|
assert locker._adjust_shutdown_time_by(1) is False
|
|
|
|
def test_returns_false_on_value_error(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""ValueError during processing is caught; returns False."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
object.__setattr__(
|
|
locker,
|
|
"_read_shutdown_config",
|
|
MagicMock(side_effect=ValueError("bad value")),
|
|
)
|
|
assert locker._adjust_shutdown_time_by(1) is False
|