mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-11 17:13:59 +01:00
Krzysztof kuhy Rudnicki
60d8c3361b
The manual-workout evidence form (shown on the lock screen and the status window via the shared ManualWorkoutDialogMixin) was a cramped, narrow centered column of tiny inputs with large empty margins, and included two fields that make no sense to fill from a locked PC. - Remove the vestigial "Google Maps link" (location_maps_link) and "Screenshot path" (proof_screenshot_path) fields from the form, the ManualWorkoutDraft dataclass, and build_entry(). Both were written to workout_log.json but never read by any code. The now-empty "Evidence" section is gone too. reservation_phone is kept. - Lay the form out as a two-column grid that fills ~90% of the screen (the fullscreen container was shrink-wrapping to its widest child) with larger labels/inputs; reflection boxes span full width. Activity-specific fields now sit directly under their section header. - Extract the low-level field/grid builders into a new ManualWorkoutFormWidgetsMixin (_manual_workout_widgets.py) so the dialog module stays under the 400-line cap; the dialog mixin inherits it, so the host classes need no change. Tests updated for the removed fields and the pack->grid sport swap; added a unit test for the grid cursor's odd-row bump. Full suite green at 100%. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PM3auNTifaVgcXWDizZrjH
230 lines
8.9 KiB
Python
230 lines
8.9 KiB
Python
"""Tests for the manual-workout evidence-form dialog mixin."""
|
|
# pylint: disable=protected-access
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from screen_locker import _manual_workout
|
|
from screen_locker.tests.conftest import create_locker
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
class TestShowManualWorkoutForm:
|
|
"""Tests for _show_manual_workout_form."""
|
|
|
|
def test_renders_form_when_budget_available(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch.object(_manual_workout, "is_budget_exhausted", return_value=False):
|
|
locker._show_manual_workout_form()
|
|
button_texts = {c.kwargs.get("text") for c in mock_tk.Button.call_args_list}
|
|
assert "SUBMIT" in button_texts
|
|
assert "BACK" in button_texts
|
|
|
|
def test_shows_exhausted_message_and_hides_submit(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch.object(_manual_workout, "is_budget_exhausted", return_value=True):
|
|
locker._show_manual_workout_form()
|
|
button_texts = {c.kwargs.get("text") for c in mock_tk.Button.call_args_list}
|
|
assert "BACK" in button_texts
|
|
assert "SUBMIT" not in button_texts
|
|
text_calls = [c.kwargs.get("text", "") for c in mock_tk.Label.call_args_list]
|
|
assert any("exhausted" in t for t in text_calls)
|
|
|
|
|
|
class TestSportToggle:
|
|
"""Tests for _on_mw_sport_changed and _current_mw_sport."""
|
|
|
|
def test_selecting_other_shows_other_frame(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker._mw_tt_frame = MagicMock()
|
|
locker._mw_other_frame = MagicMock()
|
|
locker._mw_sport_var = MagicMock()
|
|
locker._on_mw_sport_changed("Other")
|
|
locker._mw_tt_frame.grid_remove.assert_called_once()
|
|
locker._mw_other_frame.grid.assert_called_once_with()
|
|
|
|
def test_selecting_table_tennis_shows_tt_frame(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker._mw_tt_frame = MagicMock()
|
|
locker._mw_other_frame = MagicMock()
|
|
locker._mw_sport_var = MagicMock()
|
|
locker._on_mw_sport_changed("Table tennis")
|
|
locker._mw_other_frame.grid_remove.assert_called_once()
|
|
locker._mw_tt_frame.grid.assert_called_once_with()
|
|
|
|
def test_unknown_label_defaults_to_table_tennis(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker._mw_tt_frame = MagicMock()
|
|
locker._mw_other_frame = MagicMock()
|
|
locker._mw_sport_var = MagicMock()
|
|
locker._mw_sport_var.get.return_value = "not a real label"
|
|
assert locker._current_mw_sport() == _manual_workout.SPORT_TABLE_TENNIS
|
|
|
|
|
|
class TestGridCursor:
|
|
"""Tests for the two-column grid cursor helper _mw_next_full_row."""
|
|
|
|
def test_full_row_from_even_cursor_advances_by_a_row(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker._mw_grid_counters = {}
|
|
parent = object()
|
|
# Fresh (even) cursor: reserves row 0, then row 1 on the next call.
|
|
assert locker._mw_next_full_row(parent) == 0
|
|
assert locker._mw_next_full_row(parent) == 1
|
|
|
|
def test_full_row_from_odd_cursor_bumps_to_next_row(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
parent = object()
|
|
# An odd cursor (a half-width cell already placed on the left) must be
|
|
# bumped to a fresh row before a full-width item is placed.
|
|
locker._mw_grid_counters = {id(parent): 1}
|
|
assert locker._mw_next_full_row(parent) == 1
|
|
|
|
|
|
class TestSubmitManualWorkoutForm:
|
|
"""Tests for _submit_manual_workout_form."""
|
|
|
|
def _setup_locker(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
tmp_path: Path,
|
|
*,
|
|
sport_label: str = "Table tennis",
|
|
fields: dict[str, object] | None = None,
|
|
) -> object:
|
|
defaults: dict[str, object] = {
|
|
"start_time": "12:00",
|
|
"end_time": "14:00",
|
|
"location_name": "Osrodek Solec",
|
|
"transport_method": "bike",
|
|
"cost": "60 PLN",
|
|
"reservation_phone": "",
|
|
"techniques_practiced": "",
|
|
"warm_up_minutes": "",
|
|
"pain_or_injury": "none",
|
|
"racket": "pro spin",
|
|
"balls": "nittaku",
|
|
"activity_type_other": "squash",
|
|
"went_well": "x" * 30,
|
|
"to_improve": "y" * 30,
|
|
"overall_feeling": "z" * 30,
|
|
"activity_details": "q" * 45,
|
|
}
|
|
if fields:
|
|
defaults.update(fields)
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker._mw_sport_var = MagicMock()
|
|
locker._mw_sport_var.get.return_value = sport_label
|
|
locker._mw_rpe_var = MagicMock()
|
|
locker._mw_rpe_var.get.return_value = 6
|
|
|
|
locker._mw_vars = {}
|
|
for key in (
|
|
"start_time",
|
|
"end_time",
|
|
"location_name",
|
|
"transport_method",
|
|
"cost",
|
|
"reservation_phone",
|
|
"techniques_practiced",
|
|
"warm_up_minutes",
|
|
"pain_or_injury",
|
|
"racket",
|
|
"balls",
|
|
"activity_type_other",
|
|
"equipment",
|
|
):
|
|
var = MagicMock()
|
|
var.get.return_value = defaults.get(key, "")
|
|
locker._mw_vars[key] = var
|
|
|
|
locker._mw_int_vars = {}
|
|
for key, default_val in (
|
|
("matches_won", 1),
|
|
("matches_lost", 4),
|
|
("sets_won", 2),
|
|
("sets_lost", 9),
|
|
):
|
|
var = MagicMock()
|
|
var.get.return_value = defaults.get(key, default_val)
|
|
locker._mw_int_vars[key] = var
|
|
|
|
locker._mw_text_widgets = {}
|
|
for key in ("went_well", "to_improve", "overall_feeling", "activity_details"):
|
|
widget = MagicMock()
|
|
widget.get.return_value = defaults[key]
|
|
locker._mw_text_widgets[key] = widget
|
|
|
|
locker._mw_error_label = MagicMock()
|
|
object.__setattr__(locker, "_on_manual_workout_saved", MagicMock())
|
|
return locker
|
|
|
|
def test_valid_table_tennis_calls_saved_hook(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = self._setup_locker(mock_tk, tmp_path, sport_label="Table tennis")
|
|
locker._submit_manual_workout_form()
|
|
locker._on_manual_workout_saved.assert_called_once()
|
|
entry = locker._on_manual_workout_saved.call_args.args[0]
|
|
assert entry["sport"] == "table_tennis"
|
|
assert entry["matches_lost"] == 4
|
|
locker._mw_error_label.config.assert_not_called()
|
|
|
|
def test_valid_other_sport_calls_saved_hook(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = self._setup_locker(mock_tk, tmp_path, sport_label="Other")
|
|
locker._submit_manual_workout_form()
|
|
locker._on_manual_workout_saved.assert_called_once()
|
|
entry = locker._on_manual_workout_saved.call_args.args[0]
|
|
assert entry["sport"] == "other"
|
|
assert entry["activity_type"] == "squash"
|
|
|
|
def test_validation_failure_shows_error_and_skips_hook(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = self._setup_locker(mock_tk, tmp_path, fields={"location_name": " "})
|
|
locker._submit_manual_workout_form()
|
|
locker._mw_error_label.config.assert_called_once()
|
|
locker._on_manual_workout_saved.assert_not_called()
|
|
|
|
def test_rpe_value_error_treated_as_invalid(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = self._setup_locker(mock_tk, tmp_path)
|
|
locker._mw_rpe_var.get.side_effect = ValueError("bad")
|
|
locker._submit_manual_workout_form()
|
|
locker._mw_error_label.config.assert_called_once()
|
|
locker._on_manual_workout_saved.assert_not_called()
|
|
|
|
def test_int_field_value_error_treated_as_zero(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
locker = self._setup_locker(mock_tk, tmp_path)
|
|
locker._mw_int_vars["matches_won"].get.side_effect = ValueError("bad")
|
|
locker._mw_int_vars["matches_lost"].get.return_value = 0
|
|
locker._submit_manual_workout_form()
|
|
# matches_won=0 (from the ValueError fallback) and matches_lost=0
|
|
# -> "zero matches played" validation error.
|
|
locker._mw_error_label.config.assert_called_once()
|
|
locker._on_manual_workout_saved.assert_not_called()
|