mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-11 18:53:55 +01:00
Krzysztof kuhy Rudnicki
298daf028d
Synced manual workouts never earned shutdown/debt credit (only weekly count), which silently missed pushing shutdown time for a same-day workout logged on the phone. Manual workouts now go through the same credit logic as any other workout type, count individually toward the weekly total and rate budget (no more once-per-day collapse), and stack same-day shutdown bonuses like verified workouts. Also bumps the weekly minimum from 4 to 5 and doubles the monthly manual-workout budget to 10. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
295 lines
11 KiB
Python
295 lines
11 KiB
Python
"""Tests for the read-only Tkinter status window's rendering (StatusWindow.render)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from screen_locker._compliance_state import AutoUpgradeOpportunity
|
|
from screen_locker._status_view_verify import (
|
|
PhoneCheckOutcome,
|
|
_backfill_week_and_apply_bonus,
|
|
_verify_phone_then_runnerup,
|
|
)
|
|
from screen_locker.tests._status_view_helpers import (
|
|
_day,
|
|
_lock_explanation,
|
|
_make_window,
|
|
_shutdown,
|
|
_sick_budget,
|
|
_snapshot,
|
|
_texts,
|
|
_week,
|
|
)
|
|
|
|
|
|
class TestSectionToday:
|
|
def test_counted_shows_checkmark_and_entry(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(
|
|
today=_day(
|
|
entry_types=("phone_verified",),
|
|
counted=True,
|
|
day_count=1,
|
|
source="gym",
|
|
)
|
|
)
|
|
_make_window(mock_tk, snap)
|
|
texts = _texts(mock_tk)
|
|
assert any("✓" in t and "phone_verified" in t for t in texts)
|
|
assert any(t == "gym" for t in texts)
|
|
|
|
def test_sick_day_shows_sick_mark(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(today=_day(entry_types=(), is_sick_day=True))
|
|
_make_window(mock_tk, snap)
|
|
assert any("😷" in t and "sick day" in t for t in _texts(mock_tk))
|
|
|
|
def test_no_entry_shows_dash(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(today=_day(entry_types=(), is_sick_day=False))
|
|
_make_window(mock_tk, snap)
|
|
assert any("no entry yet" in t for t in _texts(mock_tk))
|
|
|
|
def test_empty_source_adds_no_extra_line(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(
|
|
today=_day(
|
|
entry_types=("phone_verified",),
|
|
counted=True,
|
|
day_count=1,
|
|
source="",
|
|
)
|
|
)
|
|
_make_window(mock_tk, snap)
|
|
# Only the main "Today (...)" line, no second call for an empty source.
|
|
today_related = [t for t in _texts(mock_tk) if "Today" in t]
|
|
assert len(today_related) == 1
|
|
|
|
|
|
class TestSectionWeek:
|
|
def test_shows_remaining_message_when_under_minimum(
|
|
self, mock_tk: MagicMock
|
|
) -> None:
|
|
snap = _snapshot(week=_week(counted_count=2, remaining=2, extra=0))
|
|
_make_window(mock_tk, snap)
|
|
assert any("Need 2 more this week." in t for t in _texts(mock_tk))
|
|
|
|
def test_shows_extra_message_when_over_minimum(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(week=_week(counted_count=5, remaining=0, extra=1))
|
|
_make_window(mock_tk, snap)
|
|
assert any("above the weekly minimum" in t for t in _texts(mock_tk))
|
|
|
|
def test_shows_neither_message_at_exact_minimum(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(week=_week(counted_count=4, remaining=0, extra=0))
|
|
_make_window(mock_tk, snap)
|
|
texts = _texts(mock_tk)
|
|
assert not any("Need" in t and "more this week" in t for t in texts)
|
|
assert not any("above the weekly minimum" in t for t in texts)
|
|
|
|
def test_renders_a_line_per_day(self, mock_tk: MagicMock) -> None:
|
|
days = (
|
|
_day(
|
|
date="2024-01-01",
|
|
label="Mon Jan 01",
|
|
counted=True,
|
|
day_count=1,
|
|
entry_types=("phone_verified",),
|
|
),
|
|
_day(date="2024-01-02", label="Tue Jan 02", is_sick_day=True),
|
|
_day(date="2024-01-03", label="Wed Jan 03"),
|
|
)
|
|
snap = _snapshot(week=_week(days=days))
|
|
_make_window(mock_tk, snap)
|
|
texts = _texts(mock_tk)
|
|
assert any("Mon Jan 01" in t and "✓" in t for t in texts)
|
|
assert any("Tue Jan 02" in t and "😷" in t for t in texts)
|
|
assert any("Wed Jan 03" in t and "no entry" in t for t in texts)
|
|
|
|
|
|
class TestSectionLockExplanation:
|
|
def test_fired_with_auto_upgrade_and_heat_skip_pending(
|
|
self, mock_tk: MagicMock
|
|
) -> None:
|
|
snap = _snapshot(
|
|
lock_explanation=_lock_explanation(
|
|
fired=True,
|
|
reason="Full lock.",
|
|
auto_upgrade=AutoUpgradeOpportunity(
|
|
would_attempt=True, via="sick_day", reason="will try phone"
|
|
),
|
|
heat_skip_evaluated=False,
|
|
)
|
|
)
|
|
_make_window(mock_tk, snap)
|
|
texts = _texts(mock_tk)
|
|
assert any(t == "Full lock." for t in texts)
|
|
assert any("Pending auto-upgrade: will try phone" in t for t in texts)
|
|
|
|
def test_not_fired_no_auto_upgrade(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(
|
|
lock_explanation=_lock_explanation(fired=False, reason="Skipped.")
|
|
)
|
|
_make_window(mock_tk, snap)
|
|
texts = _texts(mock_tk)
|
|
assert any(t == "Skipped." for t in texts)
|
|
assert not any("Pending auto-upgrade" in t for t in texts)
|
|
|
|
def test_temperature_section_renders_regardless_of_heat_skip_evaluated(
|
|
self, mock_tk: MagicMock
|
|
) -> None:
|
|
"""The live temperature section is unconditional — see
|
|
``TestTemperatureSectionRendering`` for its actual content states."""
|
|
snap = _snapshot(
|
|
lock_explanation=_lock_explanation(fired=True, heat_skip_evaluated=True)
|
|
)
|
|
_make_window(mock_tk, snap)
|
|
assert any("Warsaw Temperature" in t for t in _texts(mock_tk))
|
|
|
|
|
|
class TestSectionSickBudget:
|
|
def test_exhausted_uses_warning_color(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(sick_budget=_sick_budget(used_7d=1, exhausted=True))
|
|
_make_window(mock_tk, snap)
|
|
calls = [
|
|
c
|
|
for c in mock_tk.Label.call_args_list
|
|
if "week" in c.kwargs.get("text", "")
|
|
]
|
|
assert any(c.kwargs.get("fg") == "#ff4444" for c in calls)
|
|
|
|
def test_not_exhausted_uses_normal_color(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(sick_budget=_sick_budget(used_7d=0, exhausted=False))
|
|
_make_window(mock_tk, snap)
|
|
calls = [
|
|
c
|
|
for c in mock_tk.Label.call_args_list
|
|
if "week" in c.kwargs.get("text", "")
|
|
]
|
|
assert any(c.kwargs.get("fg") == "#cccccc" for c in calls)
|
|
|
|
|
|
class TestSectionShutdown:
|
|
def test_tonight_present_shows_live_config(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(shutdown=_shutdown(tonight=(22, 23, 5)))
|
|
_make_window(mock_tk, snap)
|
|
assert any("22:00" in t and "23:00" in t for t in _texts(mock_tk))
|
|
|
|
def test_tonight_absent_shows_unavailable_message(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot(shutdown=_shutdown(tonight=None))
|
|
_make_window(mock_tk, snap)
|
|
assert any("Live shutdown config unavailable." in t for t in _texts(mock_tk))
|
|
|
|
def test_shows_rest_of_week_and_next_week_preview(self, mock_tk: MagicMock) -> None:
|
|
snap = _snapshot()
|
|
_make_window(mock_tk, snap)
|
|
texts = _texts(mock_tk)
|
|
assert any("Rest of week:" in t for t in texts)
|
|
assert any("Next week (speculative):" in t for t in texts)
|
|
|
|
|
|
class TestVerifyPhoneThenRunnerup:
|
|
"""The "Check Phone" worker: StrongLifts first, then RunnerUp as fallback."""
|
|
|
|
def test_stronglifts_verified_short_circuits(self) -> None:
|
|
"""A verified phone workout wins and RunnerUp is never consulted."""
|
|
verifier = MagicMock()
|
|
verifier._verify_phone_workout.return_value = ("verified", "5x5 done")
|
|
|
|
result = _verify_phone_then_runnerup(verifier)
|
|
|
|
assert result == PhoneCheckOutcome(
|
|
"phone_verified", "verified", "5x5 done", None
|
|
)
|
|
verifier._verify_runnerup_workout.assert_not_called()
|
|
|
|
def test_falls_back_to_runnerup_when_phone_not_verified(self) -> None:
|
|
"""StrongLifts miss → a verified run credits as runnerup_verified."""
|
|
verifier = MagicMock()
|
|
verifier._verify_phone_workout.return_value = ("not_verified", "stale")
|
|
verifier._verify_runnerup_workout.return_value = ("verified", "9.8 km")
|
|
|
|
result = _verify_phone_then_runnerup(verifier)
|
|
|
|
assert result == PhoneCheckOutcome(
|
|
"runnerup_verified", "verified", "stale", "9.8 km"
|
|
)
|
|
|
|
def test_neither_source_verified_nor_backfilled(self) -> None:
|
|
"""Neither verified today, nothing to backfill → no credit, no fill message."""
|
|
verifier = MagicMock()
|
|
verifier._verify_phone_workout.return_value = ("not_verified", "stale")
|
|
verifier._verify_runnerup_workout.return_value = ("too_short", "3 km")
|
|
verifier._scan_and_fill_week_runnerup.return_value = 0
|
|
verifier._try_fill_stronglifts_for_week.return_value = 0
|
|
|
|
with patch(
|
|
"screen_locker._status_view_verify.count_weekly_workouts",
|
|
return_value=2,
|
|
):
|
|
result = _verify_phone_then_runnerup(verifier)
|
|
|
|
assert result == PhoneCheckOutcome(None, "too_short", "stale", "3 km", None)
|
|
|
|
def test_falls_back_to_week_scan_backfill(self) -> None:
|
|
"""Neither verified today, but the week-scan finds something → fill message."""
|
|
verifier = MagicMock()
|
|
verifier._verify_phone_workout.return_value = ("not_verified", "stale")
|
|
verifier._verify_runnerup_workout.return_value = ("not_verified", "no run")
|
|
verifier._scan_and_fill_week_runnerup.return_value = 1
|
|
verifier._try_fill_stronglifts_for_week.return_value = 0
|
|
|
|
with patch(
|
|
"screen_locker._status_view_verify.count_weekly_workouts",
|
|
side_effect=[2, 3],
|
|
):
|
|
result = _verify_phone_then_runnerup(verifier)
|
|
|
|
assert result.credited_type is None
|
|
assert (
|
|
result.week_fill_message == "Auto-filled 1 workout from earlier this week."
|
|
)
|
|
verifier._adjust_shutdown_time_by.assert_not_called()
|
|
|
|
|
|
class TestBackfillWeekAndApplyBonus:
|
|
"""The week-scan fallback: backfill unlogged days, apply the earned bonus."""
|
|
|
|
def test_nothing_filled_returns_none(self) -> None:
|
|
verifier = MagicMock()
|
|
verifier._scan_and_fill_week_runnerup.return_value = 0
|
|
verifier._try_fill_stronglifts_for_week.return_value = 0
|
|
|
|
with patch(
|
|
"screen_locker._status_view_verify.count_weekly_workouts",
|
|
return_value=2,
|
|
):
|
|
assert _backfill_week_and_apply_bonus(verifier) is None
|
|
verifier._adjust_shutdown_time_by.assert_not_called()
|
|
|
|
def test_fill_at_or_below_minimum_earns_no_bonus(self) -> None:
|
|
"""Filling up to (not past) the weekly minimum earns no shutdown push."""
|
|
verifier = MagicMock()
|
|
verifier._scan_and_fill_week_runnerup.return_value = 1
|
|
verifier._try_fill_stronglifts_for_week.return_value = 0
|
|
|
|
with patch(
|
|
"screen_locker._status_view_verify.count_weekly_workouts",
|
|
side_effect=[3, 4],
|
|
):
|
|
message = _backfill_week_and_apply_bonus(verifier)
|
|
|
|
assert message == "Auto-filled 1 workout from earlier this week."
|
|
verifier._adjust_shutdown_time_by.assert_not_called()
|
|
|
|
def test_fill_past_minimum_applies_bonus(self) -> None:
|
|
verifier = MagicMock()
|
|
verifier._scan_and_fill_week_runnerup.return_value = 1
|
|
verifier._try_fill_stronglifts_for_week.return_value = 1
|
|
|
|
with patch(
|
|
"screen_locker._status_view_verify.count_weekly_workouts",
|
|
side_effect=[4, 7],
|
|
):
|
|
message = _backfill_week_and_apply_bonus(verifier)
|
|
|
|
assert message == (
|
|
"Auto-filled 2 workouts from earlier this week. +2h shutdown time."
|
|
)
|
|
verifier._adjust_shutdown_time_by.assert_called_once_with(2)
|