screen-locker/stronglift_replacement/workout_app/lib
Krzysztof kuhy Rudnicki 78db299086 Split workout_screen.dart (633) into seven part files
The largest lib/ file on the 250-line list and the one never attempted. It
has no private widget classes to lift out (pattern A did not apply), so the
cut is by responsibility:

  workout_screen.dart        250  state fields, lifecycle, setState methods
  workout_screen_session.dart 182  save/restore, break maths, threshold write
  workout_screen_finish.dart  110  the write-everything finish step
  workout_screen_body.dart    105  exercise list + break banner
  workout_screen_dialogs.dart  73  finish/reset confirmations
  workout_screen_appbar.dart   68  clock + Reset/Finish actions
  workout_screen_breaks.dart   67  rest timers, threshold edits

Two constraints shaped it. `setState` is `@protected` and unreachable from an
extension, so methods that call it either stay in the class or split into a
class-side wrapper plus a setState-free body — that is why `_finishWorkout`
keeps only its three lines and delegates to `_persistFinishedWorkout`. The
breaks extension needs real state writes, so the class exposes one named
`_applyBreakState` shim rather than scattering the seam.

The extensions are named `_Foo`, not `Foo`: extending the private
`_WorkoutScreenState` from a public extension trips
`library_private_types_in_public_api`.

Coverage caught one real regression mid-way. Restructuring the threshold
update as a map-returning helper with an `if (s == null) return` guard added
a branch no test exercises and dropped the gate to 2753/2754. Rewritten as
`_writeThresholds`, mutating in place with the original `if (s != null)`
shape, so the extraction stays a pure move.

dart analyze clean; 402 tests pass with a byte-identical test-name set
(captured via --reporter json and diffed, since a count alone cannot tell a
lost test from a duplicated one); flutter coverage back to 100%.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EveB813BQ8abAP68VSqZ5Y
2026-08-15 22:04:11 +02:00
..
models Split manual_workout.dart (410) into four part files 2026-08-15 21:41:59 +02:00
screens Split workout_screen.dart (633) into seven part files 2026-08-15 22:04:11 +02:00
services Split progression_sync_service.dart (433) into four 2026-08-15 21:44:43 +02:00
ui workout_app: warm-tint the unified-design-system palette 2026-07-22 21:08:45 +02:00
widgets Split the private widgets out of three more Dart screens 2026-08-15 21:39:57 +02:00
main.dart Carry progression through Firebase, and stop demanding storage permission 2026-08-10 16:54:21 +02:00