mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-10 20:27:13 +01:00
Krzysztof kuhy Rudnicki
ec0946f64e
`requires-python` and the CI pin already said 3.14, but ruff, mypy and pylint were still grading against 3.10 -- three tools judging an interpreter nothing runs any more, and ruff withholding the pyupgrade fixes that only become safe at the newer target. `pin_ci_python.py` rewrites exactly these three knobs. What the stale target was hiding: 118 sites on `datetime.timezone.utc` instead of `datetime.UTC` (UP017), two classes still written with `Generic[...]` rather than PEP 695 syntax, and ruff's stable formatter applying PEP 758 -- `except (A, B):` becomes `except A, B:`. That last one makes the source 3.14-only at the syntax level, which is what `requires-python = ">=3.14"` already promised; kuhy chose it deliberately over holding ruff a release back (2026-08-29). The PEP 695 fix needed a hand: ruff rewrote `class WidgetGroup(Generic[_W])` to `class WidgetGroup[W: tk.Misc]` but left the body annotated with the module-level `_W`, a *different* type variable -- mypy caught it as "a function returning TypeVar should receive at least one argument containing the same TypeVar". Renamed the body to the new parameter, gave `FrameGroup.__init__` the concrete `list[tk.Frame]` it always wrapped, and deleted the two now-dead module-level TypeVars. ruff, ruff-format, mypy --strict and both pylint passes clean at the new target. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SfnJmxxsZ534AKk16rC2Gr
238 lines
8.9 KiB
Python
238 lines
8.9 KiB
Python
"""Tests for _extra_benefits module (streak, shutdown bonus, EB extension)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import UTC, datetime
|
|
import json
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from screen_locker._extra_benefits import (
|
|
_load_state,
|
|
_save_state,
|
|
current_streak,
|
|
process_week_transition,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
class TestLoadState:
|
|
"""Tests for _load_state helper."""
|
|
|
|
def test_returns_empty_dict_when_file_missing(self, tmp_path: Path) -> None:
|
|
"""Non-existent file returns empty dict (line 29 — the missing-file branch)."""
|
|
result = _load_state(tmp_path / "nonexistent.json")
|
|
assert result == {}
|
|
|
|
def test_returns_parsed_state_when_file_valid(self, tmp_path: Path) -> None:
|
|
"""Valid JSON file returns the parsed dict."""
|
|
f = tmp_path / "state.json"
|
|
f.write_text(json.dumps({"weekly_shutdown_bonus_hours": {"2026-W01": 3}}))
|
|
assert _load_state(f) == {"weekly_shutdown_bonus_hours": {"2026-W01": 3}}
|
|
|
|
def test_returns_empty_on_oserror(self) -> None:
|
|
"""OSError during read is caught and returns empty dict (lines 33-34)."""
|
|
mock_path = MagicMock()
|
|
mock_path.exists.return_value = True
|
|
mock_path.open.side_effect = OSError("read fail")
|
|
assert _load_state(mock_path) == {}
|
|
|
|
def test_returns_empty_on_invalid_json(self, tmp_path: Path) -> None:
|
|
"""Corrupt JSON is caught and returns empty dict (lines 33-34)."""
|
|
f = tmp_path / "state.json"
|
|
f.write_text("not-json{{{")
|
|
assert _load_state(f) == {}
|
|
|
|
|
|
class TestSaveState:
|
|
"""Tests for _save_state helper."""
|
|
|
|
def test_saves_state_to_file(self, tmp_path: Path) -> None:
|
|
"""Valid path writes JSON content (lines 39-41)."""
|
|
f = tmp_path / "state.json"
|
|
_save_state(f, {"weekly_shutdown_bonus_hours": {"2026-W01": 2}})
|
|
assert json.loads(f.read_text())["weekly_shutdown_bonus_hours"] == {
|
|
"2026-W01": 2
|
|
}
|
|
|
|
def test_logs_warning_on_oserror(self) -> None:
|
|
"""OSError during write is caught as warning, does not raise (lines 42-43)."""
|
|
mock_path = MagicMock()
|
|
mock_path.open.side_effect = OSError("write fail")
|
|
_save_state(mock_path, {"key": "val"}) # must not raise
|
|
|
|
|
|
class TestProcessWeekTransition:
|
|
"""Tests for process_week_transition."""
|
|
|
|
_PAST_WEEK = "2020-W01"
|
|
|
|
def test_returns_empty_when_already_processed_this_week(
|
|
self, tmp_path: Path
|
|
) -> None:
|
|
"""Early return when ISO week already processed (line 63)."""
|
|
now = datetime.now(tz=UTC).astimezone()
|
|
year, week, _ = now.isocalendar()
|
|
f = tmp_path / "state.json"
|
|
f.write_text(json.dumps({"last_processed_iso_week": f"{year}-W{week:02d}"}))
|
|
assert process_week_transition(tmp_path / "log.json", f) == []
|
|
|
|
@staticmethod
|
|
def _current_week_str() -> str:
|
|
now = datetime.now(tz=UTC).astimezone()
|
|
year, week, _ = now.isocalendar()
|
|
return f"{year}-W{week:02d}"
|
|
|
|
def test_awards_bonus_hours_for_5plus_workouts(self, tmp_path: Path) -> None:
|
|
"""5+ workouts in previous week: streak += 1, bonus hours += extra."""
|
|
f = tmp_path / "state.json"
|
|
f.write_text(
|
|
json.dumps(
|
|
{
|
|
"last_processed_iso_week": self._PAST_WEEK,
|
|
"consecutive_5plus_weeks": 0,
|
|
"weekly_shutdown_bonus_hours": {},
|
|
"extended_early_bird_iso_weeks": [],
|
|
}
|
|
)
|
|
)
|
|
with patch(
|
|
"screen_locker._extra_benefits.count_weekly_workouts", return_value=6
|
|
):
|
|
rewards = process_week_transition(tmp_path / "log.json", f)
|
|
|
|
assert len(rewards) >= 1
|
|
assert "+2h shutdown bonus" in rewards[0]
|
|
state = json.loads(f.read_text())
|
|
assert state["consecutive_5plus_weeks"] == 1
|
|
assert state["weekly_shutdown_bonus_hours"][self._current_week_str()] == 2
|
|
|
|
def test_awards_milestone_bonus_at_4_week_streak(self, tmp_path: Path) -> None:
|
|
"""Streak reaches multiple of 4: +1h extra shutdown bonus."""
|
|
f = tmp_path / "state.json"
|
|
f.write_text(
|
|
json.dumps(
|
|
{
|
|
"last_processed_iso_week": self._PAST_WEEK,
|
|
"consecutive_5plus_weeks": 3,
|
|
"weekly_shutdown_bonus_hours": {},
|
|
"extended_early_bird_iso_weeks": [],
|
|
}
|
|
)
|
|
)
|
|
with patch(
|
|
"screen_locker._extra_benefits.count_weekly_workouts", return_value=5
|
|
):
|
|
rewards = process_week_transition(tmp_path / "log.json", f)
|
|
|
|
assert any("milestone" in r for r in rewards)
|
|
state = json.loads(f.read_text())
|
|
assert state["consecutive_5plus_weeks"] == 4
|
|
assert state["weekly_shutdown_bonus_hours"][self._current_week_str()] == 2
|
|
|
|
def test_marks_current_week_as_extended_early_bird(self, tmp_path: Path) -> None:
|
|
"""5+ workouts mark current ISO week as extended EB (line 91-92)."""
|
|
f = tmp_path / "state.json"
|
|
f.write_text(
|
|
json.dumps(
|
|
{
|
|
"last_processed_iso_week": self._PAST_WEEK,
|
|
"extended_early_bird_iso_weeks": [],
|
|
}
|
|
)
|
|
)
|
|
with patch(
|
|
"screen_locker._extra_benefits.count_weekly_workouts", return_value=5
|
|
):
|
|
process_week_transition(tmp_path / "log.json", f)
|
|
|
|
now = datetime.now(tz=UTC).astimezone()
|
|
year, week, _ = now.isocalendar()
|
|
state = json.loads(f.read_text())
|
|
assert f"{year}-W{week:02d}" in state["extended_early_bird_iso_weeks"]
|
|
|
|
def test_resets_streak_for_fewer_than_5_workouts(self, tmp_path: Path) -> None:
|
|
"""< 5 workouts in previous week resets streak and logs message (lines 100-103)."""
|
|
f = tmp_path / "state.json"
|
|
f.write_text(
|
|
json.dumps(
|
|
{
|
|
"last_processed_iso_week": self._PAST_WEEK,
|
|
"consecutive_5plus_weeks": 2,
|
|
}
|
|
)
|
|
)
|
|
with patch(
|
|
"screen_locker._extra_benefits.count_weekly_workouts", return_value=3
|
|
):
|
|
rewards = process_week_transition(tmp_path / "log.json", f)
|
|
|
|
assert any("Streak reset" in r for r in rewards)
|
|
assert json.loads(f.read_text())["consecutive_5plus_weeks"] == 0
|
|
|
|
def test_no_reset_message_when_streak_was_zero(self, tmp_path: Path) -> None:
|
|
"""Zero streak + < 5 workouts: no reset message (line 101 branch False)."""
|
|
f = tmp_path / "state.json"
|
|
f.write_text(
|
|
json.dumps(
|
|
{
|
|
"last_processed_iso_week": self._PAST_WEEK,
|
|
"consecutive_5plus_weeks": 0,
|
|
}
|
|
)
|
|
)
|
|
with patch(
|
|
"screen_locker._extra_benefits.count_weekly_workouts", return_value=2
|
|
):
|
|
rewards = process_week_transition(tmp_path / "log.json", f)
|
|
|
|
assert not any("Streak reset" in r for r in rewards)
|
|
|
|
def test_fresh_state_file_processed_on_new_week(self, tmp_path: Path) -> None:
|
|
"""No state file: _load_state returns {} and transition runs (covers line 29)."""
|
|
f = tmp_path / "nonexistent.json"
|
|
with patch(
|
|
"screen_locker._extra_benefits.count_weekly_workouts", return_value=4
|
|
):
|
|
process_week_transition(tmp_path / "log.json", f)
|
|
|
|
assert f.exists() # state file created
|
|
|
|
def test_duplicate_eb_week_not_added_twice(self, tmp_path: Path) -> None:
|
|
"""Current week already in EB list: not added again (line 91 branch False)."""
|
|
now = datetime.now(tz=UTC).astimezone()
|
|
year, week, _ = now.isocalendar()
|
|
current_week = f"{year}-W{week:02d}"
|
|
f = tmp_path / "state.json"
|
|
f.write_text(
|
|
json.dumps(
|
|
{
|
|
"last_processed_iso_week": self._PAST_WEEK,
|
|
"extended_early_bird_iso_weeks": [current_week],
|
|
}
|
|
)
|
|
)
|
|
with patch(
|
|
"screen_locker._extra_benefits.count_weekly_workouts", return_value=5
|
|
):
|
|
process_week_transition(tmp_path / "log.json", f)
|
|
|
|
state = json.loads(f.read_text())
|
|
assert state["extended_early_bird_iso_weeks"].count(current_week) == 1
|
|
|
|
|
|
class TestCurrentStreak:
|
|
"""Tests for current_streak."""
|
|
|
|
def test_returns_zero_when_file_missing(self, tmp_path: Path) -> None:
|
|
"""Missing file falls through _load_state → default 0."""
|
|
assert current_streak(tmp_path / "nonexistent.json") == 0
|
|
|
|
def test_returns_stored_streak(self, tmp_path: Path) -> None:
|
|
"""Stored streak value is returned correctly."""
|
|
f = tmp_path / "state.json"
|
|
f.write_text(json.dumps({"consecutive_5plus_weeks": 5}))
|
|
assert current_streak(f) == 5
|