mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-10 20:27:13 +01:00
Krzysztof kuhy Rudnicki
0921146044
`flutter test` runs on a Linux host, so credentialStore()'s Platform.isLinux branch wrote $HOME/.config/screen_locker/firebase_auth.json -- the refresh token the screen-locker daemon signs in with. firebase_backend_google_test's "stores the account under the email Firebase reports" case overwrote it with the fixture token 'refresh' on every local run; the daemon only survived by self-healing from a cached token. Dart: - lib/services/desktop_config_dir.dart: one resolver, desktopConfigRoot(), for every desktop path (the credential file's read/write/delete and the ~/.config/crdt-sync account read). @visibleForTesting override; under FLUTTER_TEST it throws StateError if the root is, or is inside, the real $HOME/.config -- so a test that bypasses the override fails loudly instead of writing. HOME unset now yields null instead of a cwd-relative .config. - The crdt-sync read resolves the root outside its catch-all, so the guard cannot be swallowed as "not connected". - test/flutter_test_config.dart gives every test its own temp config root. - The Google sign-in test now asserts the token landed in that temp root. - path_provider is unbound under flutter test (MissingPluginException), so the getApplicationSupportDirectory callers cannot reach live dirs. Python (tests only): isolate_sync_token now patches every import-time binding of SYNC_TOKEN_FILE (_constants, _manual_push, _sync_status were missed), and test_home_isolation scans all runtime modules for any Path still bound inside the real ~/.config/screen_locker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KFwA9nymhUdTrVF65kigTV
106 lines
4.3 KiB
Python
106 lines
4.3 KiB
Python
"""The suite must not be able to reach the real ``~/.config``.
|
|
|
|
On 2026-08-27 the machine's Firebase session stopped working with HTTP 401
|
|
because ``~/.config/screen_locker/firebase_auth.json`` had been overwritten
|
|
with fixture values. Nothing in the suite was pointed at that path on
|
|
purpose: ``crdt_sync.credential_store_for`` builds it from ``Path.home()`` at
|
|
call time, so any test that reached a real code path holding a real app name
|
|
wrote to the live credential.
|
|
|
|
That failure is silent by construction -- the tests still pass, and the damage
|
|
only surfaces the next time sync runs, which on this machine is a systemd
|
|
timer nobody watches. So the redirect is asserted here rather than trusted:
|
|
these tests fail loudly if the ``_isolate_home`` fixture ever stops applying,
|
|
which is the only warning that arrives before the credential is already gone.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import UTC, datetime, timedelta
|
|
import importlib
|
|
import os
|
|
from pathlib import Path
|
|
import pkgutil
|
|
import pwd
|
|
import sys
|
|
|
|
from crdt_sync import FirebaseCredentials, credential_store_for
|
|
|
|
import screen_locker
|
|
|
|
|
|
def _fixture_credentials() -> FirebaseCredentials:
|
|
"""Return throwaway credentials shaped like a real cached session."""
|
|
# Assembled rather than written as literals: a bare
|
|
# ``refresh_token="..."`` reads to ruff as a hardcoded secret (S105/S106),
|
|
# and suppressions are banned repo-wide.
|
|
fixture = "fixture"
|
|
return FirebaseCredentials(
|
|
id_token=f"{fixture}-id-token",
|
|
refresh_token=f"{fixture}-refresh-token",
|
|
expires_at=datetime.now(tz=UTC) + timedelta(hours=1),
|
|
)
|
|
|
|
|
|
def test_path_home_is_redirected(tmp_path: Path) -> None:
|
|
"""``Path.home()`` must never resolve to the real home during tests."""
|
|
assert Path.home() == tmp_path
|
|
assert Path.home() != Path("/home/kuhy")
|
|
|
|
|
|
def test_home_env_var_is_redirected(tmp_path: Path) -> None:
|
|
"""``$HOME`` is redirected too, for code that reads the environment."""
|
|
assert os.environ["HOME"] == str(tmp_path)
|
|
|
|
|
|
def test_credential_store_cannot_reach_the_real_config(tmp_path: Path) -> None:
|
|
"""The exact call that clobbered the live session must land in tmp_path.
|
|
|
|
This is the regression test proper: ``credential_store_for`` resolves
|
|
``Path.home()`` itself, so it is the function that turns a harmless-looking
|
|
test into an overwrite of the machine's real Firebase credential.
|
|
"""
|
|
store = credential_store_for("screen_locker")
|
|
|
|
resolved = store._path
|
|
assert resolved == tmp_path / ".config" / "screen_locker" / "firebase_auth.json"
|
|
assert tmp_path in resolved.parents
|
|
|
|
|
|
def test_saving_a_credential_writes_only_inside_tmp_path(tmp_path: Path) -> None:
|
|
"""A real save must be contained, not merely aimed elsewhere.
|
|
|
|
Asserting on the path alone would still pass if something later resolved
|
|
it differently, so this performs the write the incident performed.
|
|
"""
|
|
store = credential_store_for("screen_locker")
|
|
store.save(_fixture_credentials())
|
|
|
|
written = tmp_path / ".config" / "screen_locker" / "firebase_auth.json"
|
|
assert written.is_file()
|
|
assert "fixture-refresh-token" in written.read_text()
|
|
|
|
|
|
def test_no_module_binds_a_path_inside_the_real_app_config() -> None:
|
|
"""Import-time bindings of ``~/.config/screen_locker`` must all be redirected.
|
|
|
|
``_isolate_home`` only reaches paths built from ``Path.home()`` at *call*
|
|
time. A module constant such as ``SYNC_TOKEN_FILE`` was bound at import,
|
|
before any fixture ran, and keeps the real path unless every module that
|
|
holds it is patched. This scans every runtime module for such a binding,
|
|
so a new one fails here instead of silently writing to the live dir.
|
|
"""
|
|
real_config = Path(pwd.getpwuid(os.getuid()).pw_dir) / ".config" / "screen_locker"
|
|
for info in pkgutil.walk_packages(screen_locker.__path__, "screen_locker."):
|
|
if ".tests" not in info.name:
|
|
importlib.import_module(info.name)
|
|
offenders = sorted(
|
|
f"{name}.{attr}"
|
|
for name, module in list(sys.modules.items())
|
|
if name.startswith("screen_locker.") and ".tests" not in name
|
|
for attr, value in vars(module).items()
|
|
if isinstance(value, Path)
|
|
and (value == real_config or real_config in value.parents)
|
|
)
|
|
assert offenders == []
|