mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-13 19:10:55 +01:00
Krzysztof kuhy Rudnicki
79879263ba
The workout log stored ONE workout per calendar day, so a second same-day
workout was silently dropped and could never earn credit.
Multiple workouts per day:
- workout_log.json: {date: entry} -> {date: [entry, ...]}. Legacy entries are
wrapped on read (_log_io.load_workout_log) so their HMACs stay valid — no
re-signing; every write normalizes the file, migrating it progressively.
- New write chokepoint (_log_mixin.write_signed_entry) APPENDS and dedups by a
stable workout_id, returning RecordResult so callers can tell a new workout
from a duplicate. Re-verifying the same workout is a no-op.
- count_weekly_workouts is anti-gaming: each VERIFIED workout counts
individually; self-reported manual entries count at most once per day. Four
real workouts in one day satisfy the week; four manual entries count as one.
- Reward: the day's first counted workout gets the base +2h; an additional
same-day VERIFIED workout gets +1h; an additional manual gets nothing. The
old "+1h when weekly_count > 4" gate is replaced — weekly volume is the
banked bonus's job and shouldn't be paid twice.
- Fixed: the unlock screen labelled the +1h "#{weekly_count - 4}", which can
render negative under the new rule. Removed the dead runnerup_manual type.
- Flutter: the manual budget counts distinct DAYS, matching the PC.
PC->phone sync (it had never worked once):
- push_pc_manuals pushed from a side-store written at log-time, so anything
logged before that feature existed could never publish. _manual_push now
derives the crdt log directly from workout_log.json — the single source of
truth — covering manual AND verified runs. The record id is the workout's own
workout_id (derived for legacy entries to match the phone's format) and the
HLC comes from the entry's own timestamp, so a re-push is byte-identical and
the repo never churns.
- The phone reads every kind (readMergedWorkoutPayloads) and lists the PC's
workouts under "SYNCED FROM PC". The manual budget still sees manual-only, so
a verified run can't consume a self-report slot.
- Settings claimed "Connected." whenever a token STRING existed. It now
verifies against the API on open, so a revoked token reports 401 instead of
showing a green lie.
Never fail silently:
- 30 swallowed exceptions across 19 files now log WARNING with the concrete
cause AND consequence — plus the token guards in _workout_sync that returned
[] in total silence, the exact bug that hid the dead sync for weeks.
- New pre-commit hook (scripts/check_silent_failures.py) fails any except that
neither re-raises nor logs loudly. ruff's S110 only catches `except: pass`;
the real pattern here was `except: log.info(); return []`. Documented in
CLAUDE.md.
Verified on real data: the Jul 13 run (pulled from its actual TCX over ADB) now
counts alongside that day's manual squash, and all three workouts are published
to kuhyx/syncs.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fv8ULVt3Q67GwCFbM7doHB
|
||
|---|---|---|
| .. | ||
| __init__.py | ||
| _status_view_helpers.py | ||
| conftest.py | ||
| test_adb_and_phone.py | ||
| test_compliance_state_part2.py | ||
| test_compliance_state.py | ||
| test_early_bird_part2.py | ||
| test_early_bird.py | ||
| test_extra_benefits.py | ||
| test_heat_skip.py | ||
| test_init_and_log_part2.py | ||
| test_init_and_log.py | ||
| test_log_io.py | ||
| test_log_mixin_chokepoint.py | ||
| test_manual_push.py | ||
| test_manual_sync.py | ||
| test_manual_workout_dialog.py | ||
| test_manual_workout_features.py | ||
| test_manual_workout_status_view.py | ||
| test_manual_workout.py | ||
| test_mcp.py | ||
| test_phone_check_unlock_part2.py | ||
| test_phone_check_unlock_part3.py | ||
| test_phone_verification_part2.py | ||
| test_phone_verification_part3.py | ||
| test_phone_verification_part4.py | ||
| test_runnerup_verification_part1.py | ||
| test_runnerup_verification_part2.py | ||
| test_runnerup_verification_part3.py | ||
| test_runnerup_verification_part4.py | ||
| test_runnerup_verification_part5.py | ||
| test_scheduled_skip.py | ||
| test_screen_lock_coverage_part1.py | ||
| test_screen_lock_coverage_part2.py | ||
| test_shutdown_base.py | ||
| test_shutdown_part2.py | ||
| test_shutdown_part3.py | ||
| test_shutdown_part4.py | ||
| test_sick_features_part2.py | ||
| test_sick_features.py | ||
| test_sick_tracker.py | ||
| test_status_data.py | ||
| test_status_part2.py | ||
| test_status_view_part2.py | ||
| test_status_view.py | ||
| test_status.py | ||
| test_sync_fixtures.py | ||
| test_temperature.py | ||
| test_time_check.py | ||
| test_ui_and_timers_part2.py | ||
| test_ui_and_timers.py | ||
| test_ui_flows_part2.py | ||
| test_verify_workout.py | ||
| test_vt_switching.py | ||
| test_wake_shutdown.py | ||
| test_wake_skip.py | ||
| test_wake_state.py | ||
| test_weekly_check.py | ||
| test_weekly_logic_part2.py | ||
| test_weekly_logic.py | ||
| test_workout_sync.py | ||