Krzysztof kuhy Rudnicki c0aae7d05b Make the lock overlay's sport selector usable, and focus its form fields ... The manual-workout sport selector was a `tk.OptionMenu`, and while the screen was locked it could not be changed. A posted Tk menu is a separate override-redirect toplevel that takes the Tk grab for itself, and gatelock's 1s recovery tick attacks it from both sides: `_surfaces.enforce()` lifts the lock surface over the menu, and `_reassert_grab()` read the grab sitting on the menu as "the grab was lost" and yanked it back. The menu opened on click and died within a second. On 2026-07-26 that forced an hour-long walk to be logged through the table-tennis form, with the reason typed into `racket`. Radio buttons instead. They are ordinary children of the surface, so they lift with it and live inside the root's grab tree -- neither mechanism can reach them. That is a structural guarantee, not a tuned workaround; the alternative, teaching gatelock to skip its lift while a popup is posted, would open a window where something could cover the lock. They are also the first version of this control styled from the shared palette, where the OptionMenu was default grey on the dark overlay. Nothing on a lock surface may open a popup, so two halves enforce it. The static half walks each module's AST for popup-creating names -- AST rather than a source regex because the modules explain this bug in prose that names the very widgets being banned. Its module list is derived ("imports tkinter", minus a short reasoned exemption list) rather than hardcoded, so a new lock screen is in scope the day it is written; a hardcoded list drafted today would already have missed `_sick_dialog`. The behavioural half is `scripts/verify_lock_popup_safety.py`: it builds the real form with real Tk, replays both hostile behaviours for five ticks, and re-runs the original failure so the mechanism stays demonstrated rather than described. It re-execs itself under Xvfb -- a global grab on the developer's own session would freeze it -- and a CI job runs it, because the pytest suite replaces the whole `tk` module and so cannot host it. Separately, no field ever took keyboard focus. Under a global grab that means typing goes nowhere with no other window on screen to reveal why. The manual-workout and sick-justification forms now each name their own first field via a `focus=` flag; `on_focus_ready` genuinely has nothing to focus (it fires before those screens exist) and its docstring now says that instead of claiming the lock window has no typed input at all. `scripts/fix_2026_07_26_sport.py` re-files that walk as sport "other", rebuilt through the form's own draft/validate/build path so it carries exactly the writer's key set, and re-signed. `start_time` and the date are untouched so `workout_id` stays stable and the phone converges instead of gaining a duplicate. Kept as the audit trail for the edit; the walk's details come from the entry and `--details`, so nothing personal lands in a tracked file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>		2026-07-26 15:08:08 +02:00
..
pre-commit.yml	Install Flutter in pre-commit CI so flutter-analyze can run	2026-07-11 17:23:42 +02:00
python-tests.yml	Make the lock overlay's sport selector usable, and focus its form fields	2026-07-26 15:08:08 +02:00