mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-15 08:30:58 +01:00
Krzysztof kuhy Rudnicki
e5db25468d
Some checks are pending
pre-commit / pre-commit (push) Waiting to run
Tests / test (3.10) (push) Waiting to run
Tests / test (3.11) (push) Waiting to run
Tests / test (3.12) (push) Waiting to run
Tests / lock-popup-safety (push) Waiting to run
release-apk / release (APK) (push) Waiting to run
The screen locker stopped locking on 2026-08-04 and nobody could tell. Not a
logic bug: every predicate worked the whole time. systemd logged
timers.target: Found ordering cycle: early-bird-workout-check.timer/start
after graphical-session.target/start after basic.target/start after
timers.target/start - after early-bird-workout-check.timer
timers.target: Job early-bird-workout-check.timer/start deleted to break
ordering cycle starting with timers.target/start
and left the timer disabled. A timer that is WantedBy=timers.target must not be
ordered After= a target that itself comes after timers.target; systemd resolves
that loop by deleting the job, which is an absence, and absences page nobody.
That timer is the ONLY thing that closes the early-bird window. Each morning a
run inside the window banked early_bird_pending.json, logged "will re-check at
08:30", and exited 0. The re-check never came, so the marker stood all day,
every day, for thirteen days.
It stayed invisible because logging.basicConfig was called only in the
--sync-only branch, never for --production -- the mode systemd actually runs.
Journal proof: zero INFO lines from workout-locker.service since June. Every
early exit logged at INFO into a logger with no handler. Meanwhile the healthy
15-minute sync kept the system looking alive.
The 2026-08-15 Python split is NOT implicated: it was pure code motion, and
basicConfig already sat in that branch before it.
Fixes:
* Drop the After= that closes the cycle; Persistent=true so a machine asleep at
08:30 still re-checks after resume.
* Add workout-locker.timer (*:00,30). The service is WantedBy=
graphical-session.target, i.e. one decision per login, so the 08-16 -> 08-17
day and ISO-week rollover inside one long session was never re-evaluated.
* arm.sh: install units, enable timers, verify -- one command, because
re-arming was a four-command sequence that was easy to half-do, and
`systemctl enable` returns 0 while systemd deletes the timer job.
* check_enforcement_armed.py asks systemd what it actually scheduled (enabled
AND has a next trigger) and fails loudly otherwise. Wired as ExecStartPost on
workout-sync.service, so a disarmed locker marks that unit failed every 15
minutes instead of scrolling past. install_systemd.sh now fails on it too.
Logging (the reason this went unnoticed, so treated as a defect in its own
right):
* basicConfig for every mode, never one branch.
* Every enforcement-abandoning exit records a decision instead of an invisible
INFO: one greppable line -- DECISION lock=no reason=early_bird_window_active
weekly=0/5 -- at WARNING, since per CLAUDE.md an INFO explanation of a
non-action is a silent failure with extra steps. The enforced case is logged
too: "no line at all" was the outage's whole signature.
* A durable JSONL trail outside the repo (~/.local/share/screen_locker/), so
"when did this last actually enforce?" survives journal rotation. --status
and --sync-only record lock=n/a; "did not decide" must never look like
"decided not to lock".
* check_silent_failures.py now also catches sys.exit(0) that explains nothing.
Verified both directions: it flags 3/3 exits in the pre-fix _auto_upgrade.py
and passes the repo clean.
Sync noise: four records replayed as WARNINGs every cycle (~384/day), which is
how the actionable lines got tuned out. manual_workout:2026-08-15 is an empty
stub ({date, kind, type}) -- no workout to recover, and that day's credit was
already counted under a different sync_record_id, so no credit was ever lost.
The three "collided" records are dedup working. Both now report at info; a
WARNING from this logger again means something real. 4 -> 0 per cycle.
Verified on the live system: the periodic timer fired at 16:45 and the journal
shows `DECISION lock=no reason=scheduled_skip_day weekly=0/5` -- the line that
did not exist for thirteen days. Both timers report enabled and scheduled, and
no ordering cycle recurs. Today is a scheduled skip so the machine was not
locked mid-session; enforcement resumes tomorrow 08:30. 1007 tests, 100%
coverage, all hooks green.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F2b6ZjBcdrkSYnMujx4mWd
|
||
|---|---|---|
| .. | ||
| tests | ||
| __init__.py | ||
| _adb_transport.py | ||
| _auto_upgrade.py | ||
| _cli.py | ||
| _compliance_predicates.py | ||
| _compliance_state.py | ||
| _compliance_trace.py | ||
| _constants.py | ||
| _decision_log.py | ||
| _device.py | ||
| _early_bird.py | ||
| _extra_benefits.py | ||
| _heat_skip.py | ||
| _http_workout_fetch.py | ||
| _log_io.py | ||
| _log_mixin.py | ||
| _manual_push.py | ||
| _manual_sync.py | ||
| _manual_workout_dialog.py | ||
| _manual_workout_sport_fields.py | ||
| _manual_workout_types.py | ||
| _manual_workout_widgets.py | ||
| _manual_workout.py | ||
| _mcp.py | ||
| _phone_verification.py | ||
| _runnerup_backfill.py | ||
| _runnerup_db.py | ||
| _runnerup_tcx.py | ||
| _runnerup_verification.py | ||
| _shutdown_base.py | ||
| _shutdown_sick_state.py | ||
| _shutdown.py | ||
| _sick_budget.py | ||
| _sick_commitment.py | ||
| _sick_dialog.py | ||
| _sick_tracker.py | ||
| _startup_checks.py | ||
| _status_data.py | ||
| _status_projection.py | ||
| _status_sections.py | ||
| _status_types.py | ||
| _status_view_verify.py | ||
| _status.py | ||
| _surface_group.py | ||
| _sync_client.py | ||
| _sync_mixin.py | ||
| _sync_records.py | ||
| _sync_retry.py | ||
| _sync_status.py | ||
| _temperature_status_mixin.py | ||
| _temperature.py | ||
| _time_check.py | ||
| _ui_flows_lockout.py | ||
| _ui_flows_relaxed.py | ||
| _ui_flows_sick.py | ||
| _ui_flows.py | ||
| _ui_form_fields.py | ||
| _ui_widgets.py | ||
| _unlock_view.py | ||
| _wake_alarm.py | ||
| _wake_state.py | ||
| _weekly_check.py | ||
| _window_setup.py | ||
| _workout_credit.py | ||
| _workout_sync.py | ||
| adjust_shutdown_schedule.sh | ||
| screen_lock.py | ||
| status_view.py | ||