mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-10 20:27:13 +01:00
Krzysztof kuhy Rudnicki
600d0fd084
The lock now paints one container per live output instead of one window on the primary, and claims the screen through an Arbiter at RANK_SCREEN_LOCKER so the wake alarm can outrank it. The fan-out happens at the widget factory, not the render loop. Painting a screen here is not a pure function -- the ~20 clear_container() flows record workouts, credit weeks and branch on state while they paint -- so re-running a flow per surface would double those side effects. Instead `_label`, `_button_row` and friends build N copies and return a group that mirrors later configure calls to all of them, and a flow body still runs once. Frame groups nest, so `_button(button_row, ...)` reads exactly as it did. The degenerate case carries as much weight as the general one: the status window, the post-sick-day verify window and the relaxed-day prompt have no lock and no surfaces, and share this same factory. They get a group of exactly one frame and behave as they always did. Text boxes are the one thing that cannot be shared. Entries fan out over a single StringVar, but tk.Text has no such variable, so the sick-day description genuinely diverges per monitor; TextGroup.get() returns whichever copy was actually typed into, preserving "answer on any monitor". Tests: the suite hung rather than failed on first run, which is the trap gatelock's own conftest documents -- screen_locker patches its own `tk`, but LockWindow builds Toplevels through gatelock's, and real tkinter over a MagicMock root recurses without bound. `_gatelock_fixtures` closes that and redirects the runtime dir so no test can stand a production locker down. Every other test runs single-output, where fan-out is unobservable, so test_surface_fanout runs on two outputs; each assertion was checked by cropping the group loops to the primary and confirming it goes red. 874 tests, 100% branch coverage, pre-commit clean, no lint suppressions.
195 lines
6.2 KiB
Python
195 lines
6.2 KiB
Python
"""Tests for UI transitions, timer logic, and sick day screens."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock
|
|
|
|
from screen_locker.tests.conftest import create_locker
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
class TestUITransitions:
|
|
"""Tests for UI state transitions."""
|
|
|
|
def test_clear_container(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test clear_container destroys all child widgets."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
|
|
# Set up mock children
|
|
mock_child1 = MagicMock()
|
|
mock_child2 = MagicMock()
|
|
locker.container.first.winfo_children.return_value = [
|
|
mock_child1,
|
|
mock_child2,
|
|
]
|
|
|
|
locker.clear_container()
|
|
|
|
mock_child1.destroy.assert_called_once()
|
|
mock_child2.destroy.assert_called_once()
|
|
|
|
def test_unlock_screen_saves_and_schedules_close(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test unlock_screen saves log and schedules close."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = tmp_path / "workout_log.json"
|
|
locker.workout_data = {"type": "phone_verified"}
|
|
|
|
locker.unlock_screen()
|
|
|
|
# Check that after() was called to schedule close
|
|
locker.root.after.assert_called()
|
|
|
|
def test_lockout_starts_countdown(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test lockout initializes countdown timer."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
|
|
locker.lockout()
|
|
|
|
# lockout() sets remaining_time to lockout_time (10 in demo mode)
|
|
# then calls update_lockout_countdown() which decrements it by 1
|
|
assert locker.remaining_time == 9 # 10 - 1 after first update
|
|
|
|
def test_close_destroys_root_and_exits(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test close destroys root window and exits."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
|
|
locker.close()
|
|
|
|
locker.root.destroy.assert_called_once()
|
|
mock_sys_exit.assert_called_with(0)
|
|
|
|
|
|
class TestTimerLogic:
|
|
"""Tests for timer countdown logic."""
|
|
|
|
def test_update_lockout_countdown_decrements(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test countdown decrements remaining time."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.remaining_time = 5
|
|
locker.countdown_label = MagicMock()
|
|
|
|
locker.update_lockout_countdown()
|
|
|
|
assert locker.remaining_time == 4
|
|
locker.root.after.assert_called_with(1000, locker.update_lockout_countdown)
|
|
|
|
def test_update_lockout_countdown_at_zero(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test countdown at zero restarts phone check."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.remaining_time = 0
|
|
locker.countdown_label = MagicMock()
|
|
object.__setattr__(locker, "_start_phone_check", MagicMock())
|
|
|
|
locker.update_lockout_countdown()
|
|
|
|
locker._start_phone_check.assert_called_once()
|
|
|
|
|
|
class TestAskIfSick:
|
|
"""Tests for ask_if_sick method."""
|
|
|
|
def test_ask_if_sick_invokes_justification_dialog(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
"""ask_if_sick now delegates to the structured justification dialog."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
object.__setattr__(locker, "_show_sick_justification", MagicMock())
|
|
locker.ask_if_sick()
|
|
locker._show_sick_justification.assert_called_once_with()
|
|
|
|
|
|
class TestGetSickDayStatus:
|
|
"""Tests for _get_sick_day_status method."""
|
|
|
|
def test_already_adjusted_today(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
"""Test status when sick mode already used today."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
object.__setattr__(
|
|
locker, "_sick_mode_used_today", MagicMock(return_value=True)
|
|
)
|
|
text, color = locker._get_sick_day_status()
|
|
assert "already adjusted" in text
|
|
assert color == locker._colors.warning
|
|
|
|
def test_adjustment_success(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
"""Test status when shutdown time adjusted successfully."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
object.__setattr__(
|
|
locker, "_sick_mode_used_today", MagicMock(return_value=False)
|
|
)
|
|
object.__setattr__(
|
|
locker, "_adjust_shutdown_time_earlier", MagicMock(return_value=True)
|
|
)
|
|
text, color = locker._get_sick_day_status()
|
|
assert "earlier" in text
|
|
assert color == locker._colors.success
|
|
|
|
def test_adjustment_failure(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
"""Test status when adjustment fails."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
object.__setattr__(
|
|
locker, "_sick_mode_used_today", MagicMock(return_value=False)
|
|
)
|
|
object.__setattr__(
|
|
locker, "_adjust_shutdown_time_earlier", MagicMock(return_value=False)
|
|
)
|
|
text, color = locker._get_sick_day_status()
|
|
assert "Could not adjust" in text
|
|
assert color == locker._colors.danger
|
|
|
|
|
|
class TestShowRetryAndSick:
|
|
"""Tests for _show_retry_and_sick method."""
|
|
|
|
def test_displays_buttons(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
"""Test _show_retry_and_sick shows retry and sick buttons."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
object.__setattr__(locker, "clear_container", MagicMock())
|
|
|
|
locker._show_retry_and_sick("Test message")
|
|
|
|
locker.clear_container.assert_called_once()
|
|
mock_tk.Label.assert_called()
|
|
mock_tk.Button.assert_called()
|