mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-10 20:27:13 +01:00
Krzysztof kuhy Rudnicki
ec0946f64e
`requires-python` and the CI pin already said 3.14, but ruff, mypy and pylint were still grading against 3.10 -- three tools judging an interpreter nothing runs any more, and ruff withholding the pyupgrade fixes that only become safe at the newer target. `pin_ci_python.py` rewrites exactly these three knobs. What the stale target was hiding: 118 sites on `datetime.timezone.utc` instead of `datetime.UTC` (UP017), two classes still written with `Generic[...]` rather than PEP 695 syntax, and ruff's stable formatter applying PEP 758 -- `except (A, B):` becomes `except A, B:`. That last one makes the source 3.14-only at the syntax level, which is what `requires-python = ">=3.14"` already promised; kuhy chose it deliberately over holding ruff a release back (2026-08-29). The PEP 695 fix needed a hand: ruff rewrote `class WidgetGroup(Generic[_W])` to `class WidgetGroup[W: tk.Misc]` but left the body annotated with the module-level `_W`, a *different* type variable -- mypy caught it as "a function returning TypeVar should receive at least one argument containing the same TypeVar". Renamed the body to the new parameter, gave `FrameGroup.__init__` the concrete `list[tk.Frame]` it always wrapped, and deleted the two now-dead module-level TypeVars. ruff, ruff-format, mypy --strict and both pylint passes clean at the new target. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SfnJmxxsZ534AKk16rC2Gr
247 lines
9.1 KiB
Python
247 lines
9.1 KiB
Python
"""Tests for _compliance_state.explain_lock_decision's full branch trace."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import UTC, datetime
|
|
import json
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import patch
|
|
|
|
from screen_locker._compliance_state import explain_lock_decision
|
|
from screen_locker._sick_tracker import SickHistory
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
def _today() -> str:
|
|
return datetime.now(tz=UTC).strftime("%Y-%m-%d")
|
|
|
|
|
|
class TestExplainLockDecision:
|
|
"""Full branch trace of the read-only lock-decision chain."""
|
|
|
|
def _files(self, tmp_path: Path) -> dict[str, Path]:
|
|
return {
|
|
"log_file": tmp_path / "log.json",
|
|
"scheduled_skips_file": tmp_path / "scheduled_skips.json",
|
|
"early_bird_pending_file": tmp_path / "early_bird_pending.json",
|
|
}
|
|
|
|
def test_scheduled_skip_short_circuits(self, tmp_path: Path) -> None:
|
|
files = self._files(tmp_path)
|
|
files["scheduled_skips_file"].write_text(json.dumps([_today()]))
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=False,
|
|
)
|
|
assert result.fired is False
|
|
assert result.stage == "scheduled_skip"
|
|
assert result.trace[0].fired is True
|
|
|
|
def test_early_bird_window_still_open_skips(self, tmp_path: Path) -> None:
|
|
files = self._files(tmp_path)
|
|
files["early_bird_pending_file"].write_text(
|
|
json.dumps({"date": _today(), "hmac": "sig"})
|
|
)
|
|
now = datetime.now(tz=UTC).astimezone().replace(hour=6, minute=0)
|
|
with patch(
|
|
"screen_locker._compliance_predicates.verify_entry_hmac", return_value=True
|
|
):
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=False,
|
|
now=now,
|
|
)
|
|
assert result.fired is False
|
|
assert result.stage == "early_bird_window_open"
|
|
|
|
def test_expired_early_bird_falls_through_to_full_lock(
|
|
self, tmp_path: Path
|
|
) -> None:
|
|
files = self._files(tmp_path)
|
|
files["early_bird_pending_file"].write_text(
|
|
json.dumps({"date": _today(), "hmac": "sig"})
|
|
)
|
|
now = datetime.now(tz=UTC).astimezone().replace(hour=10, minute=0)
|
|
with patch(
|
|
"screen_locker._compliance_predicates.verify_entry_hmac", return_value=True
|
|
):
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=False,
|
|
now=now,
|
|
)
|
|
assert result.fired is True
|
|
assert result.stage == "full_lock_pending_heat_check"
|
|
assert result.auto_upgrade.via == "early_bird_expired"
|
|
expired_step = next(
|
|
t for t in result.trace if t.name == "early_bird_pending_expired"
|
|
)
|
|
assert expired_step.fired is True
|
|
|
|
def test_sick_day_skips(self, tmp_path: Path) -> None:
|
|
files = self._files(tmp_path)
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(sick_days=[_today()]),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=False,
|
|
now=datetime.now(tz=UTC).astimezone().replace(hour=12, minute=0),
|
|
)
|
|
assert result.fired is False
|
|
assert result.stage == "sick_day"
|
|
|
|
def test_already_logged_skips(self, tmp_path: Path) -> None:
|
|
files = self._files(tmp_path)
|
|
files["log_file"].write_text(json.dumps({_today(): {"hmac": "sig"}}))
|
|
with patch(
|
|
"screen_locker._compliance_predicates.verify_entry_hmac", return_value=True
|
|
):
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=False,
|
|
now=datetime.now(tz=UTC).astimezone().replace(hour=12, minute=0),
|
|
)
|
|
assert result.fired is False
|
|
assert result.stage == "already_logged"
|
|
|
|
def test_wake_alarm_skip_skips(self, tmp_path: Path) -> None:
|
|
files = self._files(tmp_path)
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=False,
|
|
wake_skip=True,
|
|
now=datetime.now(tz=UTC).astimezone().replace(hour=12, minute=0),
|
|
)
|
|
assert result.fired is False
|
|
assert result.stage == "wake_alarm_skip"
|
|
|
|
def test_fresh_early_bird_time_skips(self, tmp_path: Path) -> None:
|
|
files = self._files(tmp_path)
|
|
now = datetime.now(tz=UTC).astimezone().replace(hour=6, minute=0)
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=False,
|
|
now=now,
|
|
)
|
|
assert result.fired is False
|
|
assert result.stage == "early_bird_time_fresh"
|
|
assert "08:30" in result.reason
|
|
assert "09:00" not in result.reason
|
|
|
|
def test_fresh_early_bird_time_names_09_00_when_extended(
|
|
self, tmp_path: Path
|
|
) -> None:
|
|
"""The re-check time isn't ambiguous — it's whichever one actually applies."""
|
|
files = self._files(tmp_path)
|
|
now = datetime.now(tz=UTC).astimezone().replace(hour=6, minute=0)
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=True,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=False,
|
|
now=now,
|
|
)
|
|
assert result.fired is False
|
|
assert result.stage == "early_bird_time_fresh"
|
|
assert "09:00" in result.reason
|
|
assert "08:30" not in result.reason
|
|
|
|
def test_relaxed_day_skips(self, tmp_path: Path) -> None:
|
|
files = self._files(tmp_path)
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=True,
|
|
now=datetime.now(tz=UTC).astimezone().replace(hour=12, minute=0),
|
|
)
|
|
assert result.fired is False
|
|
assert result.stage == "relaxed_day"
|
|
|
|
def test_relaxed_day_already_skipped_short_circuits_before_relaxed_day(
|
|
self, tmp_path: Path
|
|
) -> None:
|
|
"""A same-day relaxed_day_skip entry reports its own accurate stage.
|
|
|
|
Without this, the trace would report the generic "relaxed_day" stage
|
|
even after the user already dismissed today's prompt, which is
|
|
misleading — the popup is not about to be shown again.
|
|
"""
|
|
from screen_locker._log_mixin import write_signed_entry
|
|
|
|
files = self._files(tmp_path)
|
|
write_signed_entry(files["log_file"], _today(), {"type": "relaxed_day_skip"})
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=True,
|
|
now=datetime.now(tz=UTC).astimezone().replace(hour=12, minute=0),
|
|
)
|
|
assert result.fired is False
|
|
assert result.stage == "relaxed_day_already_skipped"
|
|
|
|
def test_weekly_minimum_met_skips(self, tmp_path: Path) -> None:
|
|
files = self._files(tmp_path)
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=True,
|
|
relaxed_day=False,
|
|
now=datetime.now(tz=UTC).astimezone().replace(hour=12, minute=0),
|
|
)
|
|
assert result.fired is False
|
|
assert result.stage == "weekly_minimum_met"
|
|
|
|
def test_full_lock_when_nothing_applies(self, tmp_path: Path) -> None:
|
|
files = self._files(tmp_path)
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=False,
|
|
now=datetime.now(tz=UTC).astimezone().replace(hour=12, minute=0),
|
|
)
|
|
assert result.fired is True
|
|
assert result.stage == "full_lock_pending_heat_check"
|
|
assert result.auto_upgrade.via == "none"
|
|
assert result.heat_skip_evaluated is False
|
|
|
|
def test_defaults_now_to_current_time(self, tmp_path: Path) -> None:
|
|
"""Covers the ``now is None`` branch — just needs to not raise."""
|
|
files = self._files(tmp_path)
|
|
result = explain_lock_decision(
|
|
**files,
|
|
sick_history=SickHistory(),
|
|
extended_early_bird=False,
|
|
weekly_minimum_met=False,
|
|
relaxed_day=False,
|
|
)
|
|
assert isinstance(result.fired, bool)
|