mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-10 20:27:13 +01:00
`requires-python` and the CI pin already said 3.14, but ruff, mypy and pylint were still grading against 3.10 -- three tools judging an interpreter nothing runs any more, and ruff withholding the pyupgrade fixes that only become safe at the newer target. `pin_ci_python.py` rewrites exactly these three knobs. What the stale target was hiding: 118 sites on `datetime.timezone.utc` instead of `datetime.UTC` (UP017), two classes still written with `Generic[...]` rather than PEP 695 syntax, and ruff's stable formatter applying PEP 758 -- `except (A, B):` becomes `except A, B:`. That last one makes the source 3.14-only at the syntax level, which is what `requires-python = ">=3.14"` already promised; kuhy chose it deliberately over holding ruff a release back (2026-08-29). The PEP 695 fix needed a hand: ruff rewrote `class WidgetGroup(Generic[_W])` to `class WidgetGroup[W: tk.Misc]` but left the body annotated with the module-level `_W`, a *different* type variable -- mypy caught it as "a function returning TypeVar should receive at least one argument containing the same TypeVar". Renamed the body to the new parameter, gave `FrameGroup.__init__` the concrete `list[tk.Frame]` it always wrapped, and deleted the two now-dead module-level TypeVars. ruff, ruff-format, mypy --strict and both pylint passes clean at the new target. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SfnJmxxsZ534AKk16rC2Gr
196 lines
6.3 KiB
Python
196 lines
6.3 KiB
Python
"""Tests for scheduled skip date feature in screen_lock.py."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import UTC, datetime
|
|
import json
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from screen_locker.tests.conftest import create_locker
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
from screen_locker.screen_lock import ScreenLocker
|
|
|
|
|
|
class TestIsScheduledSkipToday:
|
|
"""Tests for ScreenLocker._is_scheduled_skip_today."""
|
|
|
|
def _make_locker(self, mock_tk: MagicMock, tmp_path: Path) -> ScreenLocker:
|
|
return create_locker(mock_tk, tmp_path)
|
|
|
|
def test_returns_false_when_file_absent(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Returns False when scheduled_skips.json does not exist."""
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
skip_file = tmp_path / "scheduled_skips.json"
|
|
with patch(
|
|
"screen_locker._log_mixin.SCHEDULED_SKIPS_FILE",
|
|
skip_file,
|
|
):
|
|
assert locker._is_scheduled_skip_today() is False
|
|
|
|
def test_returns_true_when_today_listed(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Returns True when today's date is in the skips list."""
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
today = datetime.now(tz=UTC).strftime("%Y-%m-%d")
|
|
skip_file = tmp_path / "scheduled_skips.json"
|
|
skip_file.write_text(json.dumps([today]))
|
|
with patch(
|
|
"screen_locker._log_mixin.SCHEDULED_SKIPS_FILE",
|
|
skip_file,
|
|
):
|
|
assert locker._is_scheduled_skip_today() is True
|
|
|
|
def test_returns_false_when_today_not_listed(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Returns False when today's date is not in the skips list."""
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
skip_file = tmp_path / "scheduled_skips.json"
|
|
skip_file.write_text(json.dumps(["1999-01-01", "2000-06-15"]))
|
|
with patch(
|
|
"screen_locker._log_mixin.SCHEDULED_SKIPS_FILE",
|
|
skip_file,
|
|
):
|
|
assert locker._is_scheduled_skip_today() is False
|
|
|
|
def test_returns_false_on_corrupt_json(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Returns False when the skips file contains invalid JSON."""
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
skip_file = tmp_path / "scheduled_skips.json"
|
|
skip_file.write_text("{not valid json}")
|
|
with patch(
|
|
"screen_locker._log_mixin.SCHEDULED_SKIPS_FILE",
|
|
skip_file,
|
|
):
|
|
assert locker._is_scheduled_skip_today() is False
|
|
|
|
def test_returns_false_on_read_error(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Returns False when the skips file cannot be read (OSError)."""
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
skip_file = tmp_path / "scheduled_skips.json"
|
|
skip_file.write_text("[]")
|
|
with (
|
|
patch(
|
|
"screen_locker._log_mixin.SCHEDULED_SKIPS_FILE",
|
|
skip_file,
|
|
),
|
|
patch("builtins.open", side_effect=OSError("permission denied")),
|
|
):
|
|
assert locker._is_scheduled_skip_today() is False
|
|
|
|
def test_empty_list_returns_false(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Returns False for an empty skips list."""
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
skip_file = tmp_path / "scheduled_skips.json"
|
|
skip_file.write_text("[]")
|
|
with patch(
|
|
"screen_locker._log_mixin.SCHEDULED_SKIPS_FILE",
|
|
skip_file,
|
|
):
|
|
assert locker._is_scheduled_skip_today() is False
|
|
|
|
|
|
class TestScheduledSkipEarlyExit:
|
|
"""Tests for _check_non_verify_exits behaviour with scheduled skips."""
|
|
|
|
@staticmethod
|
|
def _write_today_skip(tmp_path: Path) -> None:
|
|
today = datetime.now(tz=UTC).strftime("%Y-%m-%d")
|
|
skip_file = tmp_path / "scheduled_skips.json"
|
|
skip_file.write_text(json.dumps([today]))
|
|
|
|
def test_exits_on_scheduled_skip_day(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Screen locker calls sys.exit(0) when today is a scheduled skip."""
|
|
self._write_today_skip(tmp_path)
|
|
mock_sys_exit.side_effect = SystemExit(0)
|
|
|
|
with pytest.raises(SystemExit):
|
|
create_locker(mock_tk, tmp_path)
|
|
|
|
mock_sys_exit.assert_called_once_with(0)
|
|
|
|
def test_does_not_exit_when_not_scheduled_skip(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Screen locker proceeds normally when today is not a scheduled skip."""
|
|
# No file written — _is_scheduled_skip_today returns False
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
|
|
mock_sys_exit.assert_not_called()
|
|
assert locker is not None
|
|
|
|
def test_scheduled_skip_takes_precedence_over_has_logged(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Scheduled skip exits before has_logged or other checks run."""
|
|
self._write_today_skip(tmp_path)
|
|
mock_sys_exit.side_effect = SystemExit(0)
|
|
|
|
with pytest.raises(SystemExit):
|
|
create_locker(mock_tk, tmp_path, has_logged=False)
|
|
|
|
mock_sys_exit.assert_called_once_with(0)
|
|
|
|
def test_verify_only_mode_ignores_scheduled_skip(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""verify_only mode does not consult scheduled skips."""
|
|
self._write_today_skip(tmp_path)
|
|
|
|
# verify_only exits because no sick day log, not because of scheduled skip
|
|
create_locker(
|
|
mock_tk,
|
|
tmp_path,
|
|
verify_only=True,
|
|
is_sick_day_log=False,
|
|
)
|
|
|
|
mock_sys_exit.assert_called_once_with(0)
|