mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-11-10 21:27:13 +01:00
Krzysztof kuhy Rudnicki
589b9e227d
Some checks failed
pre-commit / pre-commit (push) Has been cancelled
Tests / test (3.10) (push) Has been cancelled
Tests / test (3.11) (push) Has been cancelled
Tests / test (3.12) (push) Has been cancelled
Tests / lock-popup-safety (push) Has been cancelled
release-apk / release (APK) (push) Has been cancelled
The decision ladders are first-match-wins: the matching branch calls
sys.exit(0), so no later condition is ever evaluated or recorded. That made
DECISION lock=no reason=early_bird_window_active
ambiguous in the one way that matters -- it cannot say whether the workout was
also already done, or the weekly minimum already met. Reading it, the 08:30
re-check looks like it is about to lock a machine that has nothing left to
prove, and the only way to find out was to re-derive the ladder by hand.
Keep the acting reason exactly as it was: it is the branch that actually
controlled behaviour, and it stays a stable grep-able slug that can be counted
across runs. Add the conditions that also held as an "also=" extra, which
as_line() already renders as key=value. A decision with a single reason still
renders the line it always did, so the common case needs no new format.
Only side-effect-free predicates are collected. _try_auto_upgrade_* writes log
entries and does ADB/network work, and _save_early_bird_pending writes state;
running either to produce a log line would turn a reporting change into a
state mutation in the enforcer. Verified that annotating leaves log.json and
early_bird_pending.json byte-identical.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PCUN9mdfJzJXqEZatHnUCD
224 lines
9.1 KiB
Python
224 lines
9.1 KiB
Python
"""Mixin: auto-upgrade early_bird/sick_day pending states via phone or RunnerUp.
|
|
|
|
Neither early_bird (a same-day pending marker, see ``_early_bird.py``) nor
|
|
sick_day (tracked in ``sick_history.json`` via ``_sick_tracker.py``) live in
|
|
log.json — this module only checks their pending state and, on
|
|
success, writes the *real* outcome (phone_verified/runnerup_verified) there.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
import sys
|
|
|
|
from screen_locker import _sick_tracker
|
|
from screen_locker._decision_log import LockDecision, record_decision
|
|
from screen_locker._decision_reasons import reasons_extra
|
|
from screen_locker._wake_state import has_workout_skip_today
|
|
from screen_locker._weekly_check import has_weekly_minimum, is_relaxed_day
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
def _skip(reason: str, detail: str, **extra: object) -> None:
|
|
"""Record a decision NOT to enforce, then exit.
|
|
|
|
Every branch that abandons enforcement goes through here. Before this
|
|
existed each one just logged at INFO and called ``sys.exit(0)``, which is
|
|
how the locker managed to stop enforcing for thirteen days without leaving
|
|
a single line saying so.
|
|
"""
|
|
record_decision(
|
|
LockDecision(locked=False, reason=reason, detail=detail, extra=extra)
|
|
)
|
|
sys.exit(0)
|
|
|
|
|
|
class _ReasonsMixin:
|
|
"""Supplies the side-effect-free conditions that annotate a decision.
|
|
|
|
The ladder below is first-match-wins, so only the acting reason was ever
|
|
recorded. These predicates let a line also name the conditions that held
|
|
but were never reached -- notably "the workout is already logged" hiding
|
|
behind "the early-bird window is open".
|
|
"""
|
|
|
|
def _other_conditions(self, acting: str) -> dict[str, object]:
|
|
"""Return the ``also=`` extra naming every other condition that holds.
|
|
|
|
Strictly read-only. ``_try_auto_upgrade_*`` and
|
|
``_save_early_bird_pending`` are deliberately absent: they write log
|
|
entries and state, and must never run to produce a log line.
|
|
"""
|
|
return reasons_extra(
|
|
acting,
|
|
{
|
|
"scheduled_skip_day": self._is_scheduled_skip_today,
|
|
"early_bird_window_active": self._is_early_bird_pending,
|
|
"sick_day": self._is_sick_day_today,
|
|
"workout_logged_today": self.has_logged_today,
|
|
"wake_alarm_skip": has_workout_skip_today,
|
|
"relaxed_day": is_relaxed_day,
|
|
"weekly_minimum_met": lambda: has_weekly_minimum(self.log_file),
|
|
},
|
|
)
|
|
|
|
|
|
class AutoUpgradeMixin(_ReasonsMixin):
|
|
"""Handles today-state detection and silent log-entry upgrading.
|
|
|
|
Relies on methods from EarlyBirdMixin, PhoneVerificationMixin,
|
|
RunnerUpVerificationMixin, LogMixin, and ShutdownMixin via MRO.
|
|
"""
|
|
|
|
def _is_sick_day_today(self) -> bool:
|
|
"""Check if today is marked as a sick day in sick_history.json."""
|
|
return _sick_tracker.is_sick_day(_sick_tracker.load_history())
|
|
|
|
def _check_early_exits(self, *, verify_only: bool) -> None:
|
|
"""Check startup conditions and exit early when appropriate."""
|
|
if verify_only:
|
|
if not self._is_sick_day_today():
|
|
_skip("no_sick_day_to_verify", "No sick day logged today.")
|
|
return
|
|
self._check_non_verify_exits()
|
|
|
|
def _check_today_state_exits(self) -> bool:
|
|
"""Handle early-bird and today's log states. Return True to stop startup."""
|
|
if self._is_early_bird_pending() and not self._is_early_bird_time():
|
|
if self._try_auto_upgrade_early_bird():
|
|
_skip(
|
|
"early_bird_auto_upgraded",
|
|
"Auto-upgraded early_bird entry to phone_verified.",
|
|
)
|
|
return True
|
|
return False # Expired early bird, upgrade unavailable — full lock.
|
|
if self._is_early_bird_pending():
|
|
# The ONLY thing that closes this window is
|
|
# early-bird-workout-check.timer. When that timer was disabled by an
|
|
# ordering cycle (2026-08-04) this branch silently deferred the lock
|
|
# every single day, forever.
|
|
_skip(
|
|
"early_bird_window_active",
|
|
"Early bird window still active — deferring to the 08:30/09:05 "
|
|
"re-check timer.",
|
|
recheck_by="early-bird-workout-check.timer",
|
|
**self._other_conditions("early_bird_window_active"),
|
|
)
|
|
elif self._is_sick_day_today():
|
|
if self._try_auto_upgrade_sick_day():
|
|
_skip(
|
|
"sick_day_auto_upgraded",
|
|
"Auto-upgraded today's sick_day entry to phone_verified.",
|
|
)
|
|
else:
|
|
_skip(
|
|
"sick_day",
|
|
"Sick day already logged today.",
|
|
**self._other_conditions("sick_day"),
|
|
)
|
|
elif self.has_logged_today():
|
|
_skip(
|
|
"workout_logged_today",
|
|
"Workout already logged today.",
|
|
**self._other_conditions("workout_logged_today"),
|
|
)
|
|
elif has_workout_skip_today():
|
|
_skip(
|
|
"wake_alarm_skip",
|
|
"Wake alarm earned a workout skip.",
|
|
**self._other_conditions("wake_alarm_skip"),
|
|
)
|
|
elif self._is_early_bird_time():
|
|
self._save_early_bird_pending()
|
|
_skip(
|
|
"early_bird_banked",
|
|
"Early bird time — banked the pending marker, will re-check "
|
|
"at 08:30/09:05.",
|
|
recheck_by="early-bird-workout-check.timer",
|
|
)
|
|
else:
|
|
return False
|
|
return True
|
|
|
|
def _try_auto_upgrade_sick_day(self) -> bool:
|
|
"""Upgrade sick_day entry when phone or RunnerUp detects a valid workout."""
|
|
try:
|
|
status, message = self._verify_phone_workout()
|
|
except (OSError, RuntimeError) as exc:
|
|
_logger.warning(
|
|
"Sick-day auto-upgrade could not reach the phone (%s) — today's "
|
|
"sick_day entry stays unverified; trying RunnerUp next",
|
|
exc,
|
|
)
|
|
status, message = "error", str(exc)
|
|
if status == "verified":
|
|
self.workout_data["type"] = "phone_verified"
|
|
self.workout_data["source"] = message
|
|
self.workout_data["after_sick_day"] = "true"
|
|
self._adjust_shutdown_time_later()
|
|
self.save_workout_log()
|
|
return True
|
|
_logger.info("Auto-upgrade phone skipped (%s), trying RunnerUp...", status)
|
|
try:
|
|
runnerup_status, runnerup_msg = self._verify_runnerup_workout()
|
|
except (OSError, RuntimeError) as exc:
|
|
_logger.warning(
|
|
"Sick-day auto-upgrade could not read RunnerUp either (%s) — "
|
|
"today stays a sick_day, NOT upgraded to a verified workout",
|
|
exc,
|
|
)
|
|
return False
|
|
if runnerup_status != "verified":
|
|
_logger.info(
|
|
"Auto-upgrade RunnerUp skipped (%s): %s", runnerup_status, runnerup_msg
|
|
)
|
|
return False
|
|
self.workout_data["type"] = "runnerup_verified"
|
|
self.workout_data["source"] = runnerup_msg
|
|
self.workout_data["after_sick_day"] = "true"
|
|
self._adjust_shutdown_time_later()
|
|
self.save_workout_log()
|
|
return True
|
|
|
|
def _try_auto_upgrade_early_bird(self) -> bool:
|
|
"""Try phone then RunnerUp to upgrade an early_bird log entry."""
|
|
try:
|
|
status, message = self._verify_phone_workout()
|
|
except (OSError, RuntimeError) as exc:
|
|
_logger.warning(
|
|
"Early-bird auto-upgrade could not reach the phone (%s) — the "
|
|
"early_bird entry stays unverified; trying RunnerUp next",
|
|
exc,
|
|
)
|
|
status, message = "error", str(exc)
|
|
if status == "verified":
|
|
self.workout_data["type"] = "phone_verified"
|
|
self.workout_data["source"] = message
|
|
self.workout_data["after_early_bird"] = "true"
|
|
self._adjust_shutdown_time_later()
|
|
self.save_workout_log()
|
|
return True
|
|
_logger.info("Early bird phone skipped (%s), trying RunnerUp...", status)
|
|
try:
|
|
runnerup_status, runnerup_msg = self._verify_runnerup_workout()
|
|
except (OSError, RuntimeError) as exc:
|
|
_logger.warning(
|
|
"Early-bird auto-upgrade could not read RunnerUp either (%s) — "
|
|
"the expired early_bird entry is NOT upgraded, so the screen "
|
|
"will lock",
|
|
exc,
|
|
)
|
|
return False
|
|
if runnerup_status != "verified":
|
|
_logger.info(
|
|
"Early bird RunnerUp skipped (%s): %s", runnerup_status, runnerup_msg
|
|
)
|
|
return False
|
|
self.workout_data["type"] = "runnerup_verified"
|
|
self.workout_data["source"] = runnerup_msg
|
|
self.workout_data["after_early_bird"] = "true"
|
|
self._adjust_shutdown_time_later()
|
|
self.save_workout_log()
|
|
return True
|