mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-14 16:11:03 +01:00
34b9900a90
3 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
| 34b9900a90 |
fix: green CI, and a page that has actually been looked at
Two things the last commits could not have caught. CI was red on every commit for as long as scripts/e2e.sh has existed, and for two reasons, not one. ci.yml never installed ffmpeg or exiftool while install_service.sh installs both for the host, so tool/e2e_fixtures.py could not build its JPEG and MP4 fixtures. That step is added and verified by running the binaries rather than by trusting apt's exit code. Underneath it was a flake that ffmpeg alone would not have fixed. With the tools present, e2e still failed two scenarios per run -- never the same two twice, always one reporting "captured 0" and another "captured 2". The cause is fake_signal/cli.py sleeping a fixed settle after each injection and then reading the sends: a reply that fetches an image and shells out to exiftool lands after that expires, so it arrives after the NEXT scenario's reset and is counted against that one instead. It now waits for the count it expects, with a deadline, and then for a beat of quiet -- returning the moment the count arrives would make "expected 1, captured 2" unobservable, because the surplus send is exactly the one that has not landed yet. A scenario expecting nothing skips the poll and waits out the settle, which is the only way to assert that nothing happens. --patience is exposed so the tests can drive the give-up path without waiting it out; test_cli went from 45s to 0.4s. Two consecutive full runs: 28 ok, 0 FAIL, exit 0. And the page had no styling at all. Times New Roman on white, default buttons, and the tagger's charcoal theme lost in the absorption -- the jsdom suite asserts behaviour and cannot see any of that. @kuhyx/web-ui's tokens.css is now imported and src/index.css lays the page out with those tokens only, inventing no values. The visual pass also found a real defect the tests could not: the active tab was unreadable after being clicked. `button:hover` is more specific than a bare attribute selector, so with the pointer still resting on the tab you just clicked, the active rule lost and --on-fill dark text repainted onto --surface-2 dark. Confirmed by reading the computed style, not by eye: bg was rgb(56,49,46) where it should have been the accent. The active rule now claims :hover too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01416TegJ3sa8xL5qGGgrygP |
|||
| 8500a1add1 |
fix: the absorbed tagger gets its setup form and untagged filter back
The first pass shipped the tagging checkboxes and nothing else, which was a regression dressed as an absorption: an album with no people.json has an empty roster, so the checkboxes rendered an empty list and there was no way to add anybody. The old page gated a setup form on `configured` for exactly that reason. So does this one now. Restored, behaviour-for-behaviour: - The roster grammar, in src/api/setup.ts. One person per line, aliases by comma, `=` for a combination with `+` meaning both and `|` meaning either. Keys are reused for anyone already listed and otherwise handed out one past the highest in use -- never the count, or a key deleted by hand gets reissued and inherits somebody else's photos. Mirrors pack_people.next_key. - The add-person box, for the usual case of noticing a new face in the photo already on screen. - `--untagged`, which was a no-op: it is a view filter, and anything seen this session stays navigable, or tagging the photo you are looking at removes it from the list you are walking. DOCS-web-ui.md claimed group ids were "picked, never typed" while settings rendered a plain text box. That was the mitigation cited for accepting an .env editor at all, so the claim is now backed by a <select> filled from /api/groups -- and a failed listing leaves it empty rather than unhandled. parseSetup returns a result instead of throwing, and readCombos has one return type: a try/catch in the view carried an "and if it was some other error" branch that could not happen, and an untestable branch is an untested one. Same reason the album view splits into roster.tsx and tagger.tsx. Still 100% on all four metrics with no exclude list, and verified against the real album: 185 items, 4 groups in the picker, guard still answering 421. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01416TegJ3sa8xL5qGGgrygP |
|||
| a24d0d5905 |
feat: one page to manage the bot, and the tagger folded into it
./web.sh serves health, the configuration and the photo album on 127.0.0.1:8140 -- the port tool/tagger.py vacates. React 19, Vite 8, TypeScript 6.0.3, ESLint 10 with strictTypeChecked + stylisticTypeChecked + unicorn + sonarjs + perfectionist, Vitest 4 at 100% on all four metrics. No coverage exclude list, including for main.tsx. This repository treats a coverage omit as a suppression, and "the DOM bootstrap is awkward to assert" is the same sentence as "this code is untested" -- so the bootstrap is a shim thin enough to test in jsdom, and the album view holds its file list apart from the album so the update path stopped carrying a "what if it is null" branch that cannot happen. An untestable branch is an untested one. TypeScript stays at 6.0.3: typescript-eslint 8.68.0 declares typescript >=4.8.4 <6.1.0, and the fleet-wide allowlist entry says the compiler waits for the linter. The freshness gate then caught two pins the reference repo was carrying stale -- eslint-plugin-unicorn 73 -> 74 and a floating node-version: "24" in CI -- both bumped rather than allowlisted. Traps the gates found, all of them real: - .gitignore has a bare lib/, which matches at any depth, so web/src/lib/ would have been silently untracked. The source lives in src/api/. - CI's shellcheck glob was `run.sh scripts/*.sh`, so tag.sh was unlinted in CI for its whole life and web.sh would have inherited that. Now ./*.sh. - tsconfig.json is strict JSON, not JSONC: check-json is generic and tsconfig being commentable is a convention, not a requirement. - The personal-data gate refused an invented phone number in a test, which is exactly what it is for. The album's warning that names a command moved with the command, and every path that pointed at tool/tagger.py now points at ./web.sh. The historical mentions stay: they explain why the code is shaped as it is. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01416TegJ3sa8xL5qGGgrygP |
