# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence. """The registry holder: rebuilt whole, swapped once, never left half-built.""" from __future__ import annotations from typing import TYPE_CHECKING import pytest from signal_bot.groups import ConfigError from signal_bot.registry import CommandRegistry, DuplicateTriggerError from signal_bot.registry_holder import RegistryHolder if TYPE_CHECKING: from signal_bot.context import CommandContext async def _noop(ctx: CommandContext) -> None: """A handler that does nothing; only the table's shape matters here.""" def _table(*names: str) -> CommandRegistry: registry = CommandRegistry() for name in names: registry.register(name, [f"!{name}"], _noop, f"{name} description") return registry class _Builder: """A builder whose answer can be changed between calls, like data on disk.""" def __init__(self, *names: str) -> None: self.names = names self.error: Exception | None = None self.calls = 0 def __call__(self) -> CommandRegistry: self.calls += 1 if self.error is not None: raise self.error return _table(*self.names) def test_the_first_table_is_built_at_construction() -> None: builder = _Builder("cat") holder = RegistryHolder(builder) assert builder.calls == 1 assert holder.registry.resolve("!cat") is not None assert holder.last_error == "" def test_a_bad_table_at_startup_is_fatal() -> None: """No previous table to keep, so the unit must fail rather than answer nothing.""" builder = _Builder("cat") builder.error = ConfigError("tags.json names a file that is not there") with pytest.raises(ConfigError): RegistryHolder(builder) def test_reload_publishes_the_new_table() -> None: builder = _Builder("cat") holder = RegistryHolder(builder) builder.names = ("cat", "dog") assert holder.reload() is True assert holder.registry.resolve("!dog") is not None assert {command.name for command in holder.registry.commands} == {"cat", "dog"} @pytest.mark.parametrize( "error", [ ConfigError("people.json is not valid JSON"), DuplicateTriggerError("!cat is claimed twice"), ], ) def test_bad_data_keeps_the_previous_table( error: Exception, caplog: pytest.LogCaptureFixture ) -> None: """The table that was answering keeps answering; the caller learns why.""" builder = _Builder("cat") holder = RegistryHolder(builder) before = holder.registry builder.error = error assert holder.reload() is False assert holder.registry is before assert holder.last_error == str(error) assert "keeping the previous one" in caplog.text def test_a_later_good_reload_clears_the_error() -> None: builder = _Builder("cat") holder = RegistryHolder(builder) builder.error = ConfigError("broken") holder.reload() builder.error = None assert holder.reload() is True assert holder.last_error == "" def test_a_programming_error_is_not_swallowed() -> None: """Only bad *data* is survivable; a bug must surface, not become a 409.""" builder = _Builder("cat") holder = RegistryHolder(builder) builder.error = TypeError("register() got an unexpected keyword") with pytest.raises(TypeError): holder.reload()