# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence. """The wish-list tables: what they keep, and what a redelivery does to them.""" from __future__ import annotations from typing import TYPE_CHECKING from signal_bot.schema import CLEARED_ON_LEAVE, PERMANENT_TABLES, REBUILT_ON_BUMP if TYPE_CHECKING: from signal_bot.store import Store def test_nothing_collected_reads_as_nothing(store: Store) -> None: """Empty is a state, not an absence of tables.""" assert store.suggestions.filed() == [] assert store.suggestions.unknown() == [] def test_a_replayed_frame_does_not_become_a_second_row(store: Store) -> None: """signal-cli replays undelivered frames when the bot reconnects. Keyed on the envelope's own timestamp rather than the wall clock, so a replay collides with the row it already wrote and is ignored. """ for _ in range(3): store.suggestions.record_unknown("g1", "!cta", "!cta", 500) (row,) = store.suggestions.unknown() assert row.hits == 1 def test_the_same_word_typed_again_later_counts_twice(store: Store) -> None: """A different message is a different row, which is what a tally is for.""" store.suggestions.record_unknown("g1", "!cta", "!cta", 500) store.suggestions.record_unknown("g1", "!cta", "!cta znowu", 600) (row,) = store.suggestions.unknown() assert row.hits == 2 assert row.last_seen == 600 assert row.bodies == ("!cta", "!cta znowu") def test_two_groups_never_share_a_tally(store: Store) -> None: """Every table in this schema is keyed by group first, and so is this one.""" store.suggestions.record_unknown("g1", "!cta", "!cta", 1) store.suggestions.record_unknown("g2", "!cta", "!cta", 1) assert {row.group_id for row in store.suggestions.unknown()} == {"g1", "g2"} def test_tallies_come_back_most_tried_first(store: Store) -> None: """The page is a queue of work, so the loudest request sorts to the top.""" store.suggestions.record_unknown("g1", "!rare", "!rare", 1) store.suggestions.record_unknown("g1", "!often", "!often", 2) store.suggestions.record_unknown("g1", "!often", "!often", 3) assert [row.word for row in store.suggestions.unknown()] == ["!often", "!rare"] def test_suggestions_come_back_newest_first(store: Store) -> None: """The newest idea is the one most likely still worth acting on.""" store.suggestions.record_suggestion("g1", "!old", "stara", 1) store.suggestions.record_suggestion("g1", "!new", "nowa", 2) assert [row.command for row in store.suggestions.filed()] == ["!new", "!old"] def test_two_people_can_ask_for_the_same_command(store: Store) -> None: """Different messages, so different rows -- twelve askers are twelve rows.""" store.suggestions.record_suggestion("g1", "!pogoda", "na jutro", 1) store.suggestions.record_suggestion("g1", "!pogoda", "na tydzień", 2) assert len(store.suggestions.filed()) == 2 def test_leaving_a_group_does_not_discard_the_wish_list(store: Store) -> None: """forget_group clears CLEARED_ON_LEAVE, and these are not among them. A transient group listing that omits a member is the exact failure discovery._permitted guards against, and it must not be able to delete ideas nothing can recompute. """ store.suggestions.record_suggestion("g1", "!pogoda", "na jutro", 1) store.suggestions.record_unknown("g1", "!cta", "!cta", 2) store.forget_group("g1") assert len(store.suggestions.filed()) == 1 assert len(store.suggestions.unknown()) == 1 def test_both_tables_are_declared_permanent() -> None: """The property above, asserted where it is actually configured.""" for table in ("suggestions", "unknown_commands"): assert table in PERMANENT_TABLES assert table not in CLEARED_ON_LEAVE assert table not in REBUILT_ON_BUMP