signal-bot/signal_bot/pack_holder.py
Krzysztof kuhy Rudnicki da016e1b94
Some checks failed
CI / check (push) Has been cancelled
CI / web (push) Has been cancelled
!dodaj lands in a queue; the management page approves it into the album
A photo sent to the chat no longer enters the album by itself. pack_add
strips it, checks it against the album and the queue, and writes it to
pending/ with a sidecar naming the people and labels the sender proposed;
the reply is "czeka na zatwierdzenie". The management page lists the queue
above the tagger, with the proposal pre-ticked, and Approve moves the file
in, mints the labels, records approved_at and asks the bot to rebuild its
table through /_reload -- the same publish path every other data change
takes, so PackHolder.reload is gone. A reload the bot refuses is reported
on the page, not rolled back: the photo is in the album either way.

The personal-data gate now reads pending/*.json too, so a label that is
still waiting for approval is forbidden in the tree already. The e2e run
boots the management page beside the bot with the same environment,
proves the queue is stripped and never reaches media/, approves it through
the real routes, and has !losowe answer with the photo afterwards without
a restart; exiftool is found through media_strip.locate() there rather
than PATH, which lacks vendor_perl on Arch.

!gadaj is dropped from !odcisz: it was within a typo of !dodaj, and the
nearest-command suggestion must never be a coin toss.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-09-04 22:55:39 +02:00

31 lines
1.1 KiB
Python

# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
"""The one box the album's handlers read the pack through.
``pack_command.pack_handler`` used to close over a frozen ``Pack``; every
pack handler now reads ``holder.pack`` at call time instead. It once had a
``reload`` of its own, for the days when ``!add_photo`` wrote straight into
the album and had to publish the result without a restart. Since the
approval queue nothing in the bot's process writes to the album, and a
change on disk reaches the commands the way every other data change does:
``POST /_reload`` rebuilds the whole registry, holder included
(``registry_holder``). The box stays because the handlers are written
against it and because a swap that only ever replaces *Pack data* -- never
a trigger, never ``Command.groups`` -- is the property to preserve if a
faster path is ever wanted again.
"""
from __future__ import annotations
from dataclasses import dataclass
from typing import TYPE_CHECKING
if TYPE_CHECKING:
from signal_bot.pack import Pack
@dataclass(slots=True)
class PackHolder:
"""A mutable reference to the album every handler reads through."""
pack: Pack