mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 18:07:29 +01:00
An unrecognised "!word" was dropped in silence, which made a typo
indistinguishable from the bot being down and threw away the best available
list of commands worth writing. Three things now happen at the one place in
dispatcher.py that used to be a bare `return`.
A near miss is corrected -- "!cta" asks whether you meant "!kot". The
distance is optimal string alignment rather than difflib's ratio: a
transposition is the typo people actually make, it costs one edit here, and
it shreds the matching blocks a ratio counts ("!cta"/"!cat" scores 0.75 but
"!cta"/"!kot" scores 0.50, so no cutoff separates them on principle).
A word with no near miss points at !zaproponuj, which files an idea from
inside the group. Either way the word and the message are recorded, and the
management page grows an Ideas tab that lists them.
Three things stay silent, each for its own reason. "!kot ladny" is a real
trigger with words after it and always has been silent. "!!" is punctuation.
And a command claimed in some *other* group is neither answered nor recorded
-- the album's triggers are real people's names, and pack_scoping.yaml says
it out loud: a refusal would itself announce that the album exists. The
existence check is therefore global, which is what pack_add already asks.
Measured rather than guessed, against the shipped aliases.json:
- a minimum candidate length, because "!ja" is one edit from ~40 of the 676
two-letter words somebody could type; 69 of them got a suggestion before
the rule and 18 after.
- the two-edit budget starts at six characters, not five. At five it put
four pairs of *different* commands within reach of each other --
!pies/!popes, !days/!cats, !dzis/!dni, !mnie/!dni -- and costs nothing to
give up, because every real typo this was written for is one edit away.
test_no_two_commands_are_within_reach_of_each_other fails if a future
alias reopens the gap.
Both new tables are keyed on the envelope's own sent_at_ms, never the wall
clock: signal-cli replays undelivered frames on reconnect, and a clock-keyed
table collects a duplicate row per reconnect instead of ignoring one.
The branch is gated on should_count -- which excludes the bot's own envelope,
and that is the loop guard, since handle() checks is_own nowhere else -- and
wrapped in its own try/except, because it runs above the one that wraps a
handler and Bot.listen has no exception handling of its own.
Suggestions live in SQLite, not in a tracked file, and the export goes to the
state directory. check_personal_data learns the names it refuses from the
live database, so it catches a name somebody has typed and cannot catch a
misspelling of one -- and an unrecognised-command corpus is made of
misspellings. A group-writable file in a public tree is both a leak and a
wedge. The export therefore carries
deliberate !zaproponuj notes in full and unrecognised words as counts only;
bodies stay on the loopback-only page.
Verified on the live bot: restarted, both tables created with every existing
row count unchanged, !cta and !zaproponuj !pogoda delivered through
/_selftest, both rows read back out of the live database, and the journal
names neither the word nor the body.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01416TegJ3sa8xL5qGGgrygP
87 lines
3.1 KiB
Python
87 lines
3.1 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""!zaproponuj -- file an idea for a command that does not exist yet.
|
|
|
|
The other half of what the dispatcher does with an unrecognised word. That
|
|
half is involuntary: it records what people mistyped. This one is somebody
|
|
deliberately writing a note to whoever maintains the bot, which is why it is
|
|
the only text this feature exports into the repository in full.
|
|
|
|
The idea is stored against the command word it asks for, so twelve people
|
|
asking for the same thing collapse into twelve rows under one name rather
|
|
than twelve unrelated sentences.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING, Final
|
|
|
|
from signal_bot.animals import load_aliases
|
|
from signal_bot.folding import fold
|
|
from signal_bot.unknown import SUGGEST_PRIMARY, WORD_SHAPE
|
|
|
|
if TYPE_CHECKING:
|
|
from signal_bot.context import CommandContext
|
|
from signal_bot.decorators import Decorator
|
|
from signal_bot.registry import CommandRegistry
|
|
|
|
COMMAND_NAME: Final = "suggest"
|
|
|
|
DESCRIPTION: Final = "zaproponuj nową komendę, np. !zaproponuj !gekon zdjęcie gekona"
|
|
|
|
USAGE: Final = f"Użycie: {SUGGEST_PRIMARY} !nazwa <co ma robić>"
|
|
NOT_A_NAME: Final = f"To nie wygląda jak nazwa komendy. {USAGE}"
|
|
ALREADY: Final = "{word} już działa. Napisz !pomoc, żeby zobaczyć wszystkie komendy."
|
|
THANKS: Final = "Zapisane: {word} — {body}"
|
|
|
|
|
|
async def _handle(ctx: CommandContext, registry: CommandRegistry) -> None:
|
|
"""Validate one suggestion and file it, or explain why it was not."""
|
|
if not ctx.args:
|
|
await ctx.reply(USAGE)
|
|
return
|
|
word = ctx.args[0]
|
|
word = fold(word if word.startswith("!") else f"!{word}")
|
|
if WORD_SHAPE.match(word) is None:
|
|
await ctx.reply(NOT_A_NAME)
|
|
return
|
|
# Asked without a group, i.e. "does anything claim this anywhere?" --
|
|
# the same question pack_add asks before minting a label. A command
|
|
# scoped to some other group must not be reported as free here, and
|
|
# must not be named either.
|
|
if registry.resolve(word) is not None:
|
|
await ctx.reply(ALREADY.format(word=word))
|
|
return
|
|
body = " ".join(ctx.args[1:]).strip()
|
|
if not body:
|
|
await ctx.reply(USAGE)
|
|
return
|
|
ctx.store.suggestions.record_suggestion(ctx.group_id, word, body, ctx.message.timestamp)
|
|
await ctx.reply(THANKS.format(word=word, body=body))
|
|
|
|
|
|
def register_suggest_command(
|
|
registry: CommandRegistry,
|
|
*,
|
|
decorate: Decorator | None = None,
|
|
aliases: dict[str, list[str]] | None = None,
|
|
) -> None:
|
|
"""Register !zaproponuj on the registry it also reads.
|
|
|
|
Registered with no ``groups``, and it has to stay that way: help_command
|
|
looks its entry up by name for every group it renders, so a scoped
|
|
command named in that table raises KeyError wherever it is not allowed.
|
|
"""
|
|
table = load_aliases() if aliases is None else aliases
|
|
|
|
async def handler(ctx: CommandContext) -> None:
|
|
await _handle(ctx, registry)
|
|
|
|
wrapped = decorate(handler) if decorate is not None else handler
|
|
registry.register(
|
|
COMMAND_NAME,
|
|
table[COMMAND_NAME],
|
|
wrapped,
|
|
DESCRIPTION,
|
|
takes_args=True,
|
|
)
|