mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 19:07:19 +01:00
Krzysztof kuhy Rudnicki
405541be9b
One row per command attempt, not two aggregates written only on success. command_uses holds last-use only and daily_uses counts successes; both are rate-limiter state and both are written by store.record_use, which the dispatcher calls only when a handler returns cleanly. A gate refusal and a crash returned before it, so a command that failed every time looked exactly like one nobody ran, and nothing knew which command a counted message was. command_events now takes every attempt with its outcome, its duration and the item it served; upstream_calls takes every outbound request made while serving one. The two writes stay separate on purpose -- recording a refusal as a use is what slid the cooldown window forward every time somebody was told to wait -- and test_dispatcher_outcomes asserts last_used does not move. Backfilled from journald joined against message_events, with daily_uses filling the residual so the two sources cannot double-count. Two things were wrong on the first attempt and both were found by measuring rather than by reasoning: the window has to be symmetric, because sent_at_ms comes from the sender's phone and the journal stamp from this host (194 of 299 lines landed *before* their own message, by up to 3.2 s); and matching has to be a global closest-pair assignment, because per-row greedy cannot separate two commands seconds apart. Together those took the dropped rows from 137 to zero, and recovered 418 invocations back to 29 August. Also: !analityka in the group, twelve Polish lines, naming at most three people and only ones whose display name has been seen; an Analytics tab with Nivo charts; and continuous latency measurement, which answers the open question in DOCS-latency.md -- a text send is 235 ms and an image send about 2.2 s, so the upload really is where the time goes. EPHEMERAL_TABLES was doing two unrelated jobs and is now two tuples: what a schema bump rebuilds, and what leaving a group clears. daily_uses left the first (it is a backfill source now) and stayed in the second, and _drop_reshaped took over the repair a bump used to do for it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4QTp3h5Q3MvfrwGV8xqPf
31 lines
1015 B
Python
31 lines
1015 B
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""Polish agreement in the reply, split out of test_analytics_command.
|
|
|
|
Three forms, not two, and the rule reads the last *two* digits -- so 12, 13
|
|
and 14 take the many-form while 22, 23 and 24 do not. Getting this wrong is
|
|
the kind of thing the group notices immediately and mentions every time.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from signal_bot.analytics import render
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("count", "expected"),
|
|
[(1, "1 raz"), (2, "2 razy"), (5, "5 razy"), (12, "12 razy"), (22, "22 razy")],
|
|
)
|
|
def test_polish_agreement_on_counts(count: int, expected: str) -> None:
|
|
"""Twelve takes the many-form and twenty-two does not."""
|
|
assert render.times_phrase(count) == expected
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("count", "expected"),
|
|
[(1, "1 dzień"), (2, "2 dni"), (5, "5 dni"), (12, "12 dni")],
|
|
)
|
|
def test_polish_agreement_on_days(count: int, expected: str) -> None:
|
|
assert render.days_phrase(count) == expected
|