signal-bot/tool/e2e_approve.py
Krzysztof kuhy Rudnicki da016e1b94
Some checks failed
CI / check (push) Has been cancelled
CI / web (push) Has been cancelled
!dodaj lands in a queue; the management page approves it into the album
A photo sent to the chat no longer enters the album by itself. pack_add
strips it, checks it against the album and the queue, and writes it to
pending/ with a sidecar naming the people and labels the sender proposed;
the reply is "czeka na zatwierdzenie". The management page lists the queue
above the tagger, with the proposal pre-ticked, and Approve moves the file
in, mints the labels, records approved_at and asks the bot to rebuild its
table through /_reload -- the same publish path every other data change
takes, so PackHolder.reload is gone. A reload the bot refuses is reported
on the page, not rolled back: the photo is in the album either way.

The personal-data gate now reads pending/*.json too, so a label that is
still waiting for approval is forbidden in the tree already. The e2e run
boots the management page beside the bot with the same environment,
proves the queue is stripped and never reaches media/, approves it through
the real routes, and has !losowe answer with the photo afterwards without
a restart; exiftool is found through media_strip.locate() there rather
than PATH, which lacks vendor_perl on Arch.

!gadaj is dropped from !odcisz: it was within a typo of !dodaj, and the
nearest-command suggestion must never be a coin toss.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-09-04 22:55:39 +02:00

65 lines
2.4 KiB
Python
Executable File

#!/usr/bin/env python3
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
"""Approve everything in the album's queue, the way the approver would.
Through the management page's own routes, not by calling pack_pending: the
point of the run is that a photo sent to the chat reaches the album by the
one door that exists, and that the bot answers with it immediately after,
with no restart. Each item is approved with exactly the people and labels
the sender proposed.
--manage-url <base-url> the management app scripts/e2e.sh booted
Exits non-zero if nothing was waiting, if any approval was refused, or if
the bot did not rebuild its table afterwards.
"""
from __future__ import annotations
import argparse
import sys
from typing import Any
import httpx
# The guard on the management app refuses any POST without this header.
JSON_HEADERS = {"content-type": "application/json"}
def approve_all(manage_url: str) -> int:
"""Approve every queued item; report each; fail on any refusal."""
with httpx.Client(base_url=manage_url, timeout=30) as client:
waiting: list[dict[str, Any]] = client.get("/api/album/pending").json()["pending"]
if not waiting:
sys.stderr.write("Error: nothing is waiting for approval\n")
return 1
failures = 0
for item in waiting:
answer = client.post(
f"/api/album/pending/{item['name']}/approve",
json={"keys": item["keys"], "labels": item["labels"]},
headers=JSON_HEADERS,
)
body = answer.json()
if answer.status_code != httpx.codes.OK or not body.get("reloaded"):
sys.stderr.write(f"Error: {item['name']}: {answer.status_code} {body}\n")
failures += 1
continue
sys.stdout.write(f" approved {item['name']} as {body['keys']}\n")
left = client.get("/api/album/pending").json()["pending"]
if left:
sys.stderr.write(f"Error: still waiting after approval: {left}\n")
return 1
return 1 if failures else 0
def main() -> int:
"""Parse the one argument and approve the queue behind it."""
parser = argparse.ArgumentParser(description=__doc__)
parser.add_argument("--manage-url", required=True, metavar="BASE_URL")
return approve_all(parser.parse_args().manage_url)
if __name__ == "__main__":
raise SystemExit(main())