mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 20:27:17 +01:00
Krzysztof kuhy Rudnicki
f92502d18b
Release n is pope n, so the version is a fact about the ordinal rather than a judgement about the size of a change. The constraint that fixes the scheme is Jan Pawel II at 2.13.7: eight patches per minor with majors opening at ordinals 33 and 153 gives (264 - 153) = 13 * 8 + 7 exactly, and both earlier majors happen to divide evenly by eight too, so no bracket needs a fudge factor. The anchors are not arbitrary -- 33 is Sylwester I, pope through the Edict of Milan and Nicaea, and 153 is Wiktor II, the first pope elected after the 1054 schism. popes.json is scraped by tool/gen_popes.py rather than recalled, because antipopes, Benedykt IX's three separate reigns and the Stefan II question all shift the count and being wrong by one moves Jan Pawel II off 2.13.7 silently. The generator refuses to write a list that is not 267 contiguous entries with Jan Pawel II at 264. A second, independent parse of the same page agreed on every ordinal, which is the only reason to believe either. On startup each watched group is told about the releases it has not seen. A group with no record has seen none of them, so the first announcement starts at 0.0.0 "Swiety Piotr Apostol" rather than skipping to whatever is current -- watching the ladder start at Peter is the point of naming releases after popes. A group added years from now would otherwise be handed the whole backlog, so the message is capped at ten releases and says how many it left out. The version is recorded before the message is sent: with Restart=always and RestartSec=5, a crash between the two would re-announce on every restart, and a missed announcement is far cheaper than a looping one. DOCS-changelog.md is the single source -- the bot parses it, so there is no second machine-readable copy to drift. It is DOCS-, not CHANGELOG.md, because the md-naming gate allows four namespaces and that is not one of them. Deliberately NOT bumping SCHEMA_VERSION for the new group_meta table: _apply_schema drops every table on a bump, so bumping to add a table would have thrown away the live tallies to gain nothing. Verified against the real database -- group_meta appeared and all four counts survived the restart. The schema moves to its own module so store.py stays under the 250-line cap, and /healthz now names the build, because there was previously no way to ask a running bot which version it is. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015d48t4qsQLBJnDwDeo2Nom
74 lines
2.2 KiB
Python
74 lines
2.2 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""DOCS-changelog.md is the only copy, so the parser has to earn that."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
from signal_bot.changelog import Release, load, parse, since
|
|
from signal_bot.versioning import __version__
|
|
|
|
DOCUMENT = """\
|
|
# Changelog
|
|
|
|
Prose between releases is ignored.
|
|
|
|
- a bullet before any heading belongs to no release
|
|
|
|
## 0.0.1 — Linus
|
|
|
|
- druga zmiana
|
|
- trzecia zmiana
|
|
|
|
Some more prose.
|
|
|
|
## 0.0.0 — Święty Piotr Apostoł
|
|
|
|
- pierwsza zmiana
|
|
"""
|
|
|
|
|
|
def test_parse_reads_headings_and_their_bullets() -> None:
|
|
releases = parse(DOCUMENT)
|
|
assert [r.version for r in releases] == ["0.0.0", "0.0.1"]
|
|
assert releases[0].pope == "Święty Piotr Apostoł"
|
|
assert releases[1].lines == ("druga zmiana", "trzecia zmiana")
|
|
|
|
|
|
def test_a_bullet_above_every_heading_belongs_to_nobody() -> None:
|
|
"""Otherwise the file's own format documentation becomes a changelog entry."""
|
|
assert all("belongs to no release" not in line for r in parse(DOCUMENT) for line in r.lines)
|
|
|
|
|
|
def test_parse_of_nothing_is_nothing() -> None:
|
|
assert parse("# Changelog\n\njust prose\n") == ()
|
|
|
|
|
|
def test_releases_come_back_oldest_first_whatever_the_file_order() -> None:
|
|
assert [r.ordinal for r in parse(DOCUMENT)] == [1, 2]
|
|
|
|
|
|
def test_since_returns_only_what_the_group_has_not_seen() -> None:
|
|
releases = parse(DOCUMENT)
|
|
assert [r.version for r in since(releases, "0.0.0")] == ["0.0.1"]
|
|
assert since(releases, "0.0.1") == ()
|
|
|
|
|
|
def test_since_an_unknown_version_announces_nothing() -> None:
|
|
"""A hand-edited or downgraded record must not dump the whole backlog."""
|
|
assert since(parse(DOCUMENT), "9.9.9") == ()
|
|
|
|
|
|
def test_a_missing_changelog_costs_an_announcement_not_the_process() -> None:
|
|
assert load(Path("/nonexistent/DOCS-changelog.md")) == ()
|
|
|
|
|
|
def test_the_real_changelog_covers_the_running_version() -> None:
|
|
"""A release with no entry would announce a version and then say nothing."""
|
|
versions = [release.version for release in load()]
|
|
assert __version__ in versions
|
|
|
|
|
|
def test_release_knows_its_ordinal() -> None:
|
|
assert Release("2.13.7", "Jan Paweł II", ()).ordinal == 264
|