mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 20:37:03 +01:00
Krzysztof kuhy Rudnicki
35102be863
Per-person photo commands, where the mechanism is public and the album is not. Nothing identifying is in this repository: who the people are, what fires their photos and which file shows whom all live in one directory outside it, and the tests, the docs and the offline e2e run use three invented people instead. Several names in one message intersect -- "!alfa beta" is a photo with both -- and where an entry offers a choice the bot picks among the readings that actually have a photo, so a question the album could answer is not refused. A combination nobody photographed gets one line rather than silence, which from the group's side is indistinguishable from a broken bot. Scoping is enforced in the dispatcher, not in the handler: a command the group is not allowed resolves to nothing, so it is not answered, not counted as a command, and never named in a log line outside its own groups. A handler that quietly returned would leak all three. Commands are named by pseudonym (pack:p1), so the journal and command_uses say somebody asked for a photo and nothing about whose. Video works: the attachment goes out as data:video/mp4;filename=...;base64, which is the container's own spelling, read off its /swagger/doc.json. Told it is a photo, Signal renders a clip as an unplayable file. tool/tagger.py serves one page on loopback to fill the album in -- names are typed into the page, never as arguments, and it prints how many photos each command would have when it stops, because a command with zero is dead on arrival. Also renames the real people who were still sitting in the stats test fixtures. They remain in the history; the point is that nothing new is added to it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017w1HZ3cZ7neL3rFdQ6VMBA
82 lines
3.0 KiB
Python
82 lines
3.0 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""Finding the private album, and the two different ways it can be absent.
|
|
|
|
Split out of test_config.py, which reached the 250-line cap.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
import pytest
|
|
|
|
from signal_bot.config import ConfigError
|
|
from signal_bot.config_env import load_config
|
|
from tests import pack_fixture
|
|
from tests.test_config import BASE_ENV
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
def test_an_installation_with_no_album_has_no_pack(tmp_path: Path) -> None:
|
|
"""Which is every machine but one, and every test in this suite."""
|
|
assert load_config(dict(BASE_ENV)).photo_pack_dir is None
|
|
|
|
|
|
def test_a_named_album_is_loaded_and_kept(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
|
|
root = pack_fixture.build(tmp_path / "pack")
|
|
monkeypatch.setenv("PHOTO_PACK_DIR", str(root))
|
|
assert load_config(dict(BASE_ENV)).photo_pack_dir == root
|
|
|
|
|
|
def test_a_named_album_that_is_not_there_fails_startup(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""A typo in a path is an answer, not an outage worth retrying."""
|
|
monkeypatch.setenv("PHOTO_PACK_DIR", str(tmp_path / "nowhere"))
|
|
with pytest.raises(ConfigError, match="is not a directory"):
|
|
load_config(dict(BASE_ENV))
|
|
|
|
|
|
def test_a_broken_album_fails_startup_rather_than_every_command(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""Parsed here, where load_config raising exits, not inside a retry loop."""
|
|
root = pack_fixture.build(tmp_path / "pack")
|
|
(root / "people.json").write_text("{}", encoding="utf-8")
|
|
monkeypatch.setenv("PHOTO_PACK_DIR", str(root))
|
|
with pytest.raises(ConfigError, match="defines no commands"):
|
|
load_config(dict(BASE_ENV))
|
|
|
|
|
|
def test_the_album_may_also_be_found_where_systemd_puts_it(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
pack_fixture.build(tmp_path / "state" / "pack")
|
|
monkeypatch.setenv("STATE_DIRECTORY", str(tmp_path / "state"))
|
|
assert load_config(dict(BASE_ENV)).photo_pack_dir == tmp_path / "state" / "pack"
|
|
|
|
|
|
def test_an_empty_album_directory_is_not_a_crash_loop(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""The tagger creates the directory before the manifest exists.
|
|
|
|
With Restart=always, failing on a directory somebody merely created would
|
|
put the unit into a restart loop -- so the implicit path is a hint, and
|
|
only a pack named outright is allowed to fail startup.
|
|
"""
|
|
(tmp_path / "share" / "signal-bot" / "pack" / "media").mkdir(parents=True)
|
|
monkeypatch.setenv("XDG_DATA_HOME", str(tmp_path / "share"))
|
|
assert load_config(dict(BASE_ENV)).photo_pack_dir is None
|
|
|
|
|
|
def test_a_named_album_with_no_manifest_fails_startup(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
(tmp_path / "pack").mkdir()
|
|
monkeypatch.setenv("PHOTO_PACK_DIR", str(tmp_path / "pack"))
|
|
with pytest.raises(ConfigError, match=r"has no people\.json"):
|
|
load_config(dict(BASE_ENV))
|