signal-bot/tests
Krzysztof kuhy Rudnicki 6ec746fad2 feat: a word the bot does not know gets an answer, and gets kept
An unrecognised "!word" was dropped in silence, which made a typo
indistinguishable from the bot being down and threw away the best available
list of commands worth writing. Three things now happen at the one place in
dispatcher.py that used to be a bare `return`.

A near miss is corrected -- "!cta" asks whether you meant "!kot". The
distance is optimal string alignment rather than difflib's ratio: a
transposition is the typo people actually make, it costs one edit here, and
it shreds the matching blocks a ratio counts ("!cta"/"!cat" scores 0.75 but
"!cta"/"!kot" scores 0.50, so no cutoff separates them on principle).

A word with no near miss points at !zaproponuj, which files an idea from
inside the group. Either way the word and the message are recorded, and the
management page grows an Ideas tab that lists them.

Three things stay silent, each for its own reason. "!kot ladny" is a real
trigger with words after it and always has been silent. "!!" is punctuation.
And a command claimed in some *other* group is neither answered nor recorded
-- the album's triggers are real people's names, and pack_scoping.yaml says
it out loud: a refusal would itself announce that the album exists. The
existence check is therefore global, which is what pack_add already asks.

Measured rather than guessed, against the shipped aliases.json:

- a minimum candidate length, because "!ja" is one edit from ~40 of the 676
  two-letter words somebody could type; 69 of them got a suggestion before
  the rule and 18 after.
- the two-edit budget starts at six characters, not five. At five it put
  four pairs of *different* commands within reach of each other --
  !pies/!popes, !days/!cats, !dzis/!dni, !mnie/!dni -- and costs nothing to
  give up, because every real typo this was written for is one edit away.
  test_no_two_commands_are_within_reach_of_each_other fails if a future
  alias reopens the gap.

Both new tables are keyed on the envelope's own sent_at_ms, never the wall
clock: signal-cli replays undelivered frames on reconnect, and a clock-keyed
table collects a duplicate row per reconnect instead of ignoring one.

The branch is gated on should_count -- which excludes the bot's own envelope,
and that is the loop guard, since handle() checks is_own nowhere else -- and
wrapped in its own try/except, because it runs above the one that wraps a
handler and Bot.listen has no exception handling of its own.

Suggestions live in SQLite, not in a tracked file, and the export goes to the
state directory. check_personal_data learns the names it refuses from the
live database, so it catches a name somebody has typed and cannot catch a
misspelling of one -- and an unrecognised-command corpus is made of
misspellings. A group-writable file in a public tree is both a leak and a
wedge. The export therefore carries
deliberate !zaproponuj notes in full and unrecognised words as counts only;
bodies stay on the loopback-only page.

Verified on the live bot: restarted, both tables created with every existing
row count unchanged, !cta and !zaproponuj !pogoda delivered through
/_selftest, both rows read back out of the live database, and the journal
names neither the word nor the body.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01416TegJ3sa8xL5qGGgrygP
2026-08-31 16:48:26 +02:00
..
__init__.py feat: rewrite the bot so it runs, and gate it like the other repos 2026-08-29 13:05:42 +02:00
conftest.py release: 0.2.0 «Urbanus I» — a private photo album, and a tagger for it 2026-08-30 22:35:41 +02:00
gate_helpers.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
manage_fixture.py feat: a word the bot does not know gets an answer, and gets kept 2026-08-31 16:48:26 +02:00
pack_add_fixture.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
pack_fixture.py release: 0.2.0 «Urbanus I» — a private photo album, and a tagger for it 2026-08-30 22:35:41 +02:00
stats_seed.py release: 0.2.0 «Urbanus I» — a private photo album, and a tagger for it 2026-08-30 22:35:41 +02:00
test_allowlist.py feat: refuse to look healthy while deaf, and heal the container by itself 2026-08-29 19:01:55 +02:00
test_animals.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_announce_render.py release: 0.1.7 «Callistus I» — a version now says which pope, and when 2026-08-30 22:12:09 +02:00
test_announce.py fix: a refused attachment no longer costs a group its release notes 2026-08-30 21:33:56 +02:00
test_app.py fix: a signal-api that is not up yet no longer kills the bot at boot 2026-08-30 15:23:42 +02:00
test_bot_catchup.py fix: the evening report is one message, not one per thing it has to say 2026-08-30 22:49:51 +02:00
test_bot_report.py release: 0.1.6 «Zephyrinus» — 21:37 reports today, not yesterday 2026-08-30 22:09:13 +02:00
test_bot.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_changelog.py release: 0.1.7 «Callistus I» — a version now says which pope, and when 2026-08-30 22:12:09 +02:00
test_cli.py fix: green CI, and a page that has actually been looked at 2026-08-31 15:38:24 +02:00
test_config_pack.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_config.py feat: the message event log, and the nightly report built on it 2026-08-30 19:14:43 +02:00
test_cooldown_gate.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_counting.py feat: the message event log, and the nightly report built on it 2026-08-30 19:14:43 +02:00
test_decorators.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_discovery.py feat: the message event log, and the nightly report built on it 2026-08-30 19:14:43 +02:00
test_dispatcher_gates.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_dispatcher_unknown.py feat: a word the bot does not know gets an answer, and gets kept 2026-08-31 16:48:26 +02:00
test_dispatcher.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_envelope_shape.py fix: the operator's uuid was still a fixture in the envelope-shape test 2026-08-30 23:04:42 +02:00
test_external.py feat: python tool/tagger.py sets up .venv too, not just tag.sh 2026-08-31 13:34:27 +02:00
test_fake_account.py feat: refuse to look healthy while deaf, and heal the container by itself 2026-08-29 19:01:55 +02:00
test_fake_groups.py feat: discover groups from the account, so adding the bot is the whole setup 2026-08-29 15:30:08 +02:00
test_fake_server.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_folding.py fix: commands resolve when typed on another alphabet's keyboard 2026-08-30 14:22:43 +02:00
test_healthz.py release: 0.1.7 «Callistus I» — a version now says which pope, and when 2026-08-30 22:12:09 +02:00
test_help_command.py feat: a word the bot does not know gets an answer, and gets kept 2026-08-31 16:48:26 +02:00
test_http_client.py feat: !gekon posts a research-grade gecko photo 2026-08-29 23:26:40 +02:00
test_liveness.py feat: refuse to look healthy while deaf, and heal the container by itself 2026-08-29 19:01:55 +02:00
test_logging_setup.py feat: the bot can describe an envelope without quoting anybody 2026-08-30 19:29:06 +02:00
test_main.py feat: the message event log, and the nightly report built on it 2026-08-30 19:14:43 +02:00
test_manage_album.py feat: the management backend, absorbing the tagger 2026-08-31 14:38:24 +02:00
test_manage_assets.py feat: the management backend, absorbing the tagger 2026-08-31 14:38:24 +02:00
test_manage_envfile.py feat: the .env layer the management page will write through 2026-08-31 14:31:29 +02:00
test_manage_envkeys.py feat: the .env layer the management page will write through 2026-08-31 14:31:29 +02:00
test_manage_guard.py feat: the management backend, absorbing the tagger 2026-08-31 14:38:24 +02:00
test_manage_routes.py feat: the management backend, absorbing the tagger 2026-08-31 14:38:24 +02:00
test_media_sniff.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_media_strip.py feat: import a folder of photos without importing it twice 2026-08-31 13:22:57 +02:00
test_media_tags.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_media_tracks.py feat: import a folder of photos without importing it twice 2026-08-31 13:22:57 +02:00
test_membership.py feat: discover groups from the account, so adding the bot is the whole setup 2026-08-29 15:30:08 +02:00
test_models.py feat: weekly, monthly and year-in-review posts, keyed off the day reported 2026-08-30 19:56:25 +02:00
test_multiple_albums.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_nearest.py feat: a word the bot does not know gets an answer, and gets kept 2026-08-31 16:48:26 +02:00
test_pack_add_invariants.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_pack_add.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_pack_album.py feat: import a folder of photos without importing it twice 2026-08-31 13:22:57 +02:00
test_pack_command.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_pack_custom.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_pack_holder.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_pack_import.py feat: import a folder of photos without importing it twice 2026-08-31 13:22:57 +02:00
test_pack_ledger.py feat: import a folder of photos without importing it twice 2026-08-31 13:22:57 +02:00
test_pack_load.py feat: one page to manage the bot, and the tagger folded into it 2026-08-31 14:54:49 +02:00
test_pack_people.py feat: import a folder of photos without importing it twice 2026-08-31 13:22:57 +02:00
test_pack_random.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_pack_store.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_pack.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_personal_data_sources.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_popes_command.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_portcheck.py feat: make the bot actually reply on Signal, and gate every way it went silent 2026-08-29 14:37:27 +02:00
test_portraits.py release: 0.0.7 «Telesfor» — !papież, and the bot can test itself 2026-08-30 17:06:25 +02:00
test_quoting.py feat: answer the message that asked, not just the room 2026-08-29 23:01:01 +02:00
test_registry.py feat: a word the bot does not know gets an answer, and gets kept 2026-08-31 16:48:26 +02:00
test_routes_suggestions.py feat: a word the bot does not know gets an answer, and gets kept 2026-08-31 16:48:26 +02:00
test_scenario.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_scheduler.py feat: rewrite the bot so it runs, and gate it like the other repos 2026-08-29 13:05:42 +02:00
test_selftest_attachments.py feat: serve several photo albums at once, each scoped to its own groups 2026-08-31 11:58:50 +02:00
test_selftest.py release: 0.0.7 «Telesfor» — !papież, and the bot can test itself 2026-08-30 17:06:25 +02:00
test_startup.py feat: the message event log, and the nightly report built on it 2026-08-30 19:14:43 +02:00
test_stats_backfill.py fix: !ja told everybody their favourite hour was noon 2026-08-30 20:15:20 +02:00
test_stats_commands.py release: 0.2.0 «Urbanus I» — a private photo album, and a tagger for it 2026-08-30 22:35:41 +02:00
test_stats_curiosities.py release: 0.2.0 «Urbanus I» — a private photo album, and a tagger for it 2026-08-30 22:35:41 +02:00
test_stats_events.py feat: the message event log, and the nightly report built on it 2026-08-30 19:14:43 +02:00
test_stats_nightly.py release: 0.1.6 «Zephyrinus» — 21:37 reports today, not yesterday 2026-08-30 22:09:13 +02:00
test_stats_periods.py feat: the message event log, and the nightly report built on it 2026-08-30 19:14:43 +02:00
test_stats_queries_period.py release: 0.2.0 «Urbanus I» — a private photo album, and a tagger for it 2026-08-30 22:35:41 +02:00
test_stats_records.py release: 0.2.0 «Urbanus I» — a private photo album, and a tagger for it 2026-08-30 22:35:41 +02:00
test_stats_render_day.py feat: refuse to commit personal data, learned from outside the repository 2026-08-30 23:28:29 +02:00
test_stats_render_period.py release: 0.1.1 «Pius I» — commands that explain themselves 2026-08-30 20:09:14 +02:00
test_stats_streaks.py release: 0.2.0 «Urbanus I» — a private photo album, and a tagger for it 2026-08-30 22:35:41 +02:00
test_stats_text.py feat: the message event log, and the nightly report built on it 2026-08-30 19:14:43 +02:00
test_store.py feat: the message event log, and the nightly report built on it 2026-08-30 19:14:43 +02:00
test_suggest_command.py feat: a word the bot does not know gets an answer, and gets kept 2026-08-31 16:48:26 +02:00
test_suggestions_store.py feat: a word the bot does not know gets an answer, and gets kept 2026-08-31 16:48:26 +02:00
test_tool_imports.py feat: one page to manage the bot, and the tagger folded into it 2026-08-31 14:54:49 +02:00
test_transport_attachments.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_transport_base.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_transport_fake.py feat: rewrite the bot so it runs, and gate it like the other repos 2026-08-29 13:05:42 +02:00
test_transport_media.py release: 0.2.0 «Urbanus I» — a private photo album, and a tagger for it 2026-08-30 22:35:41 +02:00
test_transport_rest.py feat: add a photo to the album from the chat, tagged, stripped and verified 2026-08-31 11:20:00 +02:00
test_trust.py feat: the message event log, and the nightly report built on it 2026-08-30 19:14:43 +02:00
test_unknown.py feat: a word the bot does not know gets an answer, and gets kept 2026-08-31 16:48:26 +02:00
test_versioning.py release: 0.1.7 «Callistus I» — a version now says which pope, and when 2026-08-30 22:12:09 +02:00